On the testsuite we explicitly disable the sleeps via the environment variable
designed for this (except for a few specific tests). We compensate for this
problem in quite a few places by making sure that we also change the number of
characters in the file.
Bert
> -Original Message-
Philip Martin wrote on 2018-06-14:
> Philip Martin writes:
> > Julian Foad writes:
> >> The most unusual thing about these failing tests is the data they
> >> write. Strings of 5 or 6 low-value bytes, like:
> >>
> >> '\0\1\2\3\4\5'
> >> '\5\4\3\2\1\0'
> >
> > Those are the same size. Could it be
On 14.06.2018 17:36, julianf...@apache.org wrote:
> Author: julianfoad
> Date: Thu Jun 14 15:36:54 2018
> New Revision: 1833512
>
> URL: http://svn.apache.org/viewvc?rev=1833512&view=rev
> Log:
> Change shelf_tests.py binary data tests to use varying file lengths.
I wonder though, isn't this basic
On 14.06.2018 18:09, Philip Martin wrote:
> Philip Martin writes:
>
>> Julian Foad writes:
>>
>>> The most unusual thing about these failing tests is the data they
>>> write. Strings of 5 or 6 low-value bytes, like:
>>>
>>> '\0\1\2\3\4\5'
>>> '\5\4\3\2\1\0'
>> Those are the same size. Could it b
Philip Martin writes:
> Julian Foad writes:
>
>> The most unusual thing about these failing tests is the data they
>> write. Strings of 5 or 6 low-value bytes, like:
>>
>> '\0\1\2\3\4\5'
>> '\5\4\3\2\1\0'
>
> Those are the same size. Could it be a filesystem timestamp resolution
> issue? The f
Julian Foad writes:
> The most unusual thing about these failing tests is the data they
> write. Strings of 5 or 6 low-value bytes, like:
>
> '\0\1\2\3\4\5'
> '\5\4\3\2\1\0'
Those are the same size. Could it be a filesystem timestamp resolution
issue? The file changes but the timestamp does no
Daniel Shahaf wrote on 2018-06-14:
> Julian Foad wrote on Thu, 14 Jun 2018 16:06 +0100:
> > Branko Čibej wrote on 2018-06-14:
> > > A sync (which forces a write to disk) should not be necessary in cases
> > > like this one, as long as we close the file in Python — that should
> > > ensure a write t
Julian Foad wrote on Thu, 14 Jun 2018 16:06 +0100:
> Branko Čibej wrote on 2018-06-14:
> > A sync (which forces a write to disk) should not be necessary in cases
> > like this one, as long as we close the file in Python — that should
> > ensure a write to the OS buffers. If this were the problem, S
Branko Čibej wrote on 2018-06-14:
> A sync (which forces a write to disk) should not be necessary in cases
> like this one, as long as we close the file in Python — that should
> ensure a write to the OS buffers. If this were the problem, Subversion
> wouldn't work on macOS at all.
>
> I still don
On 14.06.2018 16:50, Julian Foad wrote:
> Branko Čibej wrote:
>> The object lifetime and implicit close are very well defined indeed in
>> CPython, which we use. We don't use "modern Pythons on other virtual
>> machines."
>> If this were indeed the source of the problem, a number of
>> other tests
Branko Čibej wrote:
> The object lifetime and implicit close are very well defined indeed in
> CPython, which we use. We don't use "modern Pythons on other virtual
> machines."
> If this were indeed the source of the problem, a number of
> other tests would be failing randomly on that bot, and else
Karol Szkudlarek wrote on 2018-06-14:
> Dear Julian,
>
> Unfortunately I am unable to continue work for Subversion as a polish
> language translator.
Thank you for letting me know.
I have moved your name to the 'dormant' section of the 'COMMITTERS' file, in
r1833511, so you will no longer rece
Branko Čibej wrote on 2018-06-14:
> >sbox.simple_move('A', 'A2')
> >sbox.simple_move('A2/mu', 'A2/mu2')
> > - open(sbox.ospath('A2/mu2'), 'w').write('r2\n')
> > + with open(sbox.ospath('A2/mu2'), 'w') as f:
> > +f.write('r2\n')
>
> I thought we had some kind of utility function for a
Branko Čibej wrote on Thu, 14 Jun 2018 04:04 +0200:
> ... on the other hand, making this suggested change won't hurt, as long
> as our required Python version for tests supports the 'with' statement,
> which I believe it does. In fact we already use the 'with' statement in
> our test suite.
Since
On 14.06.2018 11:02, julianf...@apache.org wrote:
> Author: julianfoad
> Date: Thu Jun 14 09:02:11 2018
> New Revision: 1833501
>
> URL: http://svn.apache.org/viewvc?rev=1833501&view=rev
> Log:
> In the test suite: replace 'open().write()' with a 'with' construct.
>
> The form 'with open() as f: f.
15 matches
Mail list logo
