Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

2018-12-17 Thread Stefan Fuhrmann
On 17.12.18 10:44, Stefan Sperling wrote: I have hit a use-after-free in mod_dav_svn while running SVN's regression tests on OpenBSD with httpd 2.4. This problem was apparently known to the author; see the comment which is removed in the diff below. In short, the request structure used as

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-17 Thread futatuki
On 12/17/18 05:50, Yasuhito FUTATSUKI wrote: I found exception error messages isn't unified for ('a bytes', 'a bytes object', 'a Bytes object'), and nothing but these. I've updated the patch including fix above (unified to 'a bytes objects') and type casting between signed and unsigned for len

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-17 Thread futatuki
On 12/17/18 18:35, Daniel Shahaf wrote: Yasuhito FUTATSUKI wrote on Mon, Dec 17, 2018 at 05:50:03 +0900: On 12/17/18 2:08 AM, Troy Curtis Jr wrote: On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf wrote: Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: But there was one item I wanted to

Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri

2018-12-17 Thread Julian Foad
Branko Čibej wrote: > (svn_relpath__internal_style): Change prototype so that the function > can > return an error instead of aborting if anything goes wrong. > [...]  I'll rename the function at the same time. See IRC: I suggest a name like "svn_relpath__from_rel_dirent",

Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri

2018-12-17 Thread Branko Čibej
On 17.12.2018 13:28, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, 17 Dec 2018 13:19 +0100: >> On 17.12.2018 13:11, Daniel Shahaf wrote: >>> br...@apache.org wrote on Mon, 17 Dec 2018 11:26 +: * subversion/include/svn_dirent_uri.h (svn_relpath__internal_style): Change prototype

Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri

2018-12-17 Thread Daniel Shahaf
Branko Čibej wrote on Mon, 17 Dec 2018 13:19 +0100: > On 17.12.2018 13:11, Daniel Shahaf wrote: > > br...@apache.org wrote on Mon, 17 Dec 2018 11:26 +: > >> * subversion/include/svn_dirent_uri.h > >> (svn_relpath__internal_style): Change prototype so that the function can > >>return an

Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri

2018-12-17 Thread Branko Čibej
On 17.12.2018 13:11, Daniel Shahaf wrote: > br...@apache.org wrote on Mon, 17 Dec 2018 11:26 +: >> * subversion/include/svn_dirent_uri.h >> (svn_relpath__internal_style): Change prototype so that the function can >>return an error instead of aborting if anything goes wrong. > Shall we

Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri

2018-12-17 Thread Daniel Shahaf
br...@apache.org wrote on Mon, 17 Dec 2018 11:26 +: > * subversion/include/svn_dirent_uri.h > (svn_relpath__internal_style): Change prototype so that the function can >return an error instead of aborting if anything goes wrong. Shall we move the declaration to

[PATCH] fix use-after-free in mod_dav_svn's log_warning()

2018-12-17 Thread Stefan Sperling
I have hit a use-after-free in mod_dav_svn while running SVN's regression tests on OpenBSD with httpd 2.4. This problem was apparently known to the author; see the comment which is removed in the diff below. In short, the request structure used as logging context can already be freed before

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-17 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Mon, Dec 17, 2018 at 05:50:03 +0900: > On 12/17/18 2:08 AM, Troy Curtis Jr wrote: > > On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf > > wrote: > > > > > Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: > > > > But there was one item I wanted to talk about