Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, Dec 10, 2019 at 01:22:41 -0500: > On Mon, Dec 9, 2019 at 10:22 PM Daniel Shahaf wrote: > > There were multiple security issues fixed in later 1.9 patch releases; see > > https://subversion.apache.org/security/ > > Yes. I see quite a few affecting various 1.9.x. I

Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Nathan Hartman
On Mon, Dec 9, 2019 at 10:22 PM Daniel Shahaf wrote: > > Change «"Filesystem is corrupt"» in the section title to match the actual > error > message? Good catch! Fixed. A more careful reading of SVN-4722 and the 1.9.x CHANGES file made me realize that this issue affected 1.9.6 and 1.9.7

[PATCH] Build SWIG Python bindings for py2 and py3 separately

2019-12-09 Thread Yasuhito FUTATSUKI
Hi, I made a patch to separate build SWIG bindings for Python 2 and Python 3 on Unix/Linux. With this patch: * configure (and make) variable PYTHON in Makefile is used only for preparation of build system and running testsuite. * New configure VARIABLE PYTHON2, PYTHON3 are added for building

Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Dec 09, 2019 at 10:42:39 -0500: > + > +Commit can fail with an undeserved "Filesystem is corrupt" error > + +title="Link to this section"> > + > + > +See issue 4722, "checksum fail during commit when delta is 16K". > + > + > +When using a Subversion 1.9.7 server,

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Dec 09, 2019 at 09:04:20 -0500: > On Sun, Dec 1, 2019 at 7:08 PM Daniel Shahaf wrote: > > > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > > Daniel Shahaf wrote: > > > > I'd like to get the "is this WC mixed revision?" and "is this WC > > switched?"

[Patch] Rework of r1866425 ('Last-Modified' header)

2019-12-09 Thread Sergey Raevskiy
Hello! I've spent some time examining r1866425 [1] ('Last-Modified' header) and I would like to suggest a patch with some rework related to this code. I see two main problems in r1866425: usage of the pointer comparison (which is hackish and relies on the implementation of parse_uri()) and using

Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Nathan Hartman
On Sun, Dec 8, 2019 at 10:38 PM Daniel Shahaf wrote: > > Nathan Hartman wrote on Sun, 08 Dec 2019 06:04 +00:00: > > Commit can fail with an undeserved "Filesystem is corrupt" error > > > > See issue 4722, "checksum fail during commit when delta is 16K". > > > > Under a very specific set of

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Nathan Hartman
On Sun, Dec 1, 2019 at 7:08 PM Daniel Shahaf wrote: > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > Daniel Shahaf wrote: > > > I'd like to get the "is this WC mixed revision?" and "is this WC > switched?" bits without stat()-ing every single file in the worktree. > > > > What

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Julian Foad wrote on Mon, Dec 09, 2019 at 11:14:02 +: > It seems to me what you really need is a way to request some specific bits > of info about the "base shape" of the WC. The motivation for requesting > something more specific than the current output of 'svnversion' is clearly > the slow

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Julian Foad
Daniel Shahaf wrote: [... It currently shows] the BASE revision of ./ — and I'd like to have an indication that the wc is mixed-revision. [...] fast. I assume that solutions that read wc.db but don't look at the on-disk files at all would be sufficiently performant. Thus, `svnversion` sans

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Johan Corveleyn wrote on Mon, 09 Dec 2019 09:31 +00:00: > On Mon, Dec 9, 2019 at 9:01 AM Daniel Shahaf wrote: > > > > Any further comments on either of the topics below? In particular, the > > patch acceptable? > > > > Daniel Shahaf wrote on Mon, 02 Dec 2019 00:08 +00:00: > > > Julian Foad wrote

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Johan Corveleyn
On Mon, Dec 9, 2019 at 9:01 AM Daniel Shahaf wrote: > > Any further comments on either of the topics below? In particular, the > patch acceptable? > > Daniel Shahaf wrote on Mon, 02 Dec 2019 00:08 +00:00: > > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > > Daniel Shahaf wrote: >

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Any further comments on either of the topics below? In particular, the patch acceptable? Daniel Shahaf wrote on Mon, 02 Dec 2019 00:08 +00:00: > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > Daniel Shahaf wrote: > > > I'd like to get the "is this WC mixed revision?" and "is this