Hello, On 2023/07/19 6:16, Daniel Sahlberg wrote:
Den tis 18 juli 2023 kl 21:23 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>:
I'm not fluent in Python to the level of these changes (although as far as I've been able to test they are good). Could one of you commit?
I looked Jun's patch in <54c8b9a5-f9dd-5d6a-3033-f80eb9c80...@gmail.com> and it looks good as it uses b'...' with valid escape sequence for bytes. I also checked by using flake8 that after aplying the patch, there is no invalid sequence warning in the scripts in subversion/ and build/ directories. [[[ $ find . \( -name .svn -or -name __pycache__ \) -prune -or -name '*.py' -print0 | xargs -0 flake8 --select W605 | sed -e 's/:[0-9][0-9]*: W605 .*/:/' | uniq ./tools/dist/security/parser.py:58: SyntaxWarning: 'tuple' object is not callable; perhaps you missed a comma? (CULPRIT_SERVER,) ./contrib/client-side/svn-merge-vendor.py:429: ./contrib/client-side/svn_apply_autoprops.py:66: ./contrib/client-side/svn_apply_autoprops.py:67: ./tools/dev/analyze-svnlogs.py:38: ./tools/dev/analyze-svnlogs.py:39: ./tools/dev/analyze-svnlogs.py:40: ./tools/dev/check-license.py:26: ./tools/dev/check-license.py:27: ./tools/dev/check-license.py:28: ./tools/dev/check-license.py:29: ./tools/dev/check-license.py:30: ./tools/dev/check-license.py:31: ./tools/dev/check-license.py:32: ./tools/dev/check-license.py:33: ./tools/dev/check-license.py:34: ./tools/dev/check-license.py:35: ./tools/dev/check-license.py:36: ./tools/dev/check-license.py:37: ./tools/dev/check-license.py:38: ./tools/dev/check-license.py:39: ./tools/dev/check-license.py:40: ./tools/dev/check-license.py:41: ./tools/dev/check-license.py:42: ./tools/dev/check-license.py:43: ./tools/dev/contribulyze.py:520: ./tools/dev/contribulyze.py:523: ./tools/dev/contribulyze.py:528: ./tools/dev/contribulyze.py:579: ./tools/dev/contribulyze.py:706: ./tools/dev/mklog.py:32: ./tools/dev/po-merge.py:25: ./tools/dev/trails.py:35: ./tools/dev/trails.py:36: ./tools/po/l10n-report.py:182: ./tools/server-side/svn-backup-dumps.py:455: ]]] I apologize if I didn't post an extra comment about it, it woluld be commited soon. Jun, could you please commit the patch? Thanks, -- Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>/<futat...@poem.co.jp>
