[PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread Uwe Stuehler
This patch adds to the input validation tests a new case to verify that svn upgrade rejects URL arguments (instead of crashing) and changes the svn_cl__upgrade() routine to make it so. The change in svn_cl__upgrade() is directly based on Stefan's change to svn_cl__add() in r965551. I've started

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread Uwe Stuehler
On Thu, Sep 16, 2010 at 3:26 PM, C. Michael Pilato cmpil...@collab.net wrote: On 09/16/2010 08:59 AM, Uwe Stuehler wrote: Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure * subversion/svn/upgrade-cmd.c (svn_cl__upgrade): Check that target arguments aren't URLs

Re: Public API documentation

2010-09-15 Thread Uwe Stuehler
On Mi, 2010-09-15 at 10:35 +0100, Julian Foad wrote: Hyrum K. Wright wrote: I've been thinking about ways that our API documentation could be made a bit cleaner. ... Thoughts? -Hyrum +1. You know what, I've been a bit skeptical of the list-of-params style of documentation, as

Re: [PATCH] svn status ^/ foo: The node '/path/to/wc/foo' was not found.

2010-06-13 Thread Uwe Stuehler
On 06/13/2010 06:25 PM, Uwe Stuehler wrote: While testing all kinds of silly argument combinations to find inconsistencies in argument handling I found this case where checkout Oops! s/checkout/status/ (I changed the example.)

Re: [PATCH] svn status ^/ foo: The node '/path/to/wc/foo' was not found.

2010-06-13 Thread Uwe Stuehler
On 06/13/10 06:25 PM, Uwe Stuehler wrote: Index: subversion/libsvn_client/cmdline.c === --- subversion/libsvn_client/cmdline.c (revision 953325) +++ subversion/libsvn_client/cmdline.c (working copy) @@ -123,6 +123,7

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

2010-06-11 Thread Uwe Stuehler
, however, whether c) path canonicalization, can be entirely dismissed. I don't know the library interface contracts well enough yet. Cheers (sorry for the delay), Uwe Stuehler Index: subversion/svn/checkout-cmd.c === --- subversion

[PATCH] issue #3620: svn add ^/ triggers assertion failure

2010-04-22 Thread Uwe Stuehler
[[[ Fix issue #3620: svn add ^/ triggers assertion failure * subversion/svn/add-cmd.c: (svn_cl__add): Raise an error if a target argument isn't a working copy path before calling svn_client_add4(), which would trigger an assertion. Found by: stsp Patch by: Uwe Stuehler (subversion-li