Re: [PATCH] Fix pool usage in FSFS locking code

2015-02-12 Thread Sergey Raevskiy
> I think info->path is already in the correct pool, it's the result of > processing the the input path through svn_fspath__canonicalize using > result_pool. Yes, INFO->PATH is alocated in correct pool already. I've attached a new version of my patch (log message remains the same). Index: subvers

Re: [PATCH] Fix pool usage in FSFS locking code

2015-02-12 Thread Philip Martin
Sergey Raevskiy writes: > Index: subversion/libsvn_fs_fs/lock.c > === > --- subversion/libsvn_fs_fs/lock.c(revision 1659239) > +++ subversion/libsvn_fs_fs/lock.c(working copy) > @@ -900,14 +900,15 @@ lock_body(void *baton, ap

[PATCH] Fix pool usage in FSFS locking code

2015-02-12 Thread Sergey Raevskiy
Hi! I've noticed an improper pool usage in FSFS code. The svn_lock_t * object is created in RESULT_POOL, but its fiels are not gettting pstrdup'ed. The patch with fix is attached. Log message: [[[ * subversion/libsvn_fs_fs/lock.c (lock_body): Fix pool usage. Call apr_pstrdup() when initializi