Re: [PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

Evgeny Kotkov writes: >> + SVN_ERR(create_greek_fs(&fs, &newrev, "obtain-write-lock-failure-test", >> + opts, pool)); >> + SVN_ERR(svn_fs_create_access(&access, "bubba", pool)); >> + SVN_ERR(svn_fs_set_access(fs, access)); > > Should probably be named "test-obtain-writ

Re: [PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

Sergey Raevskiy writes: > I've attached the patch with crashing test and simple fix for this issue. > > Log message: > [[[ > Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock(). > > * subversion/subversion/tests/libsvn_fs/locks-test.c > (obtain_write_lock_failure_test): New; test for

Re: [PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

Sergey Raevskiy writes: > This happens beacuse lb.infos field is getting initialized only in function > lock_body() (see the code below). So, if svn_fs_fs__with_write_lock() fails > without actual invoking the lock_body(), lb.infos will be left uninitialized. [...] > I've attached the patch wi

[PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

Hi! Recenty I've discovered possible crash in FSFS locking code. If, for some reason, 'write-lock' cannot be obtained for lock/unlock operation, the FSFS will SEGFAULT. This happens beacuse lb.infos field is getting initialized only in function lock_body() (see the code below). So, if svn_fs_fs