Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-13 Thread Julian Foad
Daniel Shahaf wrote: >[...] committed the patch --- r1835760 --- and proposed it for > backport to to 1.10.x [...] This fix will be in 1.10.1, along with some other gnome keyring fixes. - Julian

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Daniel Shahaf
Jan Palus wrote on Thu, 12 Jul 2018 20:23 +0200: > On 12.07.2018 15:08, Daniel Shahaf wrote: > > Thanks for the patch; however, I don't think that's the correct fix. > > To be honest I wasn't sure of that either but on the other hand I thought that > having initialized state won't hurt. >

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Philip Martin
Jan Palus writes: > On 12.07.2018 15:08, Daniel Shahaf wrote: >> Thanks for the patch; however, I don't think that's the correct fix. > > To be honest I wasn't sure of that either but on the other hand I thought that > having initialized state won't hurt. > >> Does the following patch fix the

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Jan Palus
On 12.07.2018 15:08, Daniel Shahaf wrote: > Thanks for the patch; however, I don't think that's the correct fix. To be honest I wasn't sure of that either but on the other hand I thought that having initialized state won't hurt. > Does the following patch fix the problem? Speaking of which,

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Daniel Shahaf
Jan Palus wrote on Wed, Jul 11, 2018 at 13:46:35 +0200: > [[[ > Fix segfault when subversion is built with gnome keyring support and keyring > password lookup fails. > > * subversion/libsvn_subr/simple_providers.c > (svn_auth__simple_creds_cache_get): Initialize 'done' with FALSE since ie >

[PATCH] Fix segfault when gnome keyring lookup fails

2018-07-11 Thread Jan Palus
[[[ Fix segfault when subversion is built with gnome keyring support and keyring password lookup fails. * subversion/libsvn_subr/simple_providers.c (svn_auth__simple_creds_cache_get): Initialize 'done' with FALSE since ie password_get_gnome_keyring sets 'done' only to TRUE. In case of error