Re: [PATCH] Fix xgettext warnings and incomplete format strings due to macros

2014-06-02 Thread Stefan Fuhrmann
On Mon, Jun 2, 2014 at 2:40 AM, Daniel Shahaf wrote: > Andreas Stieger wrote on Sun, Jun 01, 2014 at 21:22:15 +0100: > > On 01/06/14 02:53, Daniel Shahaf wrote: > > > Don't we prefer doing: > > > > > > svn_error_createf(SVN_ERR_BASE, NULL, _("%s: number %ld"), > > > apr_

Re: [PATCH] Fix xgettext warnings and incomplete format strings due to macros

2014-06-01 Thread Daniel Shahaf
Andreas Stieger wrote on Sun, Jun 01, 2014 at 21:22:15 +0100: > On 01/06/14 02:53, Daniel Shahaf wrote: > > Don't we prefer doing: > > > > svn_error_createf(SVN_ERR_BASE, NULL, _("%s: number %ld"), > > apr_psprintf(pool, "%" APR_UINT64_T_FMT, > > (apr_uint64_t)1), > >

Re: [PATCH] Fix xgettext warnings and incomplete format strings due to macros

2014-06-01 Thread Andreas Stieger
Hi, thank you for the review. On 01/06/14 02:53, Daniel Shahaf wrote: > Don't we prefer doing: > > svn_error_createf(SVN_ERR_BASE, NULL, _("%s: number %ld"), > apr_psprintf(pool, "%" APR_UINT64_T_FMT, > (apr_uint64_t)1), > 1L) > > since it allows

Re: [PATCH] Fix xgettext warnings and incomplete format strings due to macros

2014-05-31 Thread Daniel Shahaf
> Index: subversion/libsvn_fs_fs/cached_data.c > === > --- subversion/libsvn_fs_fs/cached_data.c (revision 1598897) > +++ subversion/libsvn_fs_fs/cached_data.c (working copy) > @@ -941,9 +941,10 @@ svn_fs_fs__check_rep(represen

[PATCH] Fix xgettext warnings and incomplete format strings due to macros

2014-05-31 Thread Andreas Stieger
Hi, Scanning the translations template file fails due to APR_UINT64_T_FMT being used as is in format strings. This is from r1575628 (fsfs l2p index), also from log-addressing branch, and r1595579 (sync of same to FSX). While this works at execution time (modulo actually translating), xgettext cann