Re: [PATCH] Fwd: JNI segfault while running Java tests

2020-08-16 Thread Nathan Hartman
On Sun, Aug 16, 2020 at 9:11 AM Daniel Shahaf wrote: > > Nathan Hartman wrote on Sun, 16 Aug 2020 00:47 -0400: > > On Fri, Aug 14, 2020 at 9:08 AM Daniel Sahlberg > > wrote: > > > Just a kind ping on this patch. I realise I mark the subject of the > > > original message so maybe it went under

Re: [PATCH] Fwd: JNI segfault while running Java tests

2020-08-16 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 16 Aug 2020 00:47 -0400: > On Fri, Aug 14, 2020 at 9:08 AM Daniel Sahlberg > wrote: > > Just a kind ping on this patch. I realise I mark the subject of the > > original message so maybe it went under the radar. > > Committed in r1880886. > Backport nomination?

Re: [PATCH] Fwd: JNI segfault while running Java tests

2020-08-15 Thread Nathan Hartman
On Fri, Aug 14, 2020 at 9:08 AM Daniel Sahlberg wrote: > Just a kind ping on this patch. I realise I mark the subject of the original > message so maybe it went under the radar. Committed in r1880886. Thanks for your patch and good catch on this subtle error! The patch looks good to me.

[PATCH] Fwd: JNI segfault while running Java tests

2020-08-14 Thread Daniel Sahlberg
Just a kind ping on this patch. I realise I mark the subject of the original message so maybe it went under the radar. I also forgot the log message: [[[ * subversion/bindings/javahl/native/jniwrapper/jni_string_map.hpp (Java::BaseImmutableMap::Entry::key): Create the String::Contents object