Re: [PATCH] New dumpstream parser to check version number

On Wed, Aug 18, 2010 at 8:59 PM, Ramkumar Ramachandra artag...@gmail.com wrote: [[[ * subversion/libsvn_repos/load.c  (svn_repos_parse_dumpstream2, svn_repos_parse_dumpstream3): Rename  the older function and add a version_number argument; error out if  there's a version mismatch. *

Re: [PATCH] New dumpstream parser to check version number

Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 01:29:02 +0530: +++ subversion/include/svn_repos.h(working copy) @@ -2661,9 +2665,25 @@ typedef svn_repos_parse_fns2_t svn_repos_parser_fn * This is enough knowledge to make it easy on vtable implementors, * but still allow expansion

Re: [PATCH] New dumpstream parser to check version number

Hi Hyrum, Hyrum K. Wright writes: + * If @a version_number is -1, it is ignored and the dumpstream is + * parsed without this information. If not -1, the function checks the We try to avoid magic numbers. Is there a #define or constant somewhere that you could use? If not, I'd add a

Re: [PATCH] New dumpstream parser to check version number

Hi Daniel, Daniel Shahaf writes: - * @since New in 1.1. + * @since New in 2.0. s/2.0/1.7/ Fixed. +/** + * Similar to svn_repos_parse_dumpstream3(), but is dumpfile version + * agnostic. + * Perhaps say: with @a version_number always set to -1 ? Fixed, along with Hyrum's