Stefan Fuhrmann wrote on Sat, Dec 01, 2018 at 11:08:02 +0100:
> Yes, that does make sense. Thank you for fixing this.
>
> My mental image was: Stop at the last parent level (re-usable
> between siblings) and attempt a leaf lookup, which would then
> handle the error cases. This is obviously
ยน The test was posted upthread by Julian (based on Dmitry's work).
- Forwarded message from Daniel Shahaf -
Date: Wed, 21 Nov 2018 14:55:23 +
From: Daniel Shahaf
To: dev@subversion.apache.org
Subject: [PATCH] Re: [PATCH] A test for "Can't get entries" error
Message-ID: <2
Julian Foad wrote on Fri, 23 Nov 2018 13:56 +:
> Daniel Shahaf wrote:
> > Julian Foad wrote on Wed, 21 Nov 2018 16:00 +:
> > > In reviewing the code I was unable to keep track of all the nuances of
> > > what happens (and should happen) in all the edge cases. Especially when
> > > 'flags
Daniel Shahaf wrote:
> Julian Foad wrote on Wed, 21 Nov 2018 16:00 +:
> > In reviewing the code I was unable to keep track of all the nuances of
> > what happens (and should happen) in all the edge cases. Especially when
> > 'flags & open_path_allow_null' is true and the requested path is a
Daniel Shahaf wrote on Thu, 22 Nov 2018 00:51 +:
> While we're at this function, does anyone understand why directory[1] is
> accessed without checking whether directory[0] is not NUL? There is
> a comment there, but it doesn't enlighten me. (However, I haven't run
> 'blame' on that comment
Julian Foad wrote on Wed, 21 Nov 2018 16:00 +:
> The top-of-loop comment says:
> "/* Whenever we are at the top of this loop:
> - HERE is our current directory, ..."
>
> As HERE is apparently NOT a directory in this case, I wonder if the
> comment simply should say something like
FWIW: I also looked around in FSX to see if there was any comparable code, in
case there was some correct version of this pattern or some other clue.
The comparable area of code is svn_fs_x__get_dag_path().
In its loop, it seems the 'here' variable is always supposed to point to a
directory;
Daniel Shahaf wrote:
> Daniel Shahaf wrote on Tue, Nov 20, 2018 at 09:28:19 +:
> > The test XPASSes with SVN_X_DOES_NOT_MARK_THE_SPOT=1 (see notes/knobs),
> > so it's something to do with the caches.
>
> So, looking at subversion/libsvn_fs_fs/tree.c:
[...]
> In words: svn_fs_fs__dag_open() is
Daniel Shahaf wrote on Tue, Nov 20, 2018 at 09:28:19 +:
> Julian Foad wrote on Tue, 20 Nov 2018 08:38 +:
> > Daniel Shahaf wrote:
> > > Could you please clarify whether the bug reproduces under other backends
> > > (FSX and BDB)?
> >
> > I found that the test passes under FSX and BDB; it
9 matches
Mail list logo
