Re: [PATCH] Re: verify_as_revision_before_current_plus_plus() on a production repo?

2017-05-16 Thread Stefan Fuhrmann
On 16.03.2017 12:50, Julian Foad wrote: Daniel Shahaf wrote: should our policy be to provide administrative choice? A knob sounds good to me [...] And Bert said "+1" on IRC too. The attached patch is a basic implementation. The fsfs.conf option is spelled [debug] verify-before-commit

Re: [PATCH] Re: verify_as_revision_before_current_plus_plus() on a production repo?

2017-03-16 Thread Daniel Shahaf
Julian Foad wrote on Thu, Mar 16, 2017 at 11:50:34 +: > What sort of testing do you think this needs? A first level could be to test > that the verification code runs when the option is explicitly enabled and > doesn't when disabled, and preferably test the default state too. A second > level c

[PATCH] Re: verify_as_revision_before_current_plus_plus() on a production repo?

2017-03-16 Thread Julian Foad
Daniel Shahaf wrote: should our policy be to provide administrative choice? A knob sounds good to me [...] And Bert said "+1" on IRC too. The attached patch is a basic implementation. The fsfs.conf option is spelled [debug] verify-before-commit = true I put it under [debug] because t