Re: AW: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Philip Martin
"Schmidt, Michael" writes: > As for checking the log output, I could collect all the external > start/end messages in a set and compare this against the ground truth > set, without checking the order of them. What do you think? That might work. Another option might be a directory structure that

AW: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Schmidt, Michael
: Re: [PATCH] issue #4527: notify start of exporting external Julian Foad writes: > Other than the indentation, Michael's patch looks like the right fix > in the right place, wouldn't you agree? Yes, I think it is correct. Extending the patch to fix the in_external nesting

Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Philip Martin
Julian Foad writes: > Other than the indentation, Michael's patch looks like the right fix > in the right place, wouldn't you agree? Yes, I think it is correct. Extending the patch to fix the in_external nesting problem would be ideal but we could commit this version. > Michael, have you teste

Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Julian Foad
Philip Martin wrote: > Schmidt, Michael writes: >> This patch only fixes the missing notification of starting to export >> externals. It does not address the second part of issue #4527, which >> is the premature reset of the in_external flag in the case of nested >> externals, which also affects ch

Re: [PATCH] issue #4527: notify start of exporting external

2014-11-13 Thread Philip Martin
"Schmidt, Michael" writes: > This patch only fixes the missing notification of starting to export > externals. It does not address the second part of issue #4527, which > is the premature reset of the in_external flag in the case of nested > externals, which also affects checkouts. To me it seems

[PATCH] issue #4527: notify start of exporting external

2014-11-12 Thread Schmidt, Michael
Please find attached a patch which provides the missing notification at the start of exporting externals. Since I've never before worked on subversion code, please review it especially carefully :) I apologize for possible blunt errors in advance. This patch only fixes the missing notification