Re: [PATCH] run_and_verify_svnrdump

2010-07-26 Thread Ramkumar Ramachandra
Hi, Ramkumar Ramachandra writes: Hi Daniel, Thanks for the review. Here's another revision. Could someone review this patch? My subcommand patch to svnrdump breaks all the tests and I need to fix them. Thanks! -- Ram

[PATCH] run_and_verify_svnrdump

2010-07-24 Thread Ramkumar Ramachandra
Hi, Thanks to Daniel for suggesting this. -- Ram [[[ * subversion/tests/cmdline/svntest/actions.py (run_and_verify_svnrdump): Add new function to run svnrdump with '-q', verify that stderr is empty, and return the output on stdout. * subversion/tests/cmdline/svnrdump_tests.py (run_test,

Re: [PATCH] run_and_verify_svnrdump

2010-07-24 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 22:28:12 +0530: Hi, Thanks to Daniel for suggesting this. -- Ram [[[ * subversion/tests/cmdline/svntest/actions.py (run_and_verify_svnrdump): Add new function to run svnrdump with '-q', verify that stderr is empty, and return the

Re: [PATCH] run_and_verify_svnrdump

2010-07-24 Thread Ramkumar Ramachandra
Hi Daniel, Thanks for the review. Here's another revision. [[[ * subversion/tests/cmdline/svntest/actions.py (run_and_verify_svnrdump): Add new function to run svnrdump with '-q', verify that stderr is empty, exit_code is zero, and return the output on stdout. *