Re: [PATCH v2] New dumpstream parser to check version number

(read the last review hunk first) Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:17:55 +0530: [[[ * subversion/libsvn_repos/load.c (svn_repos_parse_dumpstream2, svn_repos_parse_dumpstream3): Rename the older function and add a version_number argument; error out if there's a

Re: [PATCH v2] New dumpstream parser to check version number

Hi Daniel, Daniel Shahaf writes: - SVN_ERR(svn_repos_parse_dumpstream2(stream, parser, parse_baton, - NULL, NULL, pool)); + SVN_ERR(svn_repos_parse_dumpstream3(stream, parser, parse_baton, + NULL, NULL, +

Re: [PATCH v2] New dumpstream parser to check version number

Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 21:28:37 +0530: Hi Daniel, Daniel Shahaf writes: - SVN_ERR(svn_repos_parse_dumpstream2(stream, parser, parse_baton, - NULL, NULL, pool)); + SVN_ERR(svn_repos_parse_dumpstream3(stream, parser,

Re: [PATCH v2] New dumpstream parser to check version number

Hi Daniel, Daniel Shahaf writes: That patch is still an RFC, and it's unlikely to be approved soon I think. If I were able to send a series, it would roughly look like this: 1. Create parse_dumpstream3 to include the logic for checking equality in version. 2. Note the lack of

[PATCH v2] New dumpstream parser to check version number

[[[ * subversion/libsvn_repos/load.c (svn_repos_parse_dumpstream2, svn_repos_parse_dumpstream3): Rename the older function and add a version_number argument; error out if there's a version mismatch. * subversion/include/svn_repos.h (svn_repos_parse_dumpstream2,