Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Johan Corveleyn
On Fri, Oct 8, 2010 at 10:35 PM, Hyrum K. Wright wrote: > On Fri, Oct 8, 2010 at 3:24 PM, Johan Corveleyn wrote: >> ... >> >> Just one more thing: as I mentioned in my rather long mail, blame >> would benefit the most from my optimization if the server were fast >> enough. So if anyone could spar

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Hyrum K. Wright
On Fri, Oct 8, 2010 at 3:24 PM, Johan Corveleyn wrote: > ... > > Just one more thing: as I mentioned in my rather long mail, blame > would benefit the most from my optimization if the server were fast > enough. So if anyone could spare some review cycles (ok, I know they > are scarce these days),

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Johan Corveleyn
On Fri, Oct 8, 2010 at 3:08 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Fri, 8 Oct 2010 at 01:44 -: >> With suffix-lines-to-keep=50, you'd need to insert a >> block of text that has its last 50 lines identical to the 50 lines >> preceding the insertion point, to mess up the diff result

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Hyrum K. Wright
On Thu, Oct 7, 2010 at 6:44 PM, Johan Corveleyn wrote: > Hi all, > > This is a follow-up to the WIP-patches I posted last week [1], which > are about improving performance of svn_diff (and therefor also blame > on the client-side), especially for large files. > > To summarize: the idea was (is) to

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Daniel Shahaf
Johan Corveleyn wrote on Fri, 8 Oct 2010 at 01:44 -: > With suffix-lines-to-keep=50, you'd need to insert a > block of text that has its last 50 lines identical to the 50 lines > preceding the insertion point, to mess up the diff result. > > - If really necessary, we could say default=50, but

[RFC] Diff (blame) optimization: how to go forward

2010-10-07 Thread Johan Corveleyn
Hi all, This is a follow-up to the WIP-patches I posted last week [1], which are about improving performance of svn_diff (and therefor also blame on the client-side), especially for large files. To summarize: the idea was (is) to strip off the identical prefix and suffix, and then letting the exi