RE: Any idea why public function like svn_fspath__dirname have double __ in its name?

On Thu, 2010-12-30, Kamesh Jayachandran wrote: While we've mandated that __ must be used for semi-public functions, we've never said that it can't be used for private ones. Kamesh is talking about public, not private, functions. I.e., ones where we actually do have an ABI promise to keep.

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

With regards Kamesh Jayachandran [PS] Unless I am mistaken svn_fspath__* can be used in libsvn_repos too instead of svn_path_* wherever applicable and hence a chance to become public. I don't quite understand what you mean here. I meant subversion/libsvn_repos/commit.c:delete_entry() uses

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 01/05/2011 11:05 AM, Kamesh Jayachandran wrote: With regards Kamesh Jayachandran [PS] Unless I am mistaken svn_fspath__* can be used in libsvn_repos too instead of svn_path_* wherever applicable and hence a chance to become public. I don't quite understand what you mean here. I

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 28.12.2010 23:13, Peter Samuelson wrote: [C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor svn_fspath__get_longest_ancestor svn_error__locate

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 29.12.2010 09:43, Branko Čibej wrote: On 28.12.2010 23:13, Peter Samuelson wrote: [C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor

RE: Any idea why public function like svn_fspath__dirname have double __ in its name?

Now I'm really mystified. When I added those location-tracing functions and macros, they were only ever enabled with SVN_DEBUG turned on (i.e., in maintainer-mode). Now I see that those #ifdef wrappers are gone, and can't recall an explanation as to why that's a good thing. Can anyone

RE: Any idea why public function like svn_fspath__dirname have double __ in its name?

While we've mandated that __ must be used for semi-public functions, we've never said that it can't be used for private ones. Kamesh is talking about public, not private, functions. I.e., ones where we actually do have an ABI promise to keep. I looked at svn_error__locate last week. It's

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

[Branko Cibej] Found it, r843793 and I agree with the change. So, effectively, svn_error__locate has been public since then, and r1053469 should be reverted anyway because it breaks the ABI. It doesn't break the ABI. I kept the function itself. Whether it is useful to populate -file and

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 29.12.2010 20:10, Kamesh Jayachandran wrote: Now I'm really mystified. When I added those location-tracing functions and macros, they were only ever enabled with SVN_DEBUG turned on (i.e., in maintainer-mode). Now I see that those #ifdef wrappers are gone, and can't recall an

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 29.12.2010 20:50, Peter Samuelson wrote: [Branko Cibej] Found it, r843793 and I agree with the change. So, effectively, svn_error__locate has been public since then, and r1053469 should be reverted anyway because it breaks the ABI. It doesn't break the ABI. I kept the function itself.

Any idea why public function like svn_fspath__dirname have double __ in its name?

Hi All, I could see the following functions in our public header with '__' in their names, svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

On 12/28/2010 04:30 AM, Kamesh Jayachandran wrote: Hi All, I could see the following functions in our public header with '__' in their names, svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child

Re: Any idea why public function like svn_fspath__dirname have double __ in its name?

[C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor svn_fspath__is_ancestor svn_fspath__get_longest_ancestor svn_error__locate svn_error__malfunction