Re: Avoiding svn_iter_apr_hash/array() [was: svn commit: r935579]

2010-04-20 Thread Greg Stein
Hehe... reminds me of my short fight against SVN_ERR hiding a return statement, way back when... On Apr 20, 2010 11:46 AM, "Hyrum K. Wright" wrote: On Tue, Apr 20, 2010 at 10:34 AM, Julian Foad wrote: > > Daniel Shahaf wr... While an interesting exercise in extending the C language, I've got

Re: Avoiding svn_iter_apr_hash/array() [was: svn commit: r935579]

2010-04-20 Thread Hyrum K. Wright
On Tue, Apr 20, 2010 at 10:34 AM, Julian Foad wrote: > Daniel Shahaf wrote: > > Julian Foad wrote on Tue, 20 Apr 2010 at 11:49 +0100: > > > Hmm... I wonder if we could do something with a macro that takes the > > > whole block of code to be executed as an argument, like: > > > > A code block insid

Re: Avoiding svn_iter_apr_hash/array() [was: svn commit: r935579]

2010-04-20 Thread Julian Foad
Daniel Shahaf wrote: > Julian Foad wrote on Tue, 20 Apr 2010 at 11:49 +0100: > > Hmm... I wonder if we could do something with a macro that takes the > > whole block of code to be executed as an argument, like: > > A code block inside a macro call?? Well, I tried it and it works and I kind of li

Re: Avoiding svn_iter_apr_hash/array() [was: svn commit: r935579]

2010-04-20 Thread Daniel Shahaf
Julian Foad wrote on Tue, 20 Apr 2010 at 11:49 +0100: > Hmm... I wonder if we could do something with a macro that takes the > whole block of code to be executed as an argument, like: > A code block inside a macro call?? Perhaps we write a macro in the style of SVN_DBG --- one that is "pseudo-va

Avoiding svn_iter_apr_hash/array() [was: svn commit: r935579]

2010-04-20 Thread Julian Foad
On Mon, 2010-04-19, Greg Stein wrote: > On Mon, Apr 19, 2010 at 10:03, wrote: > > * subversion/libsvn_client/commit.c > > (post_process_commit_item): Eliminate a misleadingly named local variable. > > The best way to clarify what is happening is to remove the use of > svn_iter_apr_array(). > >