Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-11-16 Thread C. Michael Pilato
On 11/15/2010 03:05 PM, Alexey Neyman wrote: Hi all, On Wednesday, August 11, 2010 01:09:50 pm C. Michael Pilato wrote: On 08/11/2010 03:10 PM, C. Michael Pilato wrote: On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned in bindings from

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-11-15 Thread Alexey Neyman
Hi all, On Wednesday, August 11, 2010 01:09:50 pm C. Michael Pilato wrote: On 08/11/2010 03:10 PM, C. Michael Pilato wrote: On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned in bindings from svn_fs_paths_changed2(). *

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-18 Thread Gavin Beau Baumanis
Ping. The renewed patch submission has received no comments. Gavin. On 12/08/2010, at 6:12 AM, Alexey Neyman wrote: On Wednesday, August 11, 2010 12:10:41 pm C. Michael Pilato wrote: On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-18 Thread Alexey Neyman
There was a race condition :) C. Michael Pilato committed the same patch at the same time as I sent updated version, with less than 3 minutes difference. Regards, Alexey. On Wednesday, August 18, 2010 03:54:43 pm Gavin Beau Baumanis wrote: Ping. The renewed patch submission has received no

Re: Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread Alexey Neyman
Small update to the patch: change doxygen comment to match new argument name. Regards, Alexey. On Tuesday, August 10, 2010 02:53:50 pm Alexey Neyman wrote: Hi all, Looks like the binding for svn_fs_paths_changed2() incorrectly specifies the type of structures contained in the hash it

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread C. Michael Pilato
On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned in bindings from svn_fs_paths_changed2(). * subversion/include/svn_fs.h (svn_fs_paths_changed2): Rename the argument from changed_paths_p to changed_paths_p2, so that it's different

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread C. Michael Pilato
On 08/11/2010 03:10 PM, C. Michael Pilato wrote: On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned in bindings from svn_fs_paths_changed2(). * subversion/include/svn_fs.h (svn_fs_paths_changed2): Rename the argument from changed_paths_p

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread Alexey Neyman
On Wednesday, August 11, 2010 12:10:41 pm C. Michael Pilato wrote: On 08/10/2010 09:22 PM, Alexey Neyman wrote: Okay, try again: [[[ Fix the type of structures returned in bindings from svn_fs_paths_changed2(). * subversion/include/svn_fs.h (svn_fs_paths_changed2): Rename

Bug in svn_fs_paths_changed2() Python bindings?

2010-08-10 Thread Alexey Neyman
Hi all, Looks like the binding for svn_fs_paths_changed2() incorrectly specifies the type of structures contained in the hash it returns: the following code s = fs.paths_changed2(rev_root, pool) for i in s: sys.stderr.write(%s = %s\n % (i, repr(s))) indicates that bindings assume the hash to

Re: Bug in svn_fs_paths_changed2() Python bindings?

2010-08-10 Thread Alexey Neyman
Small update to the patch: change doxygen comment to match new argument name. Regards, Alexey. On Tuesday, August 10, 2010 02:53:50 pm Alexey Neyman wrote: Hi all, Looks like the binding for svn_fs_paths_changed2() incorrectly specifies the type of structures contained in the hash it