Re: Issue tracker housecleaning: SVN-1722

2019-11-01 Thread Julian Foad
Branko Čibej wrote: Yasuhito FUTATSUKI wrote: However, it seems there is more general question, "What versions do we support on Python 3?" [...] To be honest, I wouldn't care about any Python 3 older than 3.5 [...] Let's move this to a new email thread. I'll open one. Subject: "What

Re: Issue tracker housecleaning: SVN-1722

2019-11-01 Thread Branko Čibej
On 01.11.2019 09:58, Yasuhito FUTATSUKI wrote: > On 2019/11/01 14:23, Nathan Hartman wrote: >> On Fri, Oct 18, 2019 at 9:22 AM Branko Čibej wrote: >> >>> Running the build scripts and tests with Python3 works now on trunk, >>> with the latest fixes. Except for this warning: >>> >>>

Re: Issue tracker housecleaning: SVN-1722

2019-11-01 Thread Yasuhito FUTATSUKI
On 2019/11/01 14:23, Nathan Hartman wrote: On Fri, Oct 18, 2019 at 9:22 AM Branko Čibej wrote: Running the build scripts and tests with Python3 works now on trunk, with the latest fixes. Except for this warning: .../run_tests.py:53: DeprecationWarning: the imp module is deprecated in favour

Re: Issue tracker housecleaning: SVN-1722

2019-10-31 Thread Nathan Hartman
On Fri, Oct 18, 2019 at 9:22 AM Branko Čibej wrote: > Running the build scripts and tests with Python3 works now on trunk, > with the latest fixes. Except for this warning: > > .../run_tests.py:53: DeprecationWarning: the imp module is deprecated in > favour of importlib; see the module's

Re: SWIG Python bindings build with SWIG 4.0 (was: Re: Issue tracker housecleaning: SVN-1722)

2019-10-19 Thread Branko Čibej
On 19.10.2019 23:06, Branko Čibej wrote: > On 19.10.2019 19:55, Branko Čibej wrote: >> On 19.10.2019 11:45, Yasuhito FUTATSUKI wrote: >>> On 2019/10/18 8:39, Branko Čibej wrote: On 17.10.2019 23:46, Branko Čibej wrote: > On 17.10.2019 23:01, Daniel Shahaf wrote: >> Branko Čibej wrote

Re: SWIG Python bindings build with SWIG 4.0 (was: Re: Issue tracker housecleaning: SVN-1722)

2019-10-19 Thread Branko Čibej
On 19.10.2019 19:55, Branko Čibej wrote: > On 19.10.2019 11:45, Yasuhito FUTATSUKI wrote: >> On 2019/10/18 8:39, Branko Čibej wrote: >>> On 17.10.2019 23:46, Branko Čibej wrote: On 17.10.2019 23:01, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: >>

Re: SWIG Python bindings build with SWIG 4.0 (was: Re: Issue tracker housecleaning: SVN-1722)

2019-10-19 Thread Branko Čibej
On 19.10.2019 11:45, Yasuhito FUTATSUKI wrote: > On 2019/10/18 8:39, Branko Čibej wrote: >> On 17.10.2019 23:46, Branko Čibej wrote: >>> On 17.10.2019 23:01, Daniel Shahaf wrote: Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: > On 17.10.2019 22:37, Daniel Shahaf wrote: >>

SWIG Python bindings build with SWIG 4.0 (was: Re: Issue tracker housecleaning: SVN-1722)

2019-10-19 Thread Yasuhito FUTATSUKI
On 2019/10/18 8:39, Branko Čibej wrote: On 17.10.2019 23:46, Branko Čibej wrote: On 17.10.2019 23:01, Daniel Shahaf wrote: Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: On 17.10.2019 22:37, Daniel Shahaf wrote: Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: On 16.10.2019

Re: Issue tracker housecleaning: SVN-1722

2019-10-18 Thread Branko Čibej
On 18.10.2019 01:39, Branko Čibej wrote: > On 17.10.2019 23:46, Branko Čibej wrote: >> On 17.10.2019 23:01, Daniel Shahaf wrote: >>> Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: On 17.10.2019 22:37, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00:

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Branko Čibej
On 17.10.2019 23:46, Branko Čibej wrote: > On 17.10.2019 23:01, Daniel Shahaf wrote: >> Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: >>> On 17.10.2019 22:37, Daniel Shahaf wrote: Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: > On 16.10.2019 10:01, Daniel Shahaf wrote:

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Branko Čibej
On 17.10.2019 23:01, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: >> On 17.10.2019 22:37, Daniel Shahaf wrote: >>> Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: On 16.10.2019 10:01, Daniel Shahaf wrote: > Which reminds me: it'd be nice to set up

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: > On 17.10.2019 22:37, Daniel Shahaf wrote: > > Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: > >> On 16.10.2019 10:01, Daniel Shahaf wrote: > >>> Which reminds me: it'd be nice to set up a buildbot to run the build and > >>> test

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Branko Čibej
On 17.10.2019 22:37, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: >> On 16.10.2019 10:01, Daniel Shahaf wrote: >>> Which reminds me: it'd be nice to set up a buildbot to run the build and >>> test process under Python 3. Any committer can edit the buildbot >>>

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: > On 16.10.2019 10:01, Daniel Shahaf wrote: > > Which reminds me: it'd be nice to set up a buildbot to run the build and > > test process under Python 3. Any committer can edit the buildbot > > scripts[1], but the question is which of the

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Nathan Hartman
On Thu, Oct 17, 2019 at 3:03 PM Nathan Hartman wrote: > On Thu, Oct 17, 2019 at 2:30 PM Julian Foad wrote: > > Close buttons are at top of page when logged in. > > Nope. I am logged in. I have a feeling my account isn't setup > correctly with permissions. I might have to bother infra... :-(

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Julian Foad
Close buttons are at top of page when logged in.

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Nathan Hartman
On Thu, Oct 17, 2019 at 11:44 AM Julian Foad wrote: > Looks good to me. Thanks! Regression test added in r1868561. Now, here's a dumb question... How do I close the issue?! There doesn't seem to be a button for it.

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Julian Foad
Nathan Hartman wrote: Test below. Please review... Looks good to me. - Julian

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Nathan Hartman
Test below. Please review... On Thu, Oct 17, 2019 at 8:18 AM Branko Čibej wrote: > >> Is it possible, through some incantation that I've overlooked, to run > >> the cmdline tests against an arbitrary svn binary? > make check SVN_BIN_DIR=/opt/foo/some/path > > See Makefile.in, line 617. Btw,

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Nathan Hartman
On Thu, Oct 17, 2019 at 8:18 AM Branko Čibej wrote: > On 17.10.2019 13:55, Julian Foad wrote: > >> Is it possible, through some incantation that I've overlooked, to run > >> the cmdline tests against an arbitrary svn binary? > > > > Unfortunately that's something we never got around to. I would

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Branko Čibej
On 17.10.2019 13:55, Julian Foad wrote: >> Is it possible, through some incantation that I've overlooked, to run >> the cmdline tests against an arbitrary svn binary? > > Unfortunately that's something we never got around to.  I would love > to make that possible. ??? make check

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Nathan Hartman
On Wed, Oct 16, 2019 at 4:46 AM Julian Foad wrote: > Of course, ideally, it is lovely to improve the test coverage, if you > have spare time and spare enthusiasm, or can do so really quickly so it > doesn't impact other activities. However, it's not required and not > necessarily worth it. A

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Branko Čibej
On 16.10.2019 10:01, Daniel Shahaf wrote: > Which reminds me: it'd be nice to set up a buildbot to run the build and > test process under Python 3. Any committer can edit the buildbot > scripts[1], but the question is which of the buildbot slaves has Python 3 > installed?

Re: Issue tracker housecleaning: SVN-1722

2019-10-16 Thread Julian Foad
Daniel Shahaf wrote: Nathan Hartman wrote on Wed, 16 Oct 2019 04:47 +00:00: Is it sensible to add a regression test? Yes, unless other tests already cover this. Of course, ideally, it is lovely to improve the test coverage, if you have spare time and spare enthusiasm, or can do so really

Re: Issue tracker housecleaning: SVN-1722

2019-10-16 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 16 Oct 2019 04:47 +00:00: > Is it sensible to add a regression test? Yes, unless other tests already cover this. Such tests would probably be either in diff_tests.py or in subversion/tests/libsvn_diff/. In general, Python tests may be tagged with «@Issue(1722)»

Re: Issue tracker housecleaning: SVN-1722

2019-10-15 Thread Nathan Hartman
On Tue, Oct 15, 2019 at 2:40 AM Julian Foad wrote: > Your analysis is good enough for me. I don't need to double check the details. > > I'd say, add a short summary and a link to that email, and close it. Will do... FWIW I tested the SVN-1722 reproduction script on 1.13.0-rc1 earlier today and

Re: Issue tracker housecleaning: SVN-1722

2019-10-15 Thread Julian Foad
Nathan, Your analysis is good enough for me. I don't need to double check the details. I'd say, add a short summary and a link to that email, and close it. - Julian

Issue tracker housecleaning: SVN-1722

2019-10-14 Thread Nathan Hartman
A short time ago, in a galaxy nearby... or, in the thread "Fwd: PMCs: any Hackathon requests? (deadline 11 October)"... Julian Foad wrote: >> Nathan Hartman wrote: >> https://issues.apache.org/jira/browse/SVN-1722 "svn >> diff may missreport a revision as the working copy." > > Errm... last