On 12/11/23 4:54 AM, Yasuhito FUTATSUKI wrote:
> On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote:
>> Hi,
>>
>> On 2023/12/09 0:04, Daniel Sahlberg wrote:
>>
>>> Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
>>> futat...@yf.bsdclub.org>:
>>
Index: tools/hook-scripts/mailer/mailer.py
Oh, shoot. And I was trying to be incremental/careful. Thank you for
catching that!
I also like how you fixed this. The .run() method did need to be removed
because of that singular usage. Using the new generate_diff() function is a
great solution! (whereas we used to have an object, which made
On 2023/12/11 12:54, Yasuhito FUTATSUKI wrote:
> On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote:
>> Thank you for the review. However, it turned out that even with this
>> patch, mailer.py did not work for post-revprop-change hook.
>> It caused exception like
>>
>> [[[
>> svn: E165001:
On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote:
> Hi,
>
> On 2023/12/09 0:04, Daniel Sahlberg wrote:
>
>> Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
>> futat...@yf.bsdclub.org>:
>
>
>
>>> Then, how about this patch? It at least mailer-t1.sh passed both
>>> on python=python2.7 and
Hi,
On 2023/12/09 0:04, Daniel Sahlberg wrote:
> Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
> futat...@yf.bsdclub.org>:
>> Then, how about this patch? It at least mailer-t1.sh passed both
>> on python=python2.7 and on python=python3.9.
>>
>> [[[
>> Fix inconsistency in path
Hi,
Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
>
>
> On 2023/12/07 19:33, Daniel Sahlberg wrote:
> > Den tors 7 dec. 2023 kl 09:51 skrev Ruediger Pluem :
> >
> >> I stumbled accross a Python 3 compatibility issue in
>
On 2023/12/07 19:33, Daniel Sahlberg wrote:
> Den tors 7 dec. 2023 kl 09:51 skrev Ruediger Pluem :
>
>> I stumbled accross a Python 3 compatibility issue in
>> tools/hook-scripts/mailer/mailer.py.
>>
>> The call of self.cfg.which_groups in line 565 passes an empt
Hello,
On 2023/12/07 17:51, Ruediger Pluem wrote:
I stumbled accross a Python 3 compatibility issue in
tools/hook-scripts/mailer/mailer.py.
The call of self.cfg.which_groups in line 565 passes an empty string as first
parameter.
In which_groups this empty string is passed to to_str in line
Den tors 7 dec. 2023 kl 09:51 skrev Ruediger Pluem :
> I stumbled accross a Python 3 compatibility issue in
> tools/hook-scripts/mailer/mailer.py.
>
> The call of self.cfg.which_groups in line 565 passes an empty string as
> first parameter.
> In which_groups this empty string i
I stumbled accross a Python 3 compatibility issue in
tools/hook-scripts/mailer/mailer.py.
The call of self.cfg.which_groups in line 565 passes an empty string as first
parameter.
In which_groups this empty string is passed to to_str in line 1489.
In line 88 to_str does x.decode('utf-8
10 matches
Mail list logo