Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-10-14 Thread Johan Corveleyn
On Fri, Oct 11, 2019 at 2:38 PM Yasuhito FUTATSUKI wrote: > > On 2019-09-30 06:32, Johan Corveleyn wrote: > ... > > At this point, I think the only thing blocking reintegration of this > > branch into trunk seems to be the C4115 warning / error. As I said, I > > have no informed opinion either

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-10-11 Thread Yasuhito FUTATSUKI
On 2019-09-30 06:32, Johan Corveleyn wrote: ... At this point, I think the only thing blocking reintegration of this branch into trunk seems to be the C4115 warning / error. As I said, I have no informed opinion either way (and Brane was okay with turning it into a warning). So if Bert doesn't

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-29 Thread Branko Čibej
On 29.09.2019 23:32, Johan Corveleyn wrote: > BTW, I have one more question: is it expected that "swig-python > bindings compiled with python 3" cannot be used by python 2? Because > if I run the testsuite with Python 2.7.16, after I have compiled them > with Python 3.7.4, I get the following

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-29 Thread Johan Corveleyn
On Sun, Sep 29, 2019 at 8:42 PM Yasuhito FUTATSUKI wrote: ... > Hmm.. It seems the diffrence comes from difference of implementation > of class subprocess.Popen. > > I tweaked again clean up code for class svn.fs.FileDiff. Only if > Python >= 3.3, it wait for maximum 10 sec to terminate

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-29 Thread Yasuhito FUTATSUKI
On 2019/09/29 23:36, Johan Corveleyn wrote: On Sun, Sep 29, 2019 at 2:00 PM Yasuhito FUTATSUKI wrote: On 2019/09/28 17:17, Yasuhito FUTATSUKI wrote: On 2019/09/28 5:51, Johan Corveleyn wrote: [[[ Testing Release configuration on local repository. -- Running Swig Python tests --

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-29 Thread Johan Corveleyn
On Sun, Sep 29, 2019 at 2:00 PM Yasuhito FUTATSUKI wrote: > > On 2019/09/28 17:17, Yasuhito FUTATSUKI wrote: > > On 2019/09/28 5:51, Johan Corveleyn wrote: > > >> [[[ > >> Testing Release configuration on local repository. > >> -- Running Swig Python tests -- > >>

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-29 Thread Yasuhito FUTATSUKI
On 2019/09/28 17:17, Yasuhito FUTATSUKI wrote: On 2019/09/28 5:51, Johan Corveleyn wrote: [[[ Testing Release configuration on local repository. -- Running Swig Python tests -- ..C:\Python37\lib\subprocess.py:858: ResourceWarning:

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Yasuhito FUTATSUKI
On 2019/09/28 22:36, Branko Čibej wrote: On 28.09.2019 11:20, Yasuhito FUTATSUKI wrote: On 2019/09/24 16:34, Branko Čibej wrote: On 23.09.2019 22:48, Johan Corveleyn wrote: On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI wrote: On 2019/09/23 6:16, Johan Corveleyn wrote: Building with

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 28 Sep 2019 09:20 +00:00: > https://svn.apache.org/viewvc?view=revision=876281 > > Unfortunately I can't find any reason or discussion about this decision, yet. Are you aware of the "+ 840074" revision number offset that needs to be applied to old revision

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Branko Čibej
On 28.09.2019 11:20, Yasuhito FUTATSUKI wrote: > On 2019/09/24 16:34, Branko Čibej wrote: >> On 23.09.2019 22:48, Johan Corveleyn wrote: >>> On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI >>> wrote: On 2019/09/23 6:16, Johan Corveleyn wrote: > > Building with Python 3.7.4 still fails

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Yasuhito FUTATSUKI
On 2019/09/24 16:34, Branko Čibej wrote: On 23.09.2019 22:48, Johan Corveleyn wrote: On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI wrote: On 2019/09/23 6:16, Johan Corveleyn wrote: Building with Python 3.7.4 still fails with the same error though (no problem, I know your patch wasn't

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Yasuhito FUTATSUKI
On 2019/09/28 5:51, Johan Corveleyn wrote: Great! That fixes this particular problem, and the test suite now runs successfully ... almost. There seems to be one more problem: [[[ Testing Release configuration on local repository. -- Running Swig Python tests --

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-27 Thread Johan Corveleyn
On Fri, Sep 27, 2019 at 8:14 PM Yasuhito FUTATSUKI wrote: > Thank you for testing. And thank you for hanging in there for the py3 work :-). > It seems that urllib.request.pathname2url() on Windows doesn't accept > bytes on Python 3, while on Linux/Unix it accepts both of bytes and str. > > The

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-27 Thread Yasuhito FUTATSUKI
Thank you for testing. On 2019/09/24 5:48, Johan Corveleyn wrote: So, on to the next problem. When testing with Python 3.7.4 on Windows, I get the following error: [[[ C:\research\svn\dev\swig-py3>python win-tests.py -c --log-level=DEBUG --release --swig=python R:\test_py 'ruby' is not

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-24 Thread Branko Čibej
On 23.09.2019 22:48, Johan Corveleyn wrote: > On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI > wrote: >> On 2019/09/23 6:16, Johan Corveleyn wrote: >>> On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI >>> wrote: On 2019/09/20 0:44, Daniel Shahaf wrote: > Yasuhito FUTATSUKI

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-23 Thread Johan Corveleyn
On Mon, Sep 23, 2019 at 1:53 AM Yasuhito FUTATSUKI wrote: > > On 2019/09/23 6:16, Johan Corveleyn wrote: > > On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI > > wrote: > >> > >> On 2019/09/20 0:44, Daniel Shahaf wrote: > >>> Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: > >> >

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-22 Thread Yasuhito FUTATSUKI
On 2019/09/23 6:16, Johan Corveleyn wrote: On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI wrote: On 2019/09/20 0:44, Daniel Shahaf wrote: Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: The FAIL on test_merge_peg3 is a newline style issue on reading file in raw mode, which

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-22 Thread Johan Corveleyn
On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI wrote: > > On 2019/09/20 0:44, Daniel Shahaf wrote: > > Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: > > >> The FAIL on test_merge_peg3 is a newline style issue on reading file > >> in raw mode, which is introduced by my patch. >

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-21 Thread Yasuhito FUTATSUKI
On 2019/09/20 0:44, Daniel Shahaf wrote: Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: The FAIL on test_merge_peg3 is a newline style issue on reading file in raw mode, which is introduced by my patch.

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-20 Thread Branko Čibej
On 20.09.2019 11:53, Paul Hammant wrote: > One more thing re Python3 - there's Svn Homebrew fu for Mac folks - > https://github.com/Homebrew/homebrew-core/blob/master/Formula/subversion.rb > - that work admirably for Python 2.7.x but has no code for Python 3.  > I don't think this brew formula is

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-20 Thread Paul Hammant
One more thing re Python3 - there's Svn Homebrew fu for Mac folks - https://github.com/Homebrew/homebrew-core/blob/master/Formula/subversion.rb - that work admirably for Python 2.7.x but has no code for Python 3. I don't think this brew formula is maintained in the svn dev team. Of course,

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-19 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: > On 2019/09/19 8:21, Johan Corveleyn wrote: > > On Wed, Sep 18, 2019 at 12:08 PM Branko Čibej wrote: > >> You do *not* need a definition of 'struct foo' in order to use a 'struct > >> foo*' pointer. So, no, that's not the problem. > >

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-19 Thread Yasuhito FUTATSUKI
On 2019/09/19 8:21, Johan Corveleyn wrote: On Wed, Sep 18, 2019 at 12:08 PM Branko Čibej wrote: On 18.09.2019 09:20, Johan Corveleyn wrote: On Wed, Sep 18, 2019 at 5:36 AM Branko Čibej wrote: On 18.09.2019 02:48, Johan Corveleyn wrote: [[[ c:\python37\include\pytime.h(123): error C4115:

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Johan Corveleyn
On Wed, Sep 18, 2019 at 12:08 PM Branko Čibej wrote: > > On 18.09.2019 09:20, Johan Corveleyn wrote: > > On Wed, Sep 18, 2019 at 5:36 AM Branko Čibej wrote: > >> On 18.09.2019 02:48, Johan Corveleyn wrote: > >>> On Mon, Sep 2, 2019 at 11:45 AM Julian Foad wrote: > > Troy Curtis Jr wrote: >

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Branko Čibej
On 18.09.2019 09:20, Johan Corveleyn wrote: > On Wed, Sep 18, 2019 at 5:36 AM Branko Čibej wrote: >> On 18.09.2019 02:48, Johan Corveleyn wrote: >>> On Mon, Sep 2, 2019 at 11:45 AM Julian Foad wrote: > Troy Curtis Jr wrote: >> James McCoy wrote: >>> Finishing(?) and merging the

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 18 Sep 2019 07:44 +00:00: > On Wed, Sep 18, 2019 at 9:31 AM Daniel Shahaf wrote: > > > > Johan Corveleyn wrote on Wed, 18 Sep 2019 00:48 +00:00: > > > No problem, after downloading py3c from Github, and adding > > > --with-py3c, I can start building it. > > > > What

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Johan Corveleyn
On Wed, Sep 18, 2019 at 9:31 AM Daniel Shahaf wrote: > > Johan Corveleyn wrote on Wed, 18 Sep 2019 00:48 +00:00: > > No problem, after downloading py3c from Github, and adding > > --with-py3c, I can start building it. > > What version of py3c did you download? HEAD or a release? Hm, I

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 18 Sep 2019 00:48 +00:00: > No problem, after downloading py3c from Github, and adding > --with-py3c, I can start building it. What version of py3c did you download? HEAD or a release?

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Johan Corveleyn
On Wed, Sep 18, 2019 at 5:36 AM Branko Čibej wrote: > > On 18.09.2019 02:48, Johan Corveleyn wrote: > > On Mon, Sep 2, 2019 at 11:45 AM Julian Foad wrote: > >>> Troy Curtis Jr wrote: > James McCoy wrote: > > Finishing(?) and merging the Python3 support would be ideal. That would >

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-17 Thread Branko Čibej
On 18.09.2019 02:48, Johan Corveleyn wrote: > On Mon, Sep 2, 2019 at 11:45 AM Julian Foad wrote: >>> Troy Curtis Jr wrote: James McCoy wrote: > Finishing(?) and merging the Python3 support would be ideal. That would > give one release for broader feedback before being in an LTS

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-17 Thread Johan Corveleyn
On Mon, Sep 2, 2019 at 11:45 AM Julian Foad wrote: > > Troy Curtis Jr wrote: > >> James McCoy wrote: > >>> Finishing(?) and merging the Python3 support would be ideal. That would > >>> give one release for broader feedback before being in an LTS release. > >> > >> It needs to get reintegrated

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-02 Thread Nathan Hartman
On Mon, Sep 2, 2019 at 8:23 AM Julian Foad wrote: > Thanks. I see no reason to make a special effort to have swig-py > bindings still support Python 2 for Subversion 1.13 and 1.14-LTS. In > fact, it's probably best if we explicitly remove Py2 support for 1.14, > to avoid getting trapped in

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-02 Thread Julian Foad
Branko Čibej wrote: What Py3 support are we talking about anyway? svn build? svn test suite? swig-py bindings? This is about the work that's happening on the swig-py3 branch. So: that would be support for building the swig-py bindings for both Python3 and Python2. Trunk only support Python2

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-02 Thread Branko Čibej
On 02.09.2019 11:45, Julian Foad wrote: >> Troy Curtis Jr wrote: >>> James McCoy wrote: Finishing(?) and merging the Python3 support would be ideal.  That would give one release for broader feedback before being in an LTS release. >>> >>> It needs to get reintegrated with trunk

Python3 work [was: The run up to Subversion 1.13.0]

2019-09-02 Thread Julian Foad
Troy Curtis Jr wrote: James McCoy wrote: Finishing(?) and merging the Python3 support would be ideal. That would give one release for broader feedback before being in an LTS release. It needs to get reintegrated with trunk again with the latest changes, but the linux side of the house was