Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-25 Thread Paul Davis
On Thu, May 24, 2012 at 3:54 AM, Greg Stein gst...@gmail.com wrote: Git people, The community is discussing what to do about this particular approach for sending a patch (we have a defined and published method for sending a patch to our community). That is a separate thread, but pending

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-25 Thread Blair Zajac
On 05/24/2012 01:32 AM, Greg Stein wrote: Hey all, I moderated this through, in order to start a discussion. My feeling is: this is not how we want to accept patches. This approach is completely disconnected from our community. How do we talk to the person providing the change? How do we ask

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Greg Stein
Hey all, I moderated this through, in order to start a discussion. My feeling is: this is not how we want to accept patches. This approach is completely disconnected from our community. How do we talk to the person providing the change? How do we ask for modifications? How to interact? But even

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Greg Stein
Git people, The community is discussing what to do about this particular approach for sending a patch (we have a defined and published method for sending a patch to our community). That is a separate thread, but pending that... I have a separate meta/infra issue for you. The Subversion PMC does

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Daniel Shahaf
On Thu, May 24, 2012 at 04:54:45AM -0400, Greg Stein wrote: In short, this GitHub repository is representing Apache Subversion without the PMC providing any actual oversight or any mechanism to manage it. Greg made a good point on IRC: PMC's should at least be _made aware_ that a github mirror

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Julian Foad
Hi Anatoly. The Subversion team has just received this pull request from you.  The current patch submission process is here http://subversion.apache.org/docs/community-guide/general.html#patches, and in particular we would require an email on this mailing list and a log message to explain the

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Julian Foad
Greg Stein wrote: I moderated this through, in order to start a discussion. My feeling is: this is not how we want to accept patches. This approach is completely disconnected from our community. How do we talk to the person providing the change? How do we ask for modifications? How to

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Julian Foad
What I said there is my personal opinion; not necessarily that of the Subversion community. - Julian I (Julian Foad) wrote: Hi Anatoly. The Subversion team has just received this pull request from you.  The current patch submission process is here

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Filip Maj
Without a doubt getting access to the project mirrors on GitHub is a must-have. Setting up different teams on GitHub is trivial. Could have a committers team, and any other team deemed necessary. We can then add permissions such as ability to administer the github project to these teams. As for

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Philip Martin
Greg Stein gst...@gmail.com writes: My feeling is: this is not how we want to accept patches. This approach is completely disconnected from our community. How do we talk to the person providing the change? How do we ask for modifications? How to interact? But even larger: our goal is to get

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Stefan Sperling
On Thu, May 24, 2012 at 11:32:42AM +0100, Philip Martin wrote: I don't like it. The email doesn't contain the patch or the log message. The email has the address of the patch author in the body and not in the headers. Patches should be visible and discussed on dev. Since you mention it: I

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Daniel Shahaf
(wearing both an infra hat and an svn hat...) Filip Maj wrote on Thu, May 24, 2012 at 03:22:19 -0700: Without a doubt getting access to the project mirrors on GitHub is a must-have. Setting up different teams on GitHub is trivial. Could have a committers team, and any other team deemed

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Filip Maj
My answers in-line below. On 5/24/12 12:48 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: (wearing both an infra hat and an svn hat...) Filip Maj wrote on Thu, May 24, 2012 at 03:22:19 -0700: Without a doubt getting access to the project mirrors on GitHub is a must-have. Setting up

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Philip Martin
Filip Maj f...@adobe.com writes: Without a doubt getting access to the project mirrors on GitHub is a must-have. Setting up different teams on GitHub is trivial. Could have a committers team, and any other team deemed necessary. We can then add permissions such as ability to administer the

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Daniel Shahaf
Filip Maj wrote on Thu, May 24, 2012 at 03:57:51 -0700: My answers in-line below. On 5/24/12 12:48 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: (wearing both an infra hat and an svn hat...) Filip Maj wrote on Thu, May 24, 2012 at 03:22:19 -0700: Without a doubt getting access to

RE: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Gavin McDonald
... -Original Message- From: Greg Stein [mailto:gst...@gmail.com] Sent: Thursday, 24 May 2012 6:25 PM To: Git at Apache; infrastructure-...@apache.org; Jukka Zitting; dav...@apache.org Cc: dev@subversion.apache.org Subject: Re: subversion pull request: port to new style classes - http

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Daniel Shahaf
Gavin McDonald wrote on Thu, May 24, 2012 at 21:08:43 +0930: As per suggestion, Ive created a 'Apache Subversion' Team which can 'push,pull,administer' the apache/subversion repo. -1 on push rights (svn hat). The canonical place for new code to enter the Subversion codebase is

RE: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Gavin McDonald
: subversion pull request: port to new style classes - http://stackoverflow.c... Hi, On Thu, May 24, 2012 at 1:38 PM, Gavin McDonald ga...@16degrees.com.au wrote: Ive created a 'Apache Subversion' Team which can 'push,pull,administer' the apache/subversion repo. Please don't

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Jukka Zitting
Hi, On Thu, May 24, 2012 at 10:54 AM, Greg Stein gst...@gmail.com wrote: The Subversion PMC does not seem to have access to manage our presence on GitHub, yet people seem to believe it is a viable approach to send us patches. At a minimum, the PMC needs a way to manage our presence on GitHub:

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Jukka Zitting
Hi, On Thu, May 24, 2012 at 1:38 PM, Gavin McDonald ga...@16degrees.com.au wrote: Ive created a 'Apache Subversion' Team which can 'push,pull,administer' the apache/subversion repo. Please don't! The GitHub mirrors are strictly read-only for a purpose. We don't want development to diverge

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Filip Maj
It makes sense to me that Apache try to curate the strong developer communities that exist on GitHub. There is an ease of sending patches via GitHub that is at odds with the process of, at the minimum, registering for the dev list for a specific project and submitting a patch that way. My goal

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Daniel Shahaf
Jukka Zitting wrote on Thu, May 24, 2012 at 13:39:48 +0200: The GitHub pull request notification you saw on dev@subversion, is a result of our work to better integrate GitHub workflows with those at Apache. The idea here is to send the issue to dev@ from where the project community can deal

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Filip Maj
I think all we want is the administration rights, but GitHub fails here in that you can't separate admin vs. push rights. Sigh. On 5/24/12 1:53 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Gavin McDonald wrote on Thu, May 24, 2012 at 21:08:43 +0930: As per suggestion, Ive created a

RE: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread Greg Stein
; Git at Apache; dav...@apache.org; dev@subversion.apache.org Subject: Re: subversion pull request: port to new style classes - http://stackoverflow.c... Hi, On Thu, May 24, 2012 at 1:38 PM, Gavin McDonald ga...@16degrees.com.au wrote: Ive created a 'Apache Subversion' Team which

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread anatoly techtonik
Hi Julian, Thanks for the notice. The pull request was premature (I actually made by editing the file from GitHub web interface) - there are more patches to come, but as soon as they are ready I'll send an update to this thread. Feel free to comment separate revisions in the meanwhile.

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-24 Thread anatoly techtonik
On Thu, May 24, 2012 at 6:03 PM, Stefan Sperling s...@elego.de wrote: On Thu, May 24, 2012 at 05:37:17PM +0300, anatoly techtonik wrote: Hi Julian, Thanks for the notice. The pull request was premature (I actually made by editing the file from GitHub web interface) - there are more patches