Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Branko Čibej
On 02.11.2018 11:33, James McCoy wrote: > On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote: >> On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: >>> On 02.11.2018 10:44, Stefan Sperling wrote: I confirm that your patch is correct. I mis-indented these blocks. >>>

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread James McCoy
On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote: > On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: > > On 02.11.2018 10:44, Stefan Sperling wrote: > > > I confirm that your patch is correct. I mis-indented these blocks. > > > > Time to start using a real editor, I

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Greg Stein
On Fri, Nov 2, 2018 at 5:08 AM Stefan Sperling wrote: > On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: > > On 02.11.2018 10:44, Stefan Sperling wrote: > > > I confirm that your patch is correct. I mis-indented these blocks. > > > > Time to start using a real editor, I guess? :) >

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Stefan Sperling
On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: > On 02.11.2018 10:44, Stefan Sperling wrote: > > I confirm that your patch is correct. I mis-indented these blocks. > > Time to start using a real editor, I guess? :) The further I progress into adulthood, the more our tiny

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Joe Orton
On Fri, Nov 02, 2018 at 10:44:33AM +0100, Stefan Sperling wrote: > I confirm that your patch is correct. I mis-indented these blocks. Great, thank you for checking, Stefan. Committed in r1845559.

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Branko Čibej
On 02.11.2018 10:44, Stefan Sperling wrote: > On Fri, Nov 02, 2018 at 09:39:47AM +, Joe Orton wrote: >> There are two gcc 8.x (I'm using 8.2.1) warnings from which catch those: >> >> if (foo) >> bar; >> baz; >> >> type of errors. I fixed one case which looks obviously like a false

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread Stefan Sperling
On Fri, Nov 02, 2018 at 09:39:47AM +, Joe Orton wrote: > There are two gcc 8.x (I'm using 8.2.1) warnings from which catch those: > > if (foo) > bar; > baz; > > type of errors. I fixed one case which looks obviously like a false > positive in r1845556, but I'm not sure about the