Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Stefan Sperling
On Thu, Apr 15, 2010 at 05:36:36PM +0100, Julian Foad wrote: > I (Julian Foad) wrote: > > The "line filter" and "line transformer": I don't think these fit the > > stream abstraction at all well. Streams don't have "lines" as a primary > > concept. Without going into the details, I think it can't

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Julian Foad
I (Julian Foad) wrote: > The "line filter" and "line transformer": I don't think these fit the > stream abstraction at all well. Streams don't have "lines" as a primary > concept. Without going into the details, I think it can't play nicely > with plain reads and writes, and I doubt it's properly

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Julian Foad
On Thu, 2010-04-15 at 17:59 +0200, Stefan Sperling wrote: > On Thu, Apr 15, 2010 at 11:28:13AM -0400, Greg Stein wrote: > > I'd suggest that we simply remove mark/seek/reset from the translated > > stream. > > We could not handle keywords or newlines during patching if we did that. Or, more accu

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Stefan Sperling
On Thu, Apr 15, 2010 at 11:28:13AM -0400, Greg Stein wrote: > I'd suggest that we simply remove mark/seek/reset from the translated stream. We could not handle keywords or newlines during patching if we did that. > (I was never comfortable with that extension to our streams in the > first place,

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Greg Stein
I'd suggest that we simply remove mark/seek/reset from the translated stream. (I was never comfortable with that extension to our streams in the first place, and I don't see a reason that all streams must implement them) Cheers, -g On Thu, Apr 15, 2010 at 09:18, Julian Foad wrote: > I noticed s

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Julian Foad
Stefan Sperling wrote: > On Thu, Apr 15, 2010 at 02:18:22PM +0100, Julian Foad wrote: > > I noticed some oddities/problems with the stream mark/seek/reset > > functionality in svn_subst_stream_translated(). > > > > 1. > > svn_subst_stream_translated() doesn't handle mark/seek properly. > > transla

Re: Mark/seek/reset problems in svn_subst_stream_translated()

2010-04-15 Thread Stefan Sperling
On Thu, Apr 15, 2010 at 02:18:22PM +0100, Julian Foad wrote: > I noticed some oddities/problems with the stream mark/seek/reset > functionality in svn_subst_stream_translated(). > > 1. > svn_subst_stream_translated() doesn't handle mark/seek properly. > translated_stream_mark() saves and translate