Re: inconsistent null-ptr handling in utf-path related functions

2016-01-26 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Tue, Jan 26, 2016 at 09:21:44 +0100: > From that, I would derive the following heuristics: > Once we agree upon a set of guidelines, it'll be nice to add it to HACKING, at least as a link to your email. They heuristics you propose sound good to me, so +0. (The only reas

Re: inconsistent null-ptr handling in utf-path related functions

2016-01-26 Thread Stefan Fuhrmann
On 25.01.2016 22:30, Stefan wrote: Hi, looking through the code, I'm wondering that there's some inconsistent behavior/handling with regards to calling certain svn_utf-functions with a nullptr. svn_utf__cstring_is_valid() for instance does a nullptr check against the provided data and returns