Re: r1673875: Provide a central and complete implementation for handling FSFS quirks...

2015-04-18 Thread Julian Foad
Stefan Fuhrmann wrote: >> @@ -1386,11 +1386,11 @@ svn_fs_fs__file_length(svn_filesize_t *l [...] >> - A plain representation may specify its EXPANDED LENGTH as "0" >> + A plain representation may specify its EXPANDED_SIZE as "0" [...] > > That should be implicitly fixed be r1674400.

Re: r1673875: Provide a central and complete implementation for handling FSFS quirks...

2015-04-17 Thread Stefan Fuhrmann
On Fri, Apr 17, 2015 at 10:10 AM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > Thanks for the corrections! > > Committed as r1674165. > > Thanks. Here's another: > > [[[ > Index: subversion/libsvn_fs_fs/fs.h > === > --- subversion

Re: r1673875: Provide a central and complete implementation for handling FSFS quirks...

2015-04-17 Thread Julian Foad
Stefan Fuhrmann wrote: > Thanks for the corrections! > Committed as r1674165. Thanks. Here's another: [[[ Index: subversion/libsvn_fs_fs/fs.h === --- subversion/libsvn_fs_fs/fs.h(revision 1674067) +++ subversion/libsvn_fs_fs/fs.h

Re: r1673875: Provide a central and complete implementation for handling FSFS quirks...

2015-04-16 Thread Stefan Fuhrmann
On Thu, Apr 16, 2015 at 1:26 PM, Julian Foad wrote: > Just a couple of observations on the comments. > > + /* EXPANDED_SIZE is 0. If the MD5 does not match the one for empty > + * contents, we know that we need to correct EXPANDED_SIZE. */ > + empty_md5 = svn_checksum_empty_checksum(svn_check