Re: svn commit: r1362480 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2012-07-17 Thread Daniel Shahaf
Blair Zajac wrote on Tue, Jul 17, 2012 at 09:48:25 -0700: > On 7/17/12 6:17 AM, phi...@apache.org wrote: > >Author: philip > >Date: Tue Jul 17 13:17:34 2012 > >New Revision: 1362480 > > > >URL: http://svn.apache.org/viewvc?rev=1362480&view=rev > >Log: > >* subversion/libsvn_fs/fs-loader.c > > (lo

Re: svn commit: r1362480 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2012-07-17 Thread Philip Martin
Blair Zajac writes: > This code doesn't probably get run often, but generally it's better to > iterate through name using pointers instead of strlen() since the > later scans the string twice. Agreed. r1362569. -- Cerified & Supported Apache Subversion Downloads: http://www.wandisco.com/subver

Re: svn commit: r1362480 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2012-07-17 Thread Blair Zajac
On 7/17/12 6:17 AM, phi...@apache.org wrote: Author: philip Date: Tue Jul 17 13:17:34 2012 New Revision: 1362480 URL: http://svn.apache.org/viewvc?rev=1362480&view=rev Log: * subversion/libsvn_fs/fs-loader.c (load_module): Only allow alphanumeric characters in name. apr_status_t sta