Re: svn commit: r1413482 - /subversion/trunk/subversion/libsvn_subr/string.c

2012-11-26 Thread Branko Čibej
On 26.11.2012 18:43, Julian Foad wrote: > Hi Brane. It looks basically fine to me. A few stylistic comments below. Thanks, I'll take them into account. > +while (new_size < size) > + { > +/* new_size is aligned; doubling it should keep it aligned */ > +c

Re: svn commit: r1413482 - /subversion/trunk/subversion/libsvn_subr/string.c

2012-11-26 Thread Julian Foad
Hi Brane.  It looks basically fine to me.  A few stylistic comments below. Branko Čibej wrote: >> URL: http://svn.apache.org/viewvc?rev=1413482&view=rev >> Log: >> Factor the svn_stringbuf_t and svn_membuf_t implementation to a common >> code base. >> >> * subversion/libsvn_subr/string.c (me

Re: svn commit: r1413482 - /subversion/trunk/subversion/libsvn_subr/string.c

2012-11-25 Thread Branko Čibej
On 26.11.2012 06:27, br...@apache.org wrote: > Author: brane > Date: Mon Nov 26 05:27:20 2012 > New Revision: 1413482 > > URL: http://svn.apache.org/viewvc?rev=1413482&view=rev > Log: > Factor the svn_stringbuf_t and svn_membuf_t implementation to a common code > base. > > * subversion/libsvn_subr