Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-05-11 Thread Branko Čibej
On 11.05.2013 14:10, Stefan Sperling wrote: > On Sat, May 11, 2013 at 01:50:50PM +0200, Branko Čibej wrote: >> On 11.05.2013 13:31, Stefan Sperling wrote: >>> DST_TMP has more restrictive permissions than that. It is created with >>> the mkstemp() function under the hood. So we can assume that the

Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-05-11 Thread Stefan Sperling
On Sat, May 11, 2013 at 01:50:50PM +0200, Branko Čibej wrote: > On 11.05.2013 13:31, Stefan Sperling wrote: > > DST_TMP has more restrictive permissions than that. It is created with > > the mkstemp() function under the hood. So we can assume that the perms > > of DST_TMP are configured such that o

Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-05-11 Thread Branko Čibej
On 11.05.2013 13:31, Stefan Sperling wrote: > DST_TMP has more restrictive permissions than that. It is created with > the mkstemp() function under the hood. So we can assume that the perms > of DST_TMP are configured such that only the user running svn can > access the file. So we always start off

Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-05-11 Thread Stefan Sperling
On Sat, May 11, 2013 at 01:28:26PM +0300, Daniel Shahaf wrote: > Stefan Sperling wrote on Tue, Mar 05, 2013 at 14:24:32 +0100: > > If the temp file is within a system-wide temp dir, and we end up expanding > > When exactly is that going to happen? You call svn_stream_open_unique() > with dirpath

Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-05-11 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Mar 05, 2013 at 14:24:32 +0100: > On Tue, Mar 05, 2013 at 02:07:11PM +0100, Bert Huijben wrote: > > > @@ -1743,7 +1743,12 @@ svn_subst_copy_and_translate4(const char > > > } > > > > > >/* Now that dst_tmp contains the translated data, do the atomic rename. >

Re: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-03-05 Thread Stefan Sperling
On Tue, Mar 05, 2013 at 02:07:11PM +0100, Bert Huijben wrote: > > @@ -1743,7 +1743,12 @@ svn_subst_copy_and_translate4(const char > > } > > > >/* Now that dst_tmp contains the translated data, do the atomic rename. > > */ > > - return svn_error_trace(svn_io_file_rename(dst_tmp, dst, pool

RE: svn commit: r1452780 - /subversion/trunk/subversion/libsvn_subr/subst.c

2013-03-05 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: dinsdag 5 maart 2013 13:57 > To: comm...@subversion.apache.org > Subject: svn commit: r1452780 - > /subversion/trunk/subversion/libsvn_subr/subst.c > > Author: stsp > Date: Tue Mar 5 12:57:00 2013 > New Revisi