Re: svn commit: r1590751 - /subversion/trunk/subversion/svn/svn.c

2014-04-29 Thread Philip Martin
Julian Foad writes: >> I was a bit dubious about changing svn_hash_gets as it is currently a >> thin wrapper around apr_hash_get. > > I didn't mean we should change svn_hash_gets(), I meant to avoid > calling it if we have no hash. The reason for creating the empty svn_config_t was avoid having

Re: svn commit: r1590751 - /subversion/trunk/subversion/svn/svn.c

2014-04-29 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >>> URL: http://svn.apache.org/r1590751 >> >> I'm wondering why you create the two SVN_CONFIG_CATEGORY_... entries >> in the hash? If there's a need for a standard empty config to be >> created that's more than just an empty hash, we should have a >> cons

Re: svn commit: r1590751 - /subversion/trunk/subversion/svn/svn.c

2014-04-29 Thread Philip Martin
Julian Foad writes: >> Author: philip > >> URL: http://svn.apache.org/r1590751 >> Log: >> If reading the users config fails, say because $HOME is unreadable, >> provide an empty config rather than a NULL config.  This fixes a >> SEGV and allows command line options that override the default >> co

Re: svn commit: r1590751 - /subversion/trunk/subversion/svn/svn.c

2014-04-29 Thread Julian Foad
> Author: philip > URL: http://svn.apache.org/r1590751 > Log: > If reading the users config fails, say because $HOME is unreadable, > provide an empty config rather than a NULL config.  This fixes a > SEGV and allows command line options that override the default > config to work. Hi Philip. I'm