Re: Repeated SQL queries when doing 'svn st'

2010-09-08 Thread Stefan Fuhrmann
Philip Martin wrote: Branko Čibej writes: On 06.09.2010 12:16, Philip Martin wrote: To use a per-directory query strategy we would probably have to cache data in memory, although not to the same extent as in 1.6. We should probably avoid having Subversion make status callbacks into

Re: Repeated SQL queries when doing 'svn st'

2010-09-06 Thread Philip Martin
Branko Čibej writes: > On 06.09.2010 12:16, Philip Martin wrote: >> To use a per-directory query strategy we would probably have to cache >> data in memory, although not to the same extent as in 1.6. We should >> probably avoid having Subversion make status callbacks into the >> application whi

Re: Repeated SQL queries when doing 'svn st'

2010-09-06 Thread Branko Čibej
On 06.09.2010 12:16, Philip Martin wrote: > To use a per-directory query strategy we would probably have to cache > data in memory, although not to the same extent as in 1.6. We should > probably avoid having Subversion make status callbacks into the > application while a query is in progress, so

Re: Repeated SQL queries when doing 'svn st'

2010-09-06 Thread Philip Martin
Justin Erenkrantz writes: > When compiled with SVN_DEBUG and SQLITE3_DEBUG and 'svn st' against a > svn trunk WC, a number of things pop out. > > We perform 28,062 SQL queries. It's not just repeat queries that are the problem, we simply make too many queries. This is mainly because the code is

RE: Repeated SQL queries when doing 'svn st'

2010-09-05 Thread Bert Huijben
> -Original Message- > From: justin.erenkra...@gmail.com [mailto:justin.erenkra...@gmail.com] > On Behalf Of Justin Erenkrantz > Sent: zaterdag 4 september 2010 20:20 > To: Subversion Development > Subject: Re: Repeated SQL queries when doing 'svn st' > &g

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Branko Čibej
On 04.09.2010 21:45, Justin Erenkrantz wrote: > On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz > wrote: >> Notably, AFAICT, we're repeating a few of these queries: >> >> - STMT_SELECT_WORKING_NODE (2 times) >> - STMT_SELECT_ACTUAL_NODE (3 times) >> - STMT_SELECT_WORKING_PROPS (2 times) >> - S

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 12:45 PM, Justin Erenkrantz wrote: > I'm going to see what a quick check to retrieve just the kind and > status will do for the query volume.  I think it's unlikely we have to > pull everything out of sqlite to answer that basic question.  -- > justin We can reduce the quer

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz wrote: > Notably, AFAICT, we're repeating a few of these queries: > > - STMT_SELECT_WORKING_NODE (2 times) > - STMT_SELECT_ACTUAL_NODE (3 times) > - STMT_SELECT_WORKING_PROPS (2 times) > - STMT_SELECT_BASE_PROPS (2 times) > > I haven't yet dug int

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz wrote: > When compiled with SVN_DEBUG and SQLITE3_DEBUG and 'svn st' against a > svn trunk WC, a number of things pop out. > > We perform 28,062 SQL queries. > > --- > DBG: sqlite.c:  63: sql="select root, uuid from repository where id = 1;" > ---

Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
When compiled with SVN_DEBUG and SQLITE3_DEBUG and 'svn st' against a svn trunk WC, a number of things pop out. We perform 28,062 SQL queries. --- DBG: sqlite.c: 63: sql="select root, uuid from repository where id = 1;" --- We execute *this* query (STMT_SELECT_REPOSITORY_BY_ID) 2215 times. Yik