Re: fsfs-improvements branch complete

2013-08-26 Thread Stefan Fuhrmann
On Thu, Jul 25, 2013 at 4:39 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > Hi all, > > After two weeks now, I finally completed the fsfs format 6 refactoring > and improvement work on said branch. Please review. See also > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "s

Re: fsfs-improvements branch complete

2013-08-14 Thread Stefan Fuhrmann
On Tue, Aug 13, 2013 at 2:13 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > After two weeks now, I finally completed the fsfs format 6 refactoring > > and improvement work on said branch. Please review. See also > > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > >

Re: fsfs-improvements branch complete

2013-08-13 Thread Philip Martin
Stefan Fuhrmann writes: > After two weeks now, I finally completed the fsfs format 6 refactoring > and improvement work on said branch. Please review. See also > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > fs_fs.c" part of it. > > If there are no objections, I will merge

RE: fsfs-improvements branch complete

2013-08-11 Thread Bert Huijben
emory, which then ends up as long lived. We should slowly move to dual pools for every function with long lived output arguments. Bert -- From: Stefan Fuhrmann Sent: 12/08/2013 00:39 To: Philip Martin Cc: Subversion Development Subject: Re: fsfs-improvements b

Re: fsfs-improvements branch complete

2013-08-11 Thread Stefan Fuhrmann
On Thu, Aug 8, 2013 at 12:42 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > After two weeks now, I finally completed the fsfs format 6 refactoring > > and improvement work on said branch. Please review. See also > > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > >

Re: fsfs-improvements branch complete

2013-08-08 Thread Philip Martin
Stefan Fuhrmann writes: > After two weeks now, I finally completed the fsfs format 6 refactoring > and improvement work on said branch. Please review. See also > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > fs_fs.c" part of it. > > If there are no objections, I will merge

Re: fsfs-improvements branch complete

2013-07-29 Thread Stefan Fuhrmann
On Mon, Jul 29, 2013 at 3:21 PM, Philip Martin wrote: > Philip Martin writes: > > > Stefan Fuhrmann writes: > > > >> Thanks for spotting & fixing this! > >> The extra "_" was a recent addition to make output match /trunk. > > > > Another difference: db/txn-current produced by the branch does not

Re: fsfs-improvements branch complete

2013-07-29 Thread Philip Martin
Philip Martin writes: > Stefan Fuhrmann writes: > >> Thanks for spotting & fixing this! >> The extra "_" was a recent addition to make output match /trunk. > > Another difference: db/txn-current produced by the branch does not have > a trailing \n. It works, but it might be better if it was th

Re: fsfs-improvements branch complete

2013-07-29 Thread Philip Martin
Stefan Fuhrmann writes: > Thanks for spotting & fixing this! > The extra "_" was a recent addition to make output match /trunk. Another difference: db/txn-current produced by the branch does not have a trailing \n. It works, but it might be better if it was the same as trunk. -- Philip Marti

Re: fsfs-improvements branch complete

2013-07-27 Thread Stefan Fuhrmann
On Fri, Jul 26, 2013 at 4:38 PM, Philip Martin wrote: > Philip Martin writes: > > > The branch uniquifiers aren't unique. I see the branch code writing > > different uniqifiers into the transaction files but _0 values appear in > > the revision file. > > The code in svn_fs_fs__parse_representati

Re: fsfs-improvements branch complete

2013-07-26 Thread Philip Martin
Philip Martin writes: > The branch uniquifiers aren't unique. I see the branch code writing > different uniqifiers into the transaction files but _0 values appear in > the revision file. The code in svn_fs_fs__parse_representation doesn't seem to parse the uniqifier properly: (gdb) p string $6

Re: fsfs-improvements branch complete

2013-07-26 Thread Philip Martin
Stefan Fuhrmann writes: > After two weeks now, I finally completed the fsfs format 6 refactoring > and improvement work on said branch. Please review. See also > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > fs_fs.c" part of it. > > If there are no objections, I will merge

fsfs-improvements branch complete

2013-07-25 Thread Stefan Fuhrmann
Hi all, After two weeks now, I finally completed the fsfs format 6 refactoring and improvement work on said branch. Please review. See also http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up fs_fs.c" part of it. If there are no objections, I will merge the code in the week of Aug