Re: r1039140 (or, spineless code is for the birds).

On 11/29/2010 02:23 PM, Julian Foad wrote: > Julian Foad wrote: >> We agreed that C-Mike will clean up print_update_summary() and I will >> make the caller reject URL targets in the first place, like Noorul has >> done for other subcommands recently. > > r1040232 (mine) and r1040233 (Mike's). Tha

Re: r1039140 (or, spineless code is for the birds).

Julian Foad wrote: > We agreed that C-Mike will clean up print_update_summary() and I will > make the caller reject URL targets in the first place, like Noorul has > done for other subcommands recently. r1040232 (mine) and r1040233 (Mike's). Thanks for raising this, Mike. - Julian

Re: r1039140 (or, spineless code is for the birds).

C. Michael Pilato wrote: > > r1039140 | julianfoad | 2010-11-25 13:51:34 -0500 (Thu, 25 Nov 2010) | 4 > > lines > > Changed paths: > >M /subversion/trunk/subversion/svn/update-cmd.c > > > > Fix assertion failures. > > > > * subversion/svn/update-cmd.c > > (print_update_summary): Don't allo

r1039140 (or, spineless code is for the birds).

> r1039140 | julianfoad | 2010-11-25 13:51:34 -0500 (Thu, 25 Nov 2010) | 4 lines > Changed paths: >M /subversion/trunk/subversion/svn/update-cmd.c > > Fix assertion failures. > > * subversion/svn/update-cmd.c > (print_update_summary): Don't allow a URL to reach svn_dirent_*(). Why? First,