Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-18 Thread Hyrum K Wright
r1327597 approaches the problem from a different angle, partially inspired by Greg's comment. We just fetch the relpaths for the various commit items before doing the commit, shove them into a hash mapping that to the appropriate abspath, and then let the shim callbacks use the hash to find their

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-17 Thread Julian Foad
Hyrum K Wright wrote: On Mon, Apr 16, 2012 at 5:22 PM, Greg Stein wrote: On Mon, Apr 16, 2012 at 18:04, Stefan Sperling wrote: On Mon, Apr 16, 2012 at 04:41:49PM -0500, Hyrum K Wright wrote: On Mon, Apr 16, 2012 at 4:35 PM, Greg Stein wrote: On Mon, Apr 16, 2012 at 13:50,

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-17 Thread Greg Stein
This is a lot of design work to compensate for losing file.c. IMO, the short answer is: stop converting to repos_relpath for all cases. If we don't lose local_abspath, then we can get all the base info. On Apr 17, 2012 4:29 AM, Julian Foad julianf...@btopenworld.com wrote: Hyrum K Wright

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Greg Stein
On Mon, Apr 16, 2012 at 13:50, hwri...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_client/util.c Mon Apr 16 17:50:05 2012 ... +  /* ### We could probably calculate some of this once, and then cache it for +         use in this function. */ +  

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Hyrum K Wright
On Mon, Apr 16, 2012 at 4:35 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at 13:50,  hwri...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_client/util.c Mon Apr 16 17:50:05 2012 ... +  /* ### We could probably calculate some of this once, and then cache it for +

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Stefan Sperling
On Mon, Apr 16, 2012 at 04:41:49PM -0500, Hyrum K Wright wrote: On Mon, Apr 16, 2012 at 4:35 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at 13:50,  hwri...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_client/util.c Mon Apr 16 17:50:05 2012 ... +  /* ###

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Greg Stein
On Mon, Apr 16, 2012 at 18:04, Stefan Sperling s...@elego.de wrote: On Mon, Apr 16, 2012 at 04:41:49PM -0500, Hyrum K Wright wrote: On Mon, Apr 16, 2012 at 4:35 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at 13:50,  hwri...@apache.org wrote: ... +++

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Hyrum K Wright
On Mon, Apr 16, 2012 at 5:22 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at 18:04, Stefan Sperling s...@elego.de wrote: On Mon, Apr 16, 2012 at 04:41:49PM -0500, Hyrum K Wright wrote: On Mon, Apr 16, 2012 at 4:35 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-16 Thread Thomas Åkesson
On 17 apr 2012, at 02:26, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 16, 2012 at 5:22 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 16, 2012 at 18:04, Stefan Sperling s...@elego.de wrote: At the very least, you must compare the URL of the node at the calculated