On 13.07.2018 17:36, Philip Martin wrote:
> Julian Foad writes:
>
>> Philip, can you help clarify this?
>>> It's not clear to me from the added paragraph whether the restriction
>>> "only access the context from a thread at a time" is imposed by the
>>> library implementation or by the way API
Julian Foad writes:
> Philip, can you help clarify this?
>>
>> It's not clear to me from the added paragraph whether the restriction
>> "only access the context from a thread at a time" is imposed by the
>> library implementation or by the way API consumers' code is typically
>> structured.
Philip, can you help clarify this?
Daniel Shahaf wrote on 2018-07-02:
> Julian Foad wrote on Mon, 02 Jul 2018 12:20 +0100:
> > Philip Martin wrote:
> > > I did also worry about thread safety: it's not safe to modify the
> > > context like that if the context can be shared across multiple threads.
Julian Foad wrote on Mon, 02 Jul 2018 12:20 +0100:
> Philip Martin wrote:
> > I did also worry about thread safety: it's not safe to modify the
> > context like that if the context can be shared across multiple threads.
> > However the context also includes batons and those typically point to
> >
There are three issues here:
1.
Philip Martin wrote:
> There are SVN_ERR between these two hunks. If one of these returns an
> error we will fail to restore the old config.
There are four other places where libsvn_client functions modify ctx in place.
They are all modifying the notification
Philip Martin writes:
> "Bert Huijben" writes:
>
>> This resets quite a bit more configuration that might still be
>> necessary. (WC-NG config is the first thing I would think of). I think
>> you should duplicate the hash and explicitly remove a few keys.
>
> Changing the client config like
"Bert Huijben" writes:
> This resets quite a bit more configuration that might still be
> necessary. (WC-NG config is the first thing I would think of). I think
> you should duplicate the hash and explicitly remove a few keys.
Changing the client config like this doesn't affect the wc config as
> -Original Message-
> From: julianf...@apache.org [mailto:julianf...@apache.org]
> Sent: donderdag 28 juni 2018 15:50
> To: comm...@subversion.apache.org
> Subject: svn commit: r1834612 - in /subversion/branches/1.10.x-
> issue4758/subversion: libsvn_client/shel
julianf...@apache.org writes:
> Author: julianfoad
> Date: Thu Jun 28 13:50:28 2018
> New Revision: 1834612
>
> URL: http://svn.apache.org/viewvc?rev=1834612=rev
> Log:
> On the '1.10.x-issue4758' branch: Fix SVN-4758 "Unable to shelve changes
> when using custom diff-cmd".
> + /* Ensure we use
9 matches
Mail list logo
