Re: svn commit: r1882522 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/native/OperationContext.cpp

2021-01-27 Thread Alexandr Miloslavskiy
On 27.01.2021 22:56, Johan Corveleyn wrote: Thanks for explaining. Hm, maybe it would be good to note this in some form in the commit message, yes. Just to make sure others scrolling through this in the future are not puzzled by it. Something like: "While here, remove the early exit on null jclo

Re: svn commit: r1882522 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/native/OperationContext.cpp

2021-01-27 Thread Johan Corveleyn
On Wed, Jan 27, 2021 at 10:32 PM Alexandr Miloslavskiy wrote: > > On 27.01.2021 11:13, Johan Corveleyn wrote: > >> +void > >> +OperationContext::closeTunnel(void *tunnel_context, void *) > >> +{ > >> + TunnelContext* tc = static_cast(tunnel_context); > >> + jobject jclosecb = tc->jclosecb; > >>

Re: svn commit: r1882522 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/native/OperationContext.cpp

2021-01-27 Thread Alexandr Miloslavskiy
On 27.01.2021 11:13, Johan Corveleyn wrote: +void +OperationContext::closeTunnel(void *tunnel_context, void *) +{ + TunnelContext* tc = static_cast(tunnel_context); + jobject jclosecb = tc->jclosecb; + delete tc; + + JNIEnv *env = JNIUtil::getEnv(); + if (JNIUtil::isJavaExceptionThrown()) +

Re: svn commit: r1882522 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/native/OperationContext.cpp

2021-01-27 Thread Branko Čibej
On 27.01.2021 11:13, Johan Corveleyn wrote: On Thu, Oct 15, 2020 at 12:16 PM wrote: Author: amiloslavskiy Date: Thu Oct 15 10:15:47 2020 New Revision: 1882522 URL: http://svn.apache.org/viewvc?rev=1882522&view=rev Log: JavaHL: Fix crash in TunnelAgent.CloseTunnelCallback after GC When jobject

Re: svn commit: r1882522 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/native/OperationContext.cpp

2021-01-27 Thread Johan Corveleyn
On Thu, Oct 15, 2020 at 12:16 PM wrote: > > Author: amiloslavskiy > Date: Thu Oct 15 10:15:47 2020 > New Revision: 1882522 > > URL: http://svn.apache.org/viewvc?rev=1882522&view=rev > Log: > JavaHL: Fix crash in TunnelAgent.CloseTunnelCallback after GC > > When jobject reference is kept across dif