Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-12 Thread Stefan Fuhrmann
Daniel Shahaf wrote: stef...@apache.org wrote on Mon, Aug 09, 2010 at 18:33:53 -: Author: stefan2 Date: Mon Aug 9 18:33:53 2010 New Revision: 983766 URL: http://svn.apache.org/viewvc?rev=983766view=rev Log: Fix the root cause of an assertion triggered by exporting KDE /trunk: File

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-12 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Aug 12, 2010 at 21:51:12 +0200: Merged in r984928. Thanks. (actually, this may be a good change to backport to 1.6.x too) It seems to work with the 1.6.x client (at least with the builds I used). So, this bug might have gotten triggered by some

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-12 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Aug 12, 2010 at 22:08:03 +0200: Hyrum K. Wright wrote: On Tue, Aug 10, 2010 at 5:56 AM, Stefan Sperling s...@elego.de wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full committer could +1 you to commit that to directly to /trunk. Yes, please

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 12:56:19PM +0200, Stefan Sperling wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Aug 10, 2010 at 13:06:43 +0200: On Tue, Aug 10, 2010 at 12:56:19PM +0200, Stefan Sperling wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Hyrum K. Wright
On Tue, Aug 10, 2010 at 5:56 AM, Stefan Sperling s...@elego.de wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk.  Next time, you could send this with a [PATCH] marker in the subject line, and a full

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-09 Thread Hyrum K. Wright
Should this fix be made on trunk? To make sure that bug fixes get the broadest coverage, we fix bugs on trunk, and then backport them to feature and/or release branches. It may seem like some additional overhead, since you've (currently) only got commit priviledges on the performance-improvement

RE: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-09 Thread Bert Huijben
-Original Message- From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] Sent: maandag 9 augustus 2010 20:45 To: dev@subversion.apache.org Cc: stef...@apache.org Subject: Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c stef