Re: svn ls --search/pattern/glob/case-insensitive

2017-09-02 Thread Stefan Fuhrmann
On 01.09.2017 17:24, Julian Foad wrote: Stefan Sperling wrote: On Fri, Sep 01, 2017 at 03:01:33PM +0100, Julian Foad wrote: The above behaviour looks good to me. However, as you already pointed out, matching child path components seems to be impossible at present: $ svn ls -r3 --pattern '

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-02 Thread Stefan Fuhrmann
On 01.09.2017 15:31, Branko Čibej wrote: On 01.09.2017 06:36, Stefan Fuhrmann wrote: On 29.08.2017 14:04, Branko Čibej wrote: On 29.08.2017 13:28, Stefan Sperling wrote: On Tue, Aug 29, 2017 at 01:12:07PM +0200, Stefan Fuhrmann wrote: How would you implement the case-insensitive compariso

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Johan Corveleyn
On Fri, Sep 1, 2017 at 5:55 PM, Stefan Sperling wrote: > On Fri, Sep 01, 2017 at 04:24:28PM +0100, Julian Foad wrote: >> And, for consistency, when matching paths with "svn log -vq --search..." >> I would expect the same (I would not expect 'dog*' to match >> lazy_dog.txt). At present the implemen

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Stefan Sperling
On Fri, Sep 01, 2017 at 04:24:28PM +0100, Julian Foad wrote: > And, for consistency, when matching paths with "svn log -vq --search..." > I would expect the same (I would not expect 'dog*' to match > lazy_dog.txt). At present the implementation does match it, because it > treats the pattern as a su

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Julian Foad
Stefan Sperling wrote: > On Fri, Sep 01, 2017 at 03:01:33PM +0100, Julian Foad wrote: >> (I'm unsure exactly what you meant there, stsp -- that seems to >> contradict the previous paragraph, if 'svn log --search remains >> case-insensitive.) > > The most important point for me is that I don't thin

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Stefan Sperling
On Fri, Sep 01, 2017 at 03:01:33PM +0100, Julian Foad wrote: > (I'm unsure exactly what you meant there, stsp -- that seems to > contradict the previous paragraph, if 'svn log --search remains > case-insensitive.) The most important point for me is that I don't think appending and prepending * glo

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Julian Foad
Stefan Fuhrmann wrote: > On 01.09.2017 13:30, Stefan Sperling wrote: >> On Fri, Sep 01, 2017 at 06:36:46AM +0200, Stefan Fuhrmann wrote: >>> Because I think that strict glob-like patterns need to be supported >>> as well, I suggest to have two options: >>> >>> --search does a fuzzy search just

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Branko Čibej
On 01.09.2017 06:36, Stefan Fuhrmann wrote: > > > On 29.08.2017 14:04, Branko Čibej wrote: >> On 29.08.2017 13:28, Stefan Sperling wrote: >>> On Tue, Aug 29, 2017 at 01:12:07PM +0200, Stefan Fuhrmann wrote: How would you implement the case-insensitive comparison on the server side consist

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Stefan Fuhrmann
On 01.09.2017 13:30, Stefan Sperling wrote: On Fri, Sep 01, 2017 at 06:36:46AM +0200, Stefan Fuhrmann wrote: Because I think that strict glob-like patterns need to be supported as well, I suggest to have two options: --search does a fuzzy search just like we use it in other commands.

Re: svn ls --search/pattern/glob/case-insensitive

2017-09-01 Thread Stefan Sperling
On Fri, Sep 01, 2017 at 06:36:46AM +0200, Stefan Fuhrmann wrote: > Because I think that strict glob-like patterns need to be supported > as well, I suggest to have two options: > >--search does a fuzzy search just like we use it in other commands. > We implicitly add leading an tra

Re: svn ls --search/pattern/glob/case-insensitive

2017-08-31 Thread Stefan Fuhrmann
On 29.08.2017 14:04, Branko Čibej wrote: On 29.08.2017 13:28, Stefan Sperling wrote: On Tue, Aug 29, 2017 at 01:12:07PM +0200, Stefan Fuhrmann wrote: How would you implement the case-insensitive comparison on the server side consistent with the client-side locals? As far as I can tell the ut

Re: svn ls --search/pattern/glob/case-insensitive [was: svn commit: r1806548 ...]

2017-08-29 Thread Branko Čibej
On 29.08.2017 13:28, Stefan Sperling wrote: > On Tue, Aug 29, 2017 at 01:12:07PM +0200, Stefan Fuhrmann wrote: >> How would you implement the case-insensitive comparison >> on the server side consistent with the client-side locals? > As far as I can tell the utf8proc code which the client uses > fo

Re: svn ls --search/pattern/glob/case-insensitive [was: svn commit: r1806548 ...]

2017-08-29 Thread Stefan Sperling
On Tue, Aug 29, 2017 at 01:12:07PM +0200, Stefan Fuhrmann wrote: > How would you implement the case-insensitive comparison > on the server side consistent with the client-side locals? As far as I can tell the utf8proc code which the client uses for this is local-independent.

Re: svn ls --search/pattern/glob/case-insensitive [was: svn commit: r1806548 ...]

2017-08-29 Thread Stefan Fuhrmann
On 29.08.2017 12:46, Julian Foad wrote: Evgeny Kotkov wrote: Bert Huijben writes: As Julian discovered, '--search' as used with 'svn log' is may not suitable for 'svn ls'. File name matching should be case-sensitive and requires full patterns just like e.g. the ordinary unix command line 'l

svn ls --search/pattern/glob/case-insensitive [was: svn commit: r1806548 ...]

2017-08-29 Thread Julian Foad
Evgeny Kotkov wrote: > Bert Huijben writes: >>> As Julian discovered, '--search' as used with 'svn log' is may not suitable >>> for 'svn ls'. File name matching should be case-sensitive and requires >>> full patterns just like e.g. the ordinary unix command line 'ls' command. >>> >>> Therefore, i