Re: problems with serf

2010-09-09 Thread Lieven Govaerts
On Wed, Sep 8, 2010 at 9:06 PM, Lieven Govaerts svn...@mobsol.be wrote: On Wed, Sep 8, 2010 at 9:00 PM, Paul Burba ptbu...@gmail.com wrote: On Thu, May 27, 2010 at 2:42 AM, Lieven Govaerts svn...@mobsol.be wrote: Hi, On Mon, May 24, 2010 at 3:51 PM, Lieven Govaerts svn...@mobsol.be wrote: On

Re: [PATCH] Test case for issue #3471: svn up touches file w/ lock svn:keywords property

2010-09-09 Thread vijayaguru
On Thu, 2010-09-09 at 13:08 +0530, Senthil Kumaran S wrote: Hi Vijay, vijayaguru wrote: The attached patch adds a test case for issue #3471:svn up touches file w/ lock svn:keywords property and marking it as 'XFail' until the issue is fixed. Thanks for the patch. I reviewed it and I

Re: svnsync failure when syncing with a repository that used ISO-8859-1 for log messages

2010-09-09 Thread Daniel Shahaf
CC += dev@, and let me point you to our patch submission guidelines: http://subversion.apache.org/docs/community-guide/general.html#patches Summary for dev@: allow svnsync to translate non-UTF-8 log messages to UTF-8. (more below) Daniel Trebbien wrote on Wed, Sep 08, 2010 at 18:58:06 -0700:

Re: [PATCH] Test case for issue #3471: svn up touches file w/ lock svn:keywords property

2010-09-09 Thread Senthil Kumaran S
vijayaguru wrote: Thanks senthil. The attached patch tests the timestamp changes before and after svn up and raises failure if they are not same. [[[ Log: Add a test for issue #3471:'svn up touches file w/ lock svn:keywords property' * subversion/tests/cmdline/update_tests.py

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Daniel Shahaf
s...@apache.org wrote on Thu, Sep 09, 2010 at 11:31:13 -: + return svn_error_return( + svn_error_create(SVN_ERR_FS_CORRUPT, NULL, +_(Malformed representation header))); svn_error_return() isn't necessary here, since svn_error_create() has always

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 03:20:17PM +0300, Daniel Shahaf wrote: s...@apache.org wrote on Thu, Sep 09, 2010 at 11:31:13 -: + return svn_error_return( + svn_error_create(SVN_ERR_FS_CORRUPT, NULL, +_(Malformed representation header)));

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Sep 09, 2010 at 14:27:23 +0200: On Thu, Sep 09, 2010 at 03:20:17PM +0300, Daniel Shahaf wrote: s...@apache.org wrote on Thu, Sep 09, 2010 at 11:31:13 -: + return svn_error_return( + svn_error_create(SVN_ERR_FS_CORRUPT, NULL, +

Re: svn commit: r995383 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-09-09 Thread Stefan Sperling
On Thu, Sep 09, 2010 at 03:39:04PM +0300, Daniel Shahaf wrote: It might be good to make the rule 'return svn_error_*();' never needs svn_error_return() wrapper and fix the svn_error_* functions/macros that don't already record the file/line. +1

RE: svn commit: r995388 - /subversion/trunk/subversion/tests/cmdline/update_tests.py

2010-09-09 Thread Bert Huijben
-Original Message- From: style...@apache.org [mailto:style...@apache.org] Sent: donderdag 9 september 2010 13:47 To: comm...@subversion.apache.org Subject: svn commit: r995388 - /subversion/trunk/subversion/tests/cmdline/update_tests.py Author: stylesen Date: Thu Sep 9

Re: [PATCH] Test case for issue #3471: svn up touches file w/ lock svn:keywords property

2010-09-09 Thread Philip Martin
vijayaguru vi...@collab.net writes: +#-- +# Test for issue #3471 'svn up touches file w/ lock svn:keywords property' +# +# Marked as XFail until that issue is fixed. +def

Re: svnsync failure when syncing with a repository that used ISO-8859-1 for log messages

2010-09-09 Thread Daniel Shahaf
Daniel Trebbien wrote on Thu, Sep 09, 2010 at 08:48:43 -0700: On Thu, Sep 9, 2010 at 3:48 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Daniel Trebbien wrote on Wed, Sep 08, 2010 at 18:58:06 -0700: +          if (strcmp(propname, svn:log) == 0) +            { Should this use

Re: svn commit: r995478 [1/2] - in /subversion/branches/performance: ./ subversion/bindings/javahl/native/ subversion/bindings/javahl/src/org/apache/subversion/javahl/ subversion/bindings/javahl/src/o

2010-09-09 Thread Hyrum Wright
On Thu, Sep 9, 2010 at 10:59 AM, hwri...@apache.org wrote: Author: hwright Date: Thu Sep  9 15:59:00 2010 New Revision: 995478 URL: http://svn.apache.org/viewvc?rev=995478view=rev Log: On the performance branch: Bring up-to-date with trunk. ... Modified:

Re: svnsync failure when syncing with a repository that used ISO-8859-1 for log messages

2010-09-09 Thread Daniel Trebbien
On Thu, Sep 9, 2010 at 3:48 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: CC += dev@, and let me point you to our patch submission guidelines: http://subversion.apache.org/docs/community-guide/general.html#patches Summary for dev@: allow svnsync to translate non-UTF-8 log messages to UTF-8.

[RFC] 'base' is what in --accept=base?

2010-09-09 Thread Paul Burba
What do we expect 'svn merge --accept=base' to do when encountering text conflicts? While checking up on an old open issue (http://subversion.tigris.org/issues/show_bug.cgi?id=3514) I was surprised to find that base doesn't refer to the base of the merge target, but rather the base of the merge

Re: [serf-dev] Re: problems with serf

2010-09-09 Thread Lieven Govaerts
Hi Greg, On Thu, Sep 9, 2010 at 8:17 AM, Greg Stein gst...@gmail.com wrote: On Thu, Sep 9, 2010 at 02:05, Lieven Govaerts svn...@mobsol.be wrote: ... The solution I'm looking at now is to undo r1388, and solve the crashes in another way. Serf trunk 1408 solves this issue for me and for Paul.

Re: svn commit: r985037 - in /subversion/branches/performance/subversion: include/ libsvn_client/ libsvn_diff/ libsvn_fs_fs/ libsvn_ra_svn/ libsvn_repos/ libsvn_subr/ libsvn_wc/ svn/ svndumpfilter/ te

2010-09-09 Thread Hyrum K. Wright
On Thu, Aug 12, 2010 at 6:27 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Aug 12 23:27:40 2010 New Revision: 985037 URL: http://svn.apache.org/viewvc?rev=985037view=rev Log: The second (and probably last) mass change: svn_stringbuf_appendbytes has a relatively large runtime

Re: [serf-dev] Re: problems with serf

2010-09-09 Thread Greg Stein
On Thu, Sep 9, 2010 at 13:33, Lieven Govaerts svn...@mobsol.be wrote: Hi Greg, On Thu, Sep 9, 2010 at 8:17 AM, Greg Stein gst...@gmail.com wrote: On Thu, Sep 9, 2010 at 02:05, Lieven Govaerts svn...@mobsol.be wrote: ... The solution I'm looking at now is to undo r1388, and solve the crashes

RE: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

2010-09-09 Thread Bert Huijben
-Original Message- From: s...@apache.org [mailto:s...@apache.org] Sent: donderdag 9 september 2010 17:52 To: comm...@subversion.apache.org Subject: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c Author: stsp Date: Thu Sep 9 15:51:34 2010 New Revision:

Using packet loss to hunt the FSFS corruption

2010-09-09 Thread Daniel Shahaf
Morning Stefan, Per IRC today, I've run 'make davautocheck' while subjected to 5% packet loss (via iptables -A INPUT -i lo -p tcp -m tcp --dport 8088 \ -m statistic --mode random --probability 0.05 -j DROP), and while using a patch (attached) to run 'svnadmin setrevprop'

Re: Using packet loss to hunt the FSFS corruption

2010-09-09 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Sep 09, 2010 at 22:46:16 +0300: and while using a patch (attached) to run 'svnadmin setrevprop' concurrently to the tests. Index: subversion/tests/cmdline/svntest/testcase.py === ---

Buildbot for the atomic-revprop branch

2010-09-09 Thread Daniel Shahaf
I've went ahead and added the atomic-revprop branch to the buildbot's watched branches. (Apparently I missed some ra_serf breakage on the branch, and I can't run the 4-way tests every time.) If anyone has an issue with this change, please let me know. This was implemented last hour by gmcdonald

Re: Buildbot for the atomic-revprop branch

2010-09-09 Thread Hyrum K. Wright
On Thu, Sep 9, 2010 at 4:00 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: I've went ahead and added the atomic-revprop branch to the buildbot's watched branches.  (Apparently I missed some ra_serf breakage on the branch, and I can't run the 4-way tests every time.)  If anyone has an issue

Re: Buildbot for the atomic-revprop branch

2010-09-09 Thread Daniel Shahaf
Hyrum K. Wright wrote on Thu, Sep 09, 2010 at 16:09:53 -0500: On Thu, Sep 9, 2010 at 4:00 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: I've went ahead and added the atomic-revprop branch to the buildbot's watched branches.  (Apparently I missed some ra_serf breakage on the branch, and I

Re: svn commit: r995478 [1/2] - in /subversion/branches/performance: ./ subversion/bindings/javahl/native/ subversion/bindings/javahl/src/org/apache/subversion/javahl/ subversion/bindings/javahl/src/o

2010-09-09 Thread Stefan Fuhrmann
Hyrum Wright wrote: On Thu, Sep 9, 2010 at 10:59 AM, hwri...@apache.org wrote: Author: hwright Date: Thu Sep 9 15:59:00 2010 New Revision: 995478 URL: http://svn.apache.org/viewvc?rev=995478view=rev Log: On the performance branch: Bring up-to-date with trunk. ... Modified:

Re: svn commit: r985037 - in /subversion/branches/performance/subversion: include/ libsvn_client/ libsvn_diff/ libsvn_fs_fs/ libsvn_ra_svn/ libsvn_repos/ libsvn_subr/ libsvn_wc/ svn/ svndumpfilter/ te

2010-09-09 Thread Stefan Fuhrmann
Hyrum K. Wright hyrum_wright_at_mail.utexas.edu

Re: svn commit: r995478 [1/2] - in /subversion/branches/performance: ./ subversion/bindings/javahl/native/ subversion/bindings/javahl/src/org/apache/subversion/javahl/ subversion/bindings/javahl/src/o

2010-09-09 Thread Hyrum Wright
On Thu, Sep 9, 2010 at 4:34 PM, Stefan Fuhrmann stefanfuhrm...@alice-dsl.de wrote: Hyrum Wright wrote: On Thu, Sep 9, 2010 at 10:59 AM,  hwri...@apache.org wrote: Author: hwright Date: Thu Sep  9 15:59:00 2010 New Revision: 995478 URL: http://svn.apache.org/viewvc?rev=995478view=rev

atomic-revprop: help tracking down ra_serf failures

2010-09-09 Thread Daniel Shahaf
[ I'm only talking about the ra_serf tests in this email ] When I build the atomic-revprop branch against serf r1408, I see that: * diff_tests 24 29 (and many others [1]) fail with HEAD of the branch. (IIRC these two failures persist if I switch to serf ^/branches/0@head.) * diff_tests

Re: [PATCH] don't do autoprops on symbolic links

2010-09-09 Thread Gavin Beau Baumanis
Hi Everyone. This renewed patch has received no comments. Gavin Beau Baumanis On 04/09/2010, at 10:25 PM, Wei-Yin Chen wrote: Dear Gavin, Thanks. The attachment was in my sent box, but it's absent in the mailing archive. Don't know why. Per Branko's suggestion, I'm using join this

Re: [PATCH] Support command line options in svn_apply_autoprops.py

2010-09-09 Thread Gavin Beau Baumanis
Ping. This patch has received no comments. Gavin Beau Baumanis On 04/09/2010, at 11:43 PM, Wei-Yin Chen wrote: Sorry, don't know why the attachment was removed again. Does this mailing list have a strict Content-Type filter? I'm trying text/x-patch this time from my linux box. Type

Re: atomic-revprop: help tracking down ra_serf failures

2010-09-09 Thread Lieven Govaerts
On Fri, Sep 10, 2010 at 2:12 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: [ I'm only talking about the ra_serf tests in this email ] When I build the atomic-revprop branch against serf r1408, I see that: * diff_tests 24 29 (and many others [1]) fail with HEAD of the branch.    (IIRC