Re: svn commit: r1767194 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2016-11-05 Thread Stefan Fuhrmann
On 31.10.2016 01:19, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Oct 30, 2016 at 22:30:19 -: Author: stefan2 Date: Sun Oct 30 22:30:19 2016 New Revision: 1767194 URL: http://svn.apache.org/viewvc?rev=1767194&view=rev Log: Close a gap in the ra_svn protocol engine: Boolean elements

Re: mod_authz_svn and caching

2016-11-05 Thread Stefan Fuhrmann
Hi Hans, Thanks for the issue report! There seem to be two independent approaches that we could take to address the problem -- see below. On 05.11.2016 00:19, Hans van Kranenburg wrote: (please keep me in Cc: since I'm not on the list (yet)) Hi, We recently switched from using a htgroup file

Re: svn commit: r1767197 - in /subversion/trunk/subversion: include/private/svn_log.h include/svn_ra_svn.h libsvn_ra_svn/client.c libsvn_ra_svn/protocol libsvn_subr/log.c svnserve/serve.c

2016-11-05 Thread Stefan Fuhrmann
On 31.10.2016 01:45, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Oct 30, 2016 at 23:43:07 -: Author: stefan2 Date: Sun Oct 30 23:43:06 2016 New Revision: 1767197 URL: http://svn.apache.org/viewvc?rev=1767197&view=rev [snip] + list +params: ( path:string [ rev:number ] d

Re: mod_authz_svn and caching

2016-11-05 Thread Hans van Kranenburg
Hi Stefan, Thanks for the quick reply. On 11/05/2016 11:44 AM, Stefan Fuhrmann wrote: > > Thanks for the issue report! There seem to be two independent > approaches that we could take to address the problem -- see below. > > On 05.11.2016 00:19, Hans van Kranenburg wrote: >> (please keep me in

Re: mod_authz_svn and caching

2016-11-05 Thread Daniel Shahaf
Hans van Kranenburg wrote on Sat, Nov 05, 2016 at 16:39:44 +0100: > On 11/05/2016 11:44 AM, Stefan Fuhrmann wrote: > > Looking at your workaround, I think the cleanest solution would be to > > introduce an AuthzSVNDisableCache option. I'm not sure a knob to _disable_ caching is the right approach.

Re: svn commit: r1767197 - in /subversion/trunk/subversion: include/private/svn_log.h include/svn_ra_svn.h libsvn_ra_svn/client.c libsvn_ra_svn/protocol libsvn_subr/log.c svnserve/serve.c

2016-11-05 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sat, Nov 05, 2016 at 13:52:49 +0100: > On 31.10.2016 01:45, Daniel Shahaf wrote: > >stef...@apache.org wrote on Sun, Oct 30, 2016 at 23:43:07 -: > >>+dirent: ( rel-path:string kind:node-kind ? ( size:number > >>+has-props:bool created-rev:number >

Re: mod_authz_svn and caching

2016-11-05 Thread Hans van Kranenburg
On 11/05/2016 05:15 PM, Daniel Shahaf wrote: > Hans van Kranenburg wrote on Sat, Nov 05, 2016 at 16:39:44 +0100: >> On 11/05/2016 11:44 AM, Stefan Fuhrmann wrote: >>> Looking at your workaround, I think the cleanest solution would be to >>> introduce an AuthzSVNDisableCache option. > > I'm not sur

Re: mod_authz_svn and caching

2016-11-05 Thread Daniel Shahaf
Hans van Kranenburg wrote on Sat, Nov 05, 2016 at 17:51:13 +0100: > On 11/05/2016 05:15 PM, Daniel Shahaf wrote: > > Hans van Kranenburg wrote on Sat, Nov 05, 2016 at 16:39:44 +0100: > >> On 11/05/2016 11:44 AM, Stefan Fuhrmann wrote: > >> I also guess that ideally the tests need to be updated with

Re: svn commit: r1767197 - in /subversion/trunk/subversion: include/private/svn_log.h include/svn_ra_svn.h libsvn_ra_svn/client.c libsvn_ra_svn/protocol libsvn_subr/log.c svnserve/serve.c

2016-11-05 Thread Stefan Fuhrmann
On 05.11.2016 17:41, Daniel Shahaf wrote: Stefan Fuhrmann wrote on Sat, Nov 05, 2016 at 13:52:49 +0100: On 31.10.2016 01:45, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Oct 30, 2016 at 23:43:07 -: +dirent: ( rel-path:string kind:node-kind ? ( size:number +ha

Re: svn commit: r1767197 - in /subversion/trunk/subversion: include/private/svn_log.h include/svn_ra_svn.h libsvn_ra_svn/client.c libsvn_ra_svn/protocol libsvn_subr/log.c svnserve/serve.c

2016-11-05 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sat, Nov 05, 2016 at 22:01:03 +0100: > On 05.11.2016 17:41, Daniel Shahaf wrote: > >Stefan Fuhrmann wrote on Sat, Nov 05, 2016 at 13:52:49 +0100: > >>On 31.10.2016 01:45, Daniel Shahaf wrote: > >>>stef...@apache.org wrote on Sun, Oct 30, 2016 at 23:43:07 -: > +d

ra_svn vwrite_tuple() optional elements robustness

2016-11-05 Thread Daniel Shahaf
During the r1767197 thread, I noticed that vwrite_tuple() doesn't enforce its precondition that in the optional part of a tuple, either all values are valid or no value is; a call such as vwrite_tuple("(?r?r)", SVN_INVALID_REVNUM, (svn_revnum_t) 42) would happily generate a «( 42 ) » tuple, i