Re: [PATCH] Re: SVN-4783 KWallet assumes KDE5 when Qt5 present

2018-11-23 Thread Julian Foad
Satya Mishra wrote on 2018-11-19: > As requested in the bug report, here’s a patch that doesn’t hard-code > the path to kf5-config, but instead assumes it’s in the path. Thanks! It looks plausible to me. Is anyone here able to test and commit it? SVN-4783:

Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error

2018-11-23 Thread Julian Foad
Daniel Shahaf wrote: > Julian Foad wrote on Wed, 21 Nov 2018 16:00 +: > > In reviewing the code I was unable to keep track of all the nuances of > > what happens (and should happen) in all the edge cases. Especially when > > 'flags & open_path_allow_null' is true and the requested path is a

Re: svn commit: r1847181 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

2018-11-23 Thread Julian Foad
Branko Čibej wrote: > This is broken. You replaced the UnorderedOutput comparator with a > simple array of lines, causing test failures like this: > > https://ci.apache.org/builders/svn-x64-macosx-bdb/builds/3968/steps/Test%20ra_local%2Bbdb/logs/faillog Thanks. Fixed in 1847264. Backport

Re: svn commit: r1847184 - /subversion/branches/1.11.x/STATUS

2018-11-23 Thread Julian Foad
Daniel Shahaf wrote: > Add r1847188 to the nomination? Done. Thanks. -- - Julian

Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error

2018-11-23 Thread Daniel Shahaf
Julian Foad wrote on Fri, 23 Nov 2018 13:56 +: > Daniel Shahaf wrote: > > Julian Foad wrote on Wed, 21 Nov 2018 16:00 +: > > > In reviewing the code I was unable to keep track of all the nuances of > > > what happens (and should happen) in all the edge cases. Especially when > > > 'flags

truncated author names in 'svn ls -v' output

2018-11-23 Thread Stefan Sperling
I would like make a change, but it is a highly bikesheddy one so I'd rather ask the list first to give everyone a chance to suggest their favourite colours. The length of author names in 'svn ls -v' output is currently truncated at 8 columns. Things have been this way since the dawn of time:

Re: truncated author names in 'svn ls -v' output

2018-11-23 Thread Branko Čibej
On 23.11.2018 09:10, Stefan Sperling wrote: > I would like make a change, but it is a highly bikesheddy one so > I'd rather ask the list first to give everyone a chance to suggest > their favourite colours. > > The length of author names in 'svn ls -v' output is currently truncated > at 8 columns.

Re: truncated author names in 'svn ls -v' output

2018-11-23 Thread Daniel Shahaf
Branko Čibej wrote on Fri, 23 Nov 2018 10:15 +0100: > On 23.11.2018 09:10, Stefan Sperling wrote: > > I would like make a change, but it is a highly bikesheddy one so > > I'd rather ask the list first to give everyone a chance to suggest > > their favourite colours. > > > > The length of author

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-11-23 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Nov 23, 2018 at 16:43:24 +0900: > On 11/23/18 11:21 AM, Daniel Shahaf wrote: > > Thanks for the patch. I'm afraid I'm a bit disoriented, though; could > > you kindly clarify a few things? > > > > Is the patch destined for trunk, for branches/swig-py3@HEAD, or for

Re: truncated author names in 'svn ls -v' output

2018-11-23 Thread Branko Čibej
On 23.11.2018 10:40, Daniel Shahaf wrote: > Branko Čibej wrote on Fri, 23 Nov 2018 10:15 +0100: >> On 23.11.2018 09:10, Stefan Sperling wrote: >>> I would like make a change, but it is a highly bikesheddy one so >>> I'd rather ask the list first to give everyone a chance to suggest >>> their