Re: Plumbing work to make shelving complete and robust

2018-08-24 Thread Nathan Hartman
On Fri, Aug 24, 2018 at 12:26 PM Julian Foad wrote: > Only by implementing more than one edit driver for each editor (and vice > versa) can we prove that the components are cleanly separated by an API and > thus re-usable. > > Then there is the need for a test framework that can generate all >

Re: Plumbing work to make shelving complete and robust

2018-08-24 Thread Julian Foad
Julian Foad wrote: > [...] There are > currently two implementations of a "dump" editor and neither is > immediately usable. The one in "svnadmin dump" is not written as a clean > editor, and instead calls directly into the FS layer to fetch its data. > The one in "svnrdump" is clean but does

Buildbots: require Python-SQLite v3.8.2 [was: FSFS recovery should prune rep-cache even if its use is disabled]

2018-08-24 Thread Julian Foad
Brane, this one's yours: https://ci.apache.org/buildslaves/svn-x64-macosx-dgvrs The new tests for #4077 are failing on at least this buildbot-slave. "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, 13) < (3,8,2)" (danielsh says: the magic number 3.8.2 is the minimum

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Daniel Shahaf
Julian Foad wrote on Fri, 24 Aug 2018 12:17 +0100: > Julian Foad: > > Committed in http://svn.apache.org/r1838813 > > And nominated for backport to 1.10.x and 1.9.x. > > The tests are failing on some buildbots: > > "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, > 13) <

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Julian Foad
Julian Foad: > Committed in http://svn.apache.org/r1838813 And nominated for backport to 1.10.x and 1.9.x. The tests are failing on some buildbots: "Can't read rep-cache schema 2 using old Python-SQLite version (3, 7, 13) < (3,8,2)" If we're using SQLite and want to have tests written in

Re: FSFS recovery should prune rep-cache even if its use is disabled

2018-08-24 Thread Julian Foad
Daniel Shahaf wrote: > Julian Foad wrote on Thu, Aug 23, 2018 at 10:21:17 +0100: > > +++ subversion/libsvn_fs_fs/recovery.c (working copy) > > @@ -468,15 +468,15 @@ recover_body(void *baton, apr_pool_t *po > >/* Prune younger-than-(newfound-youngest) revisions from the rep > > - cache