Python tests segfault with SWIG 4.1.0
Hi, I am testing rebuild of SWIG dependencies against upcoming version 4.1.0 in Fedora rawhide/38. The build of subversion-1.14.2 is failing with this version. + make check-swig-py mkdir /builddir/build/BUILD/subversion-1.14.2/subversion/bindings/swig/python/libsvn if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in /builddir/build/BUILD/subversion-1.14.2/subversion/bindings/swig/python/libsvn_swig_py /builddir/build/BUILD/subversion-1.14.2/subversion/bindings/swig/python/../../../libsvn_*; do if [ -n "$DYLD_LIBRARY_PATH" ]; then LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; \ cd /builddir/build/BUILD/subversion-1.14.2/subversion/bindings/swig/python; \ /usr/bin/python3 /builddir/build/BUILD/subversion-1.14.2/subversion/bindings/swig/python/tests/run_all.py RPM build errors: make: *** [Makefile:947: check-swig-py] Segmentation fault (core dumped) + : Python swig test failure. + exit 1 I reported it to swig upstream https://github.com/swig/swig/issues/2373 and got answer that it is related to change "Remove -py3 command line option" https://github.com/swig/swig/commit/a343b7e254567a64761bc1be7dc55b7b7424ec52 Recommended fix works. https://github.com/swig/swig/issues/2373#issuecomment-1250997124 Successful build with swig 4.1.0 https://copr.fedorainfracloud.org/coprs/jplesnik/swig-rebuild/build/4863479/ Regards, Jitka -- Jitka Plesnikova Senior Software Engineer Red Hat
Re: [BUG] "svn propedit" loses changes in case of a network failure
A thing I forgot to write On 2022/09/19 15:09, Yasuhito FUTATSUKI wrote: > On 2022/09/19 11:37, Vincent Lefevre wrote: >> On 2022-09-19 11:02:05 +0900, Yasuhito FUTATSUKI wrote: > I wrote the second paragraph just for to show where the behaivor > comes from, i.e. where to fix, who want to fix it, and for there > information to write a regression test. If you want to write a patch, the code in svn_cl__cleanup_log_msg() in subversion/svn/util.c may be helpful, for handling error. https://svn.apache.org/viewvc/subversion/trunk/subversion/svn/util.c?revision=1849190=markup#l256 Cheers, -- Yasuhito FUTATSUKI
Re: [BUG] "svn propedit" loses changes in case of a network failure
On 2022/09/19 11:37, Vincent Lefevre wrote: > On 2022-09-19 11:02:05 +0900, Yasuhito FUTATSUKI wrote: >> I can't determine whether this behavior is a bug or not. >> >> As svn_cl__propedit() calls svn_cmdline__edit_string_externally()[1] >> for editing revprop value string with the parameter tempfail_reft is >> NULL[2], the temporary file is removed within the function >> svn_cmdline__edit_string_externally(), before trying to set the new >> value. So, it can be reproduced in any scheme, even "file" scheme, >> by rejecting the change of revprop values in pre-revprop-change >> hook. > > Well, if the pre-revprop-change hook rejects the change, this may > not be a bug, though I think that the new file should really be kept > somewhere. AFAIK, the svn-commit.tmp file (log message) is kept for > a rejected commit, so I don't see why this should be different. > > But here, this is not a rejection due to a hook, but a failure due to > some external cause, on which the user has no control (contrary to a > hook). Ah, second paragraph is not the reason why I can't see that it is bug or not. It is just I don't see why the author wrote a such code. I am still neutral. I wrote the second paragraph just for to show where the behaivor comes from, i.e. where to fix, who want to fix it, and for there information to write a regression test. Cheers, -- Yasuhito FUTATSUKI
