Re: -bytes branch reports bogus conflict that trunk doesn't

2011-01-02 Thread Johan Corveleyn
On Sun, Jan 2, 2011 at 8:19 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Sun, Jan 02, 2011 at 20:13:59 +0100: >> On Sun, Jan 2, 2011 at 7:36 PM, Daniel Shahaf wrote: >> > Johan, >> > >> > I saw your sync merge, so I ran 'svn up' with intent t

Re: My take on the diff-optimizations-bytes branch

2011-01-02 Thread Johan Corveleyn
On Sat, Jan 1, 2011 at 11:25 PM, Stefan Fuhrmann wrote: > Hi Johan, > > Thursday night I did something stupid and had a look at  how > svn blame could be made faster based on the HEAD code in > your branch. > > One night and most of the following day later, I think I made it > a few percent faster

Re: My take on the diff-optimizations-bytes branch

2011-01-02 Thread Johan Corveleyn
On Sun, Jan 2, 2011 at 10:04 PM, Johan Corveleyn wrote: > On Sat, Jan 1, 2011 at 11:25 PM, Stefan Fuhrmann > wrote: >> Hi Johan, >> >> Thursday night I did something stupid and had a look at  how >> svn blame could be made faster based on the HEAD code in >> y

Re: My take on the diff-optimizations-bytes branch

2011-01-02 Thread Johan Corveleyn
On Mon, Jan 3, 2011 at 12:13 AM, Johan Corveleyn wrote: > On Sun, Jan 2, 2011 at 10:04 PM, Johan Corveleyn wrote: >> On Sat, Jan 1, 2011 at 11:25 PM, Stefan Fuhrmann >> wrote: >>> Hi Johan, >>> >>> Thursday night I did something stupid and had a look

Re: My take on the diff-optimizations-bytes branch

2011-01-03 Thread Johan Corveleyn
On Mon, Jan 3, 2011 at 12:03 PM, Stefan Fuhrmann wrote: > On 03.01.2011 02:14, Johan Corveleyn wrote: >> >> On Mon, Jan 3, 2011 at 12:13 AM, Johan Corveleyn >>  wrote: >>> [... snip ...] >>> And it's fast too! It's taking only 58 seconds in &qu

Bringing diff options of svnlook on par with svn?

2011-01-05 Thread Johan Corveleyn
Hi, I'm wondering why svnlook doesn't support the same diff options (-x flags or others) as svn does. Is it just a question of tuits? Or there some specific reason why "svnlook diff" doesn't support '-x-p' (--show-c-function) and the new '--git'? If the answer is "tuits", I'd like to give it a sh

Re: diff-optimizations-bytes: how to make diff3 work with prefix/suffix scanning

2011-01-05 Thread Johan Corveleyn
On Wed, Jan 5, 2011 at 12:11 PM, Julian Foad wrote: > On Sat, 2011-01-01, Johan Corveleyn wrote: >> [ Taking a privately-started discussion with danielsh to the list, in >> case others have inspiration/insight about this. Question at hand: I'm >> having trouble mak

Diff optimizations and generating big test files (was: Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?))

2011-01-05 Thread Johan Corveleyn
On Wed, Jan 5, 2011 at 2:17 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Another question: a shell script might not be good, because not >> portable (and not fast)? Should I use python for this? Maybe the >> "write line by line with a line number

Re: svn commit: r1054701 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp EnumMapper.cpp ListCallback.cpp Revision.cpp RevisionRange.cpp StatusCallback.cpp org_apa

2011-01-10 Thread Johan Corveleyn
On Mon, Jan 3, 2011 at 7:34 PM, wrote: > Author: hwright > Date: Mon Jan  3 18:34:35 2011 > New Revision: 1054701 > > URL: http://svn.apache.org/viewvc?rev=1054701&view=rev > Log: > Fix JavaHL build and test failures introduced in r1054680. > > * subversion/bindings/javahl/native/CreateJ.cpp, >  

Re: svn commit: r1054701 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp EnumMapper.cpp ListCallback.cpp Revision.cpp RevisionRange.cpp StatusCallback.cpp org_apa

2011-01-10 Thread Johan Corveleyn
On Mon, Jan 10, 2011 at 11:59 PM, Hyrum Wright wrote: > On Mon, Jan 10, 2011 at 4:07 PM, Johan Corveleyn wrote: >> On Mon, Jan 3, 2011 at 7:34 PM,   wrote: >>> Author: hwright >>> Date: Mon Jan  3 18:34:35 2011 >>> New Revision: 1054701 >>> >>&

Re: Diff optimizations and generating big test files

2011-01-16 Thread Johan Corveleyn
On Wed, Jan 5, 2011 at 4:33 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Thanks for the script, it gives me some good inspiration. >> >> However, it doesn't fit well with the optimization that's currently >> being done on the diff-optimization

Re: My take on the diff-optimizations-bytes branch

2011-01-16 Thread Johan Corveleyn
On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann wrote: > On 03.01.2011 02:14, Johan Corveleyn wrote: >> >> On Mon, Jan 3, 2011 at 12:13 AM, Johan Corveleyn >>  wrote: >>> >>> On Sun, Jan 2, 2011 at 10:04 PM, Johan Corveleyn >>>  wrote: &g

Re: Coding goals / requirements.

2011-01-18 Thread Johan Corveleyn
Hi, As the guy responsible for the quote that started this thread ([1]): > Actually, what's a little bit troubling is that there are currently > only 3 possible "file_len's", of which only 2 are used in practice: > diff2 and diff3 (diff4 is not used in svn core, only in > tools/diff/diff4). So, i

Re: My take on the diff-optimizations-bytes branch

2011-01-18 Thread Johan Corveleyn
On Mon, Jan 17, 2011 at 3:12 AM, Johan Corveleyn wrote: > On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann > wrote: [ ... snip ... ] >> But I think, the stack variable is certainly helpful >> and easy to do. Ok, I've done this (locally, still have to clean up a litt

Re: My take on the diff-optimizations-bytes branch

2011-01-22 Thread Johan Corveleyn
On Wed, Jan 19, 2011 at 1:19 AM, Stefan Fuhrmann wrote: > On 18.01.2011 12:56, Johan Corveleyn wrote: >> >> On Mon, Jan 17, 2011 at 3:12 AM, Johan Corveleyn >>  wrote: >>> >>> On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann >>>  wrote: >&

Re: My take on the diff-optimizations-bytes branch

2011-01-23 Thread Johan Corveleyn
On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann wrote: > On 03.01.2011 02:14, Johan Corveleyn wrote: >> It would be interesting to see where the biggest gains >> are coming from (I'm guessing from the "per-machine-word" >> reading/comparing; I'd like t

Re: My take on the diff-optimizations-bytes branch

2011-01-23 Thread Johan Corveleyn
On Sun, Jan 23, 2011 at 10:46 PM, Johan Corveleyn wrote: > On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann > wrote: >> On 03.01.2011 02:14, Johan Corveleyn wrote: >>> It would be interesting to see where the biggest gains >>> are coming from (I'm guessing from

Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-01-23 Thread Johan Corveleyn
Hi, Already for some time now, update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir) crashes on my machine: svn: In file '..\..\..\subversion\libsvn_wc\update_editor.c' line 4877: assertion failed (repos_root != NULL && repos_uuid != NULL) I understand that this test is XFAI

Re: FSFS format 6

2011-01-23 Thread Johan Corveleyn
On Wed, Dec 29, 2010 at 8:37 PM, Stefan Fuhrmann wrote: > On 29.12.2010 01:58, Johan Corveleyn wrote: >> >> On Sun, Dec 12, 2010 at 4:23 PM, Stefan Fuhrmann >>  wrote: >>> >>> On 19.10.2010 15:10, Daniel Shahaf wrote: >>>> >>&

Re: My take on the diff-optimizations-bytes branch

2011-01-25 Thread Johan Corveleyn
On Tue, Jan 25, 2011 at 1:37 AM, Stefan Fuhrmann wrote: [ ... snip ...] > And, as promised, here some ideas how to get more > speed from the generic code. Your latest commit: > > +#if SVN_UNALIGNED_ACCESS_IS_OK > + > +      /* Skip quickly over the stuff between EOLs. */ > +      for (i = 0, can_r

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Johan Corveleyn
On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: > Johan (and other interested parties), > I've been following some of the commits to the > diff-optimizations-branch with interest.  While I've not reviewed them > for technical merit, it appears that others have, and that there is > good work

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 2:46 PM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 11:41 PM, Daniel Shahaf > wrote: >> Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: >>> Revving svn_diff_fns_t: what do you mean with parallelizing it? I must >>> admit

Re: Merging /branches/integrate-cache-membuffer to /trunk

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 11:42 PM, Stefan Sperling wrote: > On Wed, Jan 26, 2011 at 11:25:59PM +0100, Stefan Fuhrmann wrote: >> Hi @all, >> >> I'm planning to merge said branch Monday 7th. >> Speak now or forever hold your peace. >> >> Rationale: >> >> I've been testing / using that code for a whil

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 7:18 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, Jan 26, 2011 at 15:18:24 +0100: >> - The only internal caller of the "old" function 'datasource_open' >> (for a single datasource) doesn't call it anymore >> (t

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Johan Corveleyn
On Wed, Jan 26, 2011 at 10:50 PM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: > ... >>>  * revv svn_diff.h#svn_diff_fns_t             [] >>> >>> It looks like, for the most part, any destabilizing functionality is >>&

Re: Regarding issue 3690

2011-01-27 Thread Johan Corveleyn
On Thu, Jan 27, 2011 at 8:04 AM, Noorul Islam K M wrote: > Hi, > > I am planning to work on issue 3690. Before starting with this I have > few questions. > > 1. Hyrum updated the issue with his comment stating that already there >   is work going on in the branch ignore-mergeinfo which addresses >

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Johan Corveleyn
On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright wrote: > Johan, > I'd appreciate review on the attached patch.  It is an attempt to rev > the svn_diff_fns_t struct and related functions.  You'll notice that I > commented out the use of datasources_open in both diff_file.c and > diff_memory.c, in a

Re: Merging /branches/integrate-cache-membuffer to /trunk

2011-01-27 Thread Johan Corveleyn
On Thu, Jan 27, 2011 at 11:58 PM, Stefan Fuhrmann wrote: > On 27.01.2011 01:56, Johan Corveleyn wrote: >> >> On Wed, Jan 26, 2011 at 11:42 PM, Stefan Sperling  wrote: >>> >>> On Wed, Jan 26, 2011 at 11:25:59PM +0100, Stefan Fuhrmann wrote: >>>> >&

Re: Status of the branch diff-optimizations-bytes branch

2011-01-28 Thread Johan Corveleyn
On Fri, Jan 28, 2011 at 5:51 AM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >> On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright >> wrote: >>> Johan (and other interested parties), >>> I've been following some of the

Re: diff4-optimization-bytes

2011-01-28 Thread Johan Corveleyn
On Fri, Jan 28, 2011 at 9:29 AM, Daniel Shahaf wrote: > Johan, > > I'm concerned about this change: on the one hand, it's untested and > no one claims to be understanding the code; on the other hand, it > doesn't exactly parallel the diff3 change: > > specifically, the last hunk of the diff3 patch

Re: svn commit: r1065170 - in /subversion/branches/diff-optimizations-bytes/subversion/libsvn_diff: diff_file.c lcs.c

2011-01-30 Thread Johan Corveleyn
Hi Daniel, Thanks for taking a look. However ... On Sun, Jan 30, 2011 at 4:17 AM, wrote: > Author: danielsh > Date: Sun Jan 30 03:17:54 2011 > New Revision: 1065170 > > URL: http://svn.apache.org/viewvc?rev=1065170&view=rev > Log: > On the 'diff-optimizations-bytes' branch: > > Silence compiler

Re: diff4-optimization-bytes

2011-01-30 Thread Johan Corveleyn
On Fri, Jan 28, 2011 at 7:58 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Fri, Jan 28, 2011 at 14:04:07 +0100: >> On Fri, Jan 28, 2011 at 9:29 AM, Daniel Shahaf >> wrote: >> > May I suggest that, if this code is to be released, then you validate >> >

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Mon, Jan 24, 2011 at 3:21 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Mon, Jan 24, 2011 at 02:42:11 +0100: >> Hi, >> >> Already for some time now, update_tests.py 58 (XFAIL: update a >> nonexistent child of a copied dir) crashes on my mach

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Tue, Feb 1, 2011 at 3:08 PM, Bert Huijben wrote: > > >> -Original Message----- >> From: Johan Corveleyn [mailto:jcor...@gmail.com] >> Sent: dinsdag 1 februari 2011 13:28 >> To: Daniel Shahaf >> Cc: Subversion Development >> Subject: Re: Assertio

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Tue, Feb 1, 2011 at 10:10 PM, Johan Corveleyn wrote: > On Tue, Feb 1, 2011 at 3:08 PM, Bert Huijben wrote: >> >> >>> -Original Message- >>> From: Johan Corveleyn [mailto:jcor...@gmail.com] >>> Sent: dinsdag 1 februari 2011 13:28 >>&g

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-03 Thread Johan Corveleyn
On Wed, Feb 2, 2011 at 7:38 AM, Lieven Govaerts wrote: > Johan, > > On Tue, Feb 1, 2011 at 11:16 PM, Johan Corveleyn wrote: >> >> On Tue, Feb 1, 2011 at 10:10 PM, Johan Corveleyn >> wrote: >> > it continues until test nr 58, and then gives the popup. >

Re: Windows Makefile (was: Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir))

2011-02-03 Thread Johan Corveleyn
On Wed, Feb 2, 2011 at 5:53 AM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Tue, Feb 01, 2011 at 13:28:24 +0100: >> So: I've tried removing SVN_USE_WIN32_CRASHHANDLER from gen_win.py >> (put it in comment, ran "nmake config" and rebuilt everything), then >

Re: diff4-optimization-bytes

2011-02-04 Thread Johan Corveleyn
On Fri, Feb 4, 2011 at 7:56 AM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Mon, Jan 31, 2011 at 02:47:50 +0100: >> On Fri, Jan 28, 2011 at 7:58 PM, Daniel Shahaf >> wrote: >> > Johan Corveleyn wrote on Fri, Jan 28, 2011 at 14:04:07 +0100: >> >> On

Re: SQLite and callbacks

2011-02-05 Thread Johan Corveleyn
On Sat, Feb 5, 2011 at 7:14 PM, Stefan Sperling wrote: > On Sat, Feb 05, 2011 at 06:47:35PM +0100, Branko Čibej wrote: >> I would not worry about existing clients -- simply mark the existing >> APIs as deprecated, but keep them and do not attempt to improve their >> performance. > > Neglecting per

Re: SQLite and callbacks

2011-02-05 Thread Johan Corveleyn
On Sat, Feb 5, 2011 at 9:37 PM, Johan Corveleyn wrote: > On Sat, Feb 5, 2011 at 7:14 PM, Stefan Sperling wrote: >> On Sat, Feb 05, 2011 at 06:47:35PM +0100, Branko Čibej wrote: >>> I would not worry about existing clients -- simply mark the existing >>> APIs as depre

Re: Review results of diff-optimizations-bytes branch

2011-02-06 Thread Johan Corveleyn
On Sun, Feb 6, 2011 at 9:19 PM, Stefan Fuhrmann wrote: > Hi Johan, > > I just finished the review of the changes on your branch. > Except for a few minor hints, everything looks fine and > should be merged to /trunk. The two findings can be > addressed on /trunk directly. Thanks. Reintegrated it

Re: Cannot get the revision information from the scm repository :

2011-02-07 Thread Johan Corveleyn
Please do not cross-post between users@ and dev@. This is really a usage question (not about the development of subversion), so belongs on users@. [ I've left dev@ in cc for this one reply, please drop it from further replies. ] More below ... On Mon, Feb 7, 2011 at 6:45 AM, Vishal Jain wrote:

Buildbots failing after reintegration of diff-optimizations-bytes

2011-02-07 Thread Johan Corveleyn
Apparently I broke the builds on the builtbots yesterday evening, after integrating the diff-optimizations-bytes branch. Sorry for that. There were two problems: - Failing diff-diff3-test.exe (actually hanging). This was rectified in r1067839. - Failing (python) bindings. I could use some help wi

Re: Buildbots failing after reintegration of diff-optimizations-bytes

2011-02-07 Thread Johan Corveleyn
On Mon, Feb 7, 2011 at 4:12 PM, Hyrum K Wright wrote: > On Mon, Feb 7, 2011 at 3:07 PM, Hyrum K Wright wrote: >> On Mon, Feb 7, 2011 at 12:10 PM, Philip Martin >> wrote: >>> Johan Corveleyn writes: >>> >>>> Apparently I broke the builds o

Re: SQLite and callbacks

2011-02-07 Thread Johan Corveleyn
On Mon, Feb 7, 2011 at 5:28 PM, Stefan Sperling wrote: > On Mon, Feb 07, 2011 at 05:18:57PM +0100, Stefan Sperling wrote: >> On Mon, Feb 07, 2011 at 10:55:47AM -0500, Mark Phippard wrote: >> > On Mon, Feb 7, 2011 at 10:52 AM, Stefan Sperling wrote: >> > >> > > Where is the temporary table stored?

Re: svn_diff.h truncated

2011-02-08 Thread Johan Corveleyn
On Tue, Feb 8, 2011 at 1:28 PM, Daniel Shahaf wrote: > I ran into this while trying to 'svn up' today, and managed to reproduce > it in another working copy: > > % svn revert -R . > % cat ./before > Index: subversion/include/svn_diff.h >

Re: svn_diff.h truncated

2011-02-08 Thread Johan Corveleyn
On Tue, Feb 8, 2011 at 9:01 PM, Johan Corveleyn wrote: > On Tue, Feb 8, 2011 at 1:28 PM, Daniel Shahaf wrote: >> I ran into this while trying to 'svn up' today, and managed to reproduce >> it in another working copy: >> >> % svn revert -R . >>

Re: svn_diff.h truncated

2011-02-08 Thread Johan Corveleyn
On Tue, Feb 8, 2011 at 10:50 PM, Stefan Sperling wrote: > On Tue, Feb 08, 2011 at 10:45:03PM +0100, Johan Corveleyn wrote: >> On Tue, Feb 8, 2011 at 9:01 PM, Johan Corveleyn wrote: >> > On Tue, Feb 8, 2011 at 1:28 PM, Daniel Shahaf >> > wrote: >> >>

Re: svn_diff.h truncated

2011-02-08 Thread Johan Corveleyn
On Tue, Feb 8, 2011 at 11:19 PM, Johan Corveleyn wrote: > On Tue, Feb 8, 2011 at 10:50 PM, Stefan Sperling wrote: >> On Tue, Feb 08, 2011 at 10:45:03PM +0100, Johan Corveleyn wrote: >>> On Tue, Feb 8, 2011 at 9:01 PM, Johan Corveleyn wrote: >>> > On Tue, Feb 8,

Re: svn_diff.h truncated

2011-02-08 Thread Johan Corveleyn
Try sending a mail to dev-unsubscr...@subversion.apache.org Johan On Tue, Feb 8, 2011 at 11:28 PM, Stimely, Noelle wrote: > How do I unsubscribe to this group? > > Thanks... > > Noelle > > > -Original Message- > From: Johan Corveleyn [mailto:jcor...@gmail.com

Re: diff4-optimization-bytes

2011-02-08 Thread Johan Corveleyn
On Wed, Feb 9, 2011 at 4:54 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Tue, Feb 08, 2011 at 21:47:12 -0600: >> On Tue, Feb 8, 2011 at 9:26 PM, Daniel Shahaf >> wrote: >> > Johan Corveleyn wrote on Fri, Feb 04, 2011 at 13:20:29 +0100: >> >> On Fri, F

Re: diff4-optimization-bytes

2011-02-09 Thread Johan Corveleyn
On Wed, Feb 9, 2011 at 10:20 AM, Daniel Shahaf wrote: > In other news, I looked into the cause --- tried to make > datasource_get_next_token() do one more loop in the place where > currently it does 'return if at_start_of_suffix()' --- but that didn't > fix the truncation... Indeed, that won't fi

Re: Integrating further changes from the performance branch

2011-02-11 Thread Johan Corveleyn
On Fri, Feb 11, 2011 at 11:10 AM, Ivan Zhakov wrote: > On Fri, Feb 11, 2011 at 03:51, Stefan Fuhrmann wrote: >> On 10.02.2011 22:15, Ivan Zhakov wrote: >>> >>> On Thu, Feb 10, 2011 at 03:25, Stefan Fuhrmann >>>  wrote: Hi there, Those among you following the commits will have

cat_tests.py 5 failing because of double-escaped path in expected error message

2011-02-11 Thread Johan Corveleyn
Hi, Currently (trunk@1068411), cat_tests.py 5 (cat should skip uncattable resources) is failing on my machine (Windows XP). There seems to be some double-escaping of the path in the expected error message. I don't understand why this only happens on my machine, and not for instance on the Windows

Re: diff-optimizations-tokens branch: I think I'm going to abandon it

2011-02-12 Thread Johan Corveleyn
On Thu, Dec 2, 2010 at 9:59 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Thu, Dec 02, 2010 at 21:21:20 +0100: >> On Thu, Dec 2, 2010 at 6:18 PM, Bill Tutt wrote: >> >    If tokens include keyword expansion operations then stop once you >> > hit one. The possible

Re: svn commit: r1067800 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_diff/ subversion/libsvn_subr/

2011-02-14 Thread Johan Corveleyn
On Mon, Feb 14, 2011 at 9:49 AM, Ivan Zhakov wrote: > On Mon, Feb 7, 2011 at 01:04,   wrote: >> Author: jcorvel >> Date: Sun Feb  6 23:04:04 2011 >> New Revision: 1067800 >> >> URL: http://svn.apache.org/viewvc?rev=1067800&view=rev >> Log: >> Reintegrate diff-optimizations-bytes branch with trunk.

Re: svn_diff.h truncated

2011-02-14 Thread Johan Corveleyn
On Wed, Feb 9, 2011 at 12:29 AM, Johan Corveleyn wrote: > On Tue, Feb 8, 2011 at 11:19 PM, Johan Corveleyn wrote: >> On Tue, Feb 8, 2011 at 10:50 PM, Stefan Sperling wrote: >>> On Tue, Feb 08, 2011 at 10:45:03PM +0100, Johan Corveleyn wrote: >>>> On Tue, Feb 8, 20

Further diff optimization ideas

2011-02-14 Thread Johan Corveleyn
Hi, Here are some more ideas for optimizing "svn diff". Maybe I should start to write up a notes file, but for now I'm settling for a list in a mail. [ note: these ideas are not original, other people have observed some of these as well (and discussed on IRC and all), and some inspiration also co

Re: Further diff optimization ideas

2011-02-15 Thread Johan Corveleyn
2011/2/15 Branko Čibej : > On 15.02.2011 01:42, Johan Corveleyn wrote: >> 2) Faster hash function for hashing lines. [ Quick win ] >> >> - Currently, we use adler32 (after the line has been normalized). >> >> - GNU diff uses some simple bit shifting scheme, which s

Re: svn commit: r1072282 - in /subversion/branches/integrate-compression-level/subversion: include/svn_delta.h libsvn_delta/svndiff.c svnserve/main.c svnserve/server.h

2011-02-19 Thread Johan Corveleyn
On Sat, Feb 19, 2011 at 10:31 AM, wrote: > Author: stefan2 > Date: Sat Feb 19 09:31:01 2011 > New Revision: 1072282 > > URL: http://svn.apache.org/viewvc?rev=1072282&view=rev > Log: > Public definitions should be prefixed by SVN_. Thus, rename the default > compression level and introduce boundar

Re: svn commit: r1069961 - in /subversion/trunk/subversion: include/svn_diff.h libsvn_diff/diff.c libsvn_diff/diff.h libsvn_diff/diff3.c libsvn_diff/diff4.c libsvn_diff/diff_file.c libsvn_diff/diff_me

2011-02-19 Thread Johan Corveleyn
On Sat, Feb 19, 2011 at 8:03 PM, Ivan Zhakov wrote: > On Sat, Feb 12, 2011 at 00:38,   wrote: >> Author: jcorvel >> Date: Fri Feb 11 21:38:55 2011 >> New Revision: 1069961 >> >> URL: http://svn.apache.org/viewvc?rev=1069961&view=rev >> Log: >> Re-enable elimination of the identical suffix for diff

Re: FSFS format 6

2011-02-20 Thread Johan Corveleyn
On Sun, Feb 20, 2011 at 6:35 PM, Mark Mielke wrote: > On 02/20/2011 03:50 AM, Ivan Zhakov wrote: >> >> On Wed, Dec 29, 2010 at 22:37, Stefan Fuhrmann  wrote: >>> >>> The fopen() calls should be eliminated by the >>> file handle cache. IOW, they should already be >>> addressed on the performance br

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Johan Corveleyn
On Mon, Feb 21, 2011 at 1:50 PM, Noorul Islam K M wrote: > "Bert Huijben" writes: > >>> -Original Message- >>> From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej >>> Sent: maandag 21 februari 2011 13:19 >>> To: Philip Martin >>> Cc: dev@subversion.apache.org >>> Subject: R

Re: Further diff optimization ideas

2011-02-22 Thread Johan Corveleyn
On Mon, Feb 21, 2011 at 8:55 AM, Stefan Fuhrmann wrote: > On 15.02.2011 01:42, Johan Corveleyn wrote: >> >> Hi, >> >> Here are some more ideas for optimizing "svn diff". Maybe I should >> start to write up a notes file, but for now I'm settling fo

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-24 Thread Johan Corveleyn
On Wed, Feb 23, 2011 at 5:08 PM, Hyrum K Wright wrote: > On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad wrote: >> (I've appended the issue subject to the subject line.) >> >> Stefan Sperling wrote: >>> I filed a new issue today (issue #3818, "fix handling of externals in >>> wc-ng" http://subversio

Re: suspected bug report or feature request - tagging a sparse directory

2010-01-08 Thread Johan Corveleyn
On Fri, Jan 8, 2010 at 1:31 AM, Stas Cherkassky wrote: > Julian, > > I don't want to remove parts of the tree from the repository. > What I want is, effectively, a way to independently mark separate > parts of the tree with the same tag. > (I tried to explain it in my example). I don't see how you

Re: Subversion Bug

2010-01-08 Thread Johan Corveleyn
You have bumped into a known issue [1], which is fixed in svn 1.6.6. So upgrading to TortoiseSVN 1.6.6 should help. [1] http://subversion.tigris.org/issues/show_bug.cgi?id=3485 Regards, Johan On Fri, Jan 8, 2010 at 8:22 PM, Razmik Shahinian wrote: > in file > TortoiseSVN-1.6.3\ext\subversion\li

Re: pristine store database -- was: pristine store design

2010-02-16 Thread Johan Corveleyn
On Tue, Feb 16, 2010 at 8:15 PM, Greg Stein wrote: >>> Instead, we could not store size and mtime at all! :) >> >> Or we could store both to perform simple consistency checks... > > Dunno about that, but the storage of SIZE is part of the (intended) > algorithm for pristine storage. It is allowed

website navigation bar on IE7

2010-02-18 Thread Johan Corveleyn
A small nit on the new website: on IE 7, the left navigation bar seems slightly mis-indented. See screenshot in attachment. It looks like it's indented too much, making it appear to be right aligned. On IE 8 it shows up correctly though (meaning it seems ok to me, it's the same as in FF). Johan

Re: website navigation bar on IE7

2010-02-19 Thread Johan Corveleyn
C. Michael Pilato wrote: > Johan Corveleyn wrote: >> A small nit on the new website: on IE 7, the left navigation bar seems >> slightly mis-indented. See screenshot in attachment. It looks like >> it's indented too much, making it appear to be right aligned. On IE 8 >>

Will upgrade from 1.6 to 1.7 benifit from dump/reload?

2010-02-22 Thread Johan Corveleyn
Hi devs, A small question in anticipation of 1.7: will an (FSFS) repo benifit from a dump/reload when upgrading from 1.6 to 1.7? Or will a simple "upgrade" (followed maybe by a "pack" to pack the revprops) provide just the same? Reason for asking: We're currently still running on 1.5, and plannin

missing close of rev file in fsfs - get_dir_contents?

2010-02-23 Thread Johan Corveleyn
Hi devs, I think I may have found a bug in fs_fs.c, while I was examining/profiling the code. However, I am completely new at subversion development, and quite unexperienced in c (I'm a java developer actually, with some notions of c, but trying to learn fast), so I may be imagining things. If so,

Re: missing close of rev file in fsfs - get_dir_contents?

2010-02-24 Thread Johan Corveleyn
On Wed, Feb 24, 2010 at 7:10 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Looking at the source code I see: >> - get_dir_contents calls read_representation >> - read_representation calls rep_read_get_baton, which creates a >> rep_read_baton and opens the

Re: Is sqlite fast enough?

2010-03-04 Thread Johan Corveleyn
On Mon, Feb 22, 2010 at 12:50 PM, Matthew Bentham wrote: > On 22/02/2010 11:42, Matthew Bentham wrote: >> >> On 22/02/2010 11:13, Philip Martin wrote: >>> >>> Matthew Bentham   writes: >>> For me on CYGWIN_NT-6.0-WOW64 brahe 1.7.1(0.218/5/3) 2009-12-07 11:48 i686 Cygwin >>> >>> Thanks fo

Re: Peg revision question

2010-03-05 Thread Johan Corveleyn
On Fri, Mar 5, 2010 at 10:01 PM, C. Michael Pilato wrote: > Mark Phippard wrote: >> Copy is a little different.  For that, I would like to be able to >> specifically ask SVN to do it, which is what you are saying here.  If >> an item is moved, I do not think you should even have to ask. > > Agreed

Re: mails mails

2010-03-12 Thread Johan Corveleyn
On Fri, Mar 12, 2010 at 4:14 AM, neels wrote: > On 12 March 2010 03:57, Greg Stein wrote: >> On Thu, Mar 11, 2010 at 21:26, Neels J Hofmeyr wrote: >>> Mark Phippard wrote: Same here.  Using GMail I didn't even know this was a problem. >>> >>> Hm, I guess it would be ok to use gmail for svn

Re: [PATCH] Improve single byte read stream performance

2010-03-14 Thread Johan Corveleyn
On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: > On Sun, 2010-03-07, Stefan Fuhrman wrote: >> Speed up input stream processing in config parser and >> others that read single bytes from a stream. >> >> * subversion/libsvn_subr/subst.c >>   (translated_stream_read): Add an optimized code path >

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Johan Corveleyn
On Mon, Mar 15, 2010 at 6:18 PM, Ivan Zhakov wrote: > On Mon, Mar 15, 2010 at 17:01, C. Michael Pilato wrote: >> Philip Martin wrote: >>> Johan Corveleyn writes: >>> >>>> On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad >>>> wrote: >>>

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Johan Corveleyn
On Mon, Mar 15, 2010 at 9:56 PM, Johan Corveleyn wrote: > On Mon, Mar 15, 2010 at 6:18 PM, Ivan Zhakov wrote: >> On Mon, Mar 15, 2010 at 17:01, C. Michael Pilato wrote: >>> Philip Martin wrote: >>>> Johan Corveleyn writes: >>>> >>>>>

Issues 3525 & 3526 - please don't forget about these bogus tree conflicts

2010-03-20 Thread Johan Corveleyn
Hi devs, I know a lot of you are mostly focused on wc-ng work right now (which is a good thing: focus is good, wc-ng is good). But I'd like to highlight two other important issues, which can IMHO be very confusing to users, and which I think should definitely be fixed by 1.7 (or if possible, soone

Re: Issues 3525 & 3526 - please don't forget about these bogus tree conflicts

2010-03-21 Thread Johan Corveleyn
On Sat, Mar 20, 2010 at 10:44 PM, Stefan Sperling wrote: > On Sat, Mar 20, 2010 at 10:10:06PM +0100, Johan Corveleyn wrote: >> >> * http://subversion.tigris.org/issues/show_bug.cgi?id=3525 - Locked >> file which is scheduled for delete causes tree conflict > > This on

Re: Issues 3525 & 3526 - please don't forget about these bogus tree conflicts

2010-03-21 Thread Johan Corveleyn
Thanks, Stefan. Your answers were very enlightening, as always :-). I really hope TC handling can be improved for cases like these (resolving them automatically or avoiding them), if possible even for 1.7. I have no idea how you guys are progressing on this front, but I guess a lot of the potentia

Looking to improve performance of svn annotate

2010-03-21 Thread Johan Corveleyn
Hi all, I'm very much looking forward to the performance (and other) improvements wc-ng will bring us. But there's more to svn performance than wc stuff :-). In our company, "svn annotate/blame/praise" is a known offender (people who attended subconf 2009 may remember me as the guy who complained

Re: Looking to improve performance of svn annotate

2010-03-22 Thread Johan Corveleyn
On Mon, Mar 22, 2010 at 11:51 AM, Julian Foad wrote: > On Sun, 2010-03-21, Johan Corveleyn wrote: [ ... ] >> (http://subversion.tigris.org/issues/show_bug.cgi?id=3074#desc5): >> >> [[[ >> My idea for client-side improvement: >> >> The client, while receivin

Re: Looking to improve performance of svn annotate

2010-03-22 Thread Johan Corveleyn
On Mon, Mar 22, 2010 at 12:29 PM, Philipp Marek wrote: > Hello Julian, > Hello Johan, Hi Philipp, Thanks for joining the discussion. All input is really welcome. Julian has already responded to your suggestions, but it got me thinking ... see below. > On Montag, 22. März 2010, Julian Foad wrote

Re: Why merge is so slow? (was Re: svn commit: r926210 - /subversion/trunk/notes/meetings/svn-vision-agenda)

2010-03-23 Thread Johan Corveleyn
On Mon, Mar 22, 2010 at 11:03 PM, Ivan Zhakov wrote: > On Tue, Mar 23, 2010 at 00:53, Mark Phippard wrote: >> On Mon, Mar 22, 2010 at 5:14 PM, Ivan Zhakov wrote: >>> On Mon, Mar 22, 2010 at 20:37,   wrote: +Some other random stuff Hyrum would like to talk about: + * Why is merge slow (

Re: Looking to improve performance of svn annotate

2010-03-23 Thread Johan Corveleyn
On Mon, Mar 22, 2010 at 11:08 PM, Mark Phippard wrote: > On Mon, Mar 22, 2010 at 5:25 PM, Johan Corveleyn wrote: > >> However, looking at Julian's binary blame algorithm, I can't help but >> wonder why this binary structure couldn't be calculated on the server &

Re: Why merge is so slow? (was Re: svn commit: r926210 - /subversion/trunk/notes/meetings/svn-vision-agenda)

2010-03-23 Thread Johan Corveleyn
On Tue, Mar 23, 2010 at 1:32 PM, Mark Phippard wrote: > On Tue, Mar 23, 2010 at 8:28 AM, Stefan Sperling wrote: > >> In most setups I've seen the server hardware is much beefier than >> the client hardware, so unless we do things that scale really badly >> (say more than O(n^2)) I don't see a pro

Re: Subversion Vision and Roadmap Proposal

2010-04-08 Thread Johan Corveleyn
A bit late perhaps, but also from me a big +1 to this vision and roadmap proposal. There are some minor points which can be discussed of course (as always), but overall I think it's a very good plan. I especially applaud the initiative itself to spend some time for this, taking a step back, lookin

Growing developer community (was Subversion Vision and Roadmap Proposal)

2010-04-08 Thread Johan Corveleyn
On Fri, Apr 2, 2010 at 5:28 PM, C. Michael Pilato wrote: [...] > COMMUNITY > [...] > > But communication alone isn't enough.  We need to find ways to grow our > developer community itself.  Attendance at the recent Subversion Corporation > Annual Members Meeting was low (by design and recommendati

misaligned blame output if repo has >1m revisions

2010-04-09 Thread Johan Corveleyn
Hi devs, Just a heads up, not really important, but I came across this in blame_cmd.c (inside print_line_info): [[[ const char *rev_str = SVN_IS_VALID_REVNUM(revision) ? apr_psprintf(pool, "%6ld", revision) : " -"; ]]] Which means that users of a repo with over

Re: misaligned blame output if repo has >1m revisions

2010-04-09 Thread Johan Corveleyn
On Fri, Apr 9, 2010 at 10:37 PM, Hyrum K. Wright wrote: > > > On Fri, Apr 9, 2010 at 9:17 PM, Johan Corveleyn wrote: >> >> Hi devs, >> >> Just a heads up, not really important, but I came across this in >> blame_cmd.c (inside print_line_i

Re: Subversion Vision and Roadmap Proposal

2010-04-13 Thread Johan Corveleyn
On Tue, Apr 13, 2010 at 12:29 PM, Julian Foad wrote: > Bolstridge, Andrew wrote: >> To get new developers, I think the first thing that needs to be done >> is to make entry easier. That means providing a setup ready-to-debug >> for people. The initial hurdle on any software project is getting set

Re: misaligned blame output if repo has >1m revisions

2010-04-18 Thread Johan Corveleyn
Hi all, Sorry it took a while to respond (been away for a while). I've been thinking a little about this, looking at the code ... I see 3 options: 1) Determine the max length of revnum (and author) in blame.c, either while building the blame chunks or in an extra loop before sending the blame in

Re: misaligned blame output if repo has >1m revisions

2010-04-19 Thread Johan Corveleyn
On Sun, Apr 18, 2010 at 11:34 PM, Branko Čibej wrote: > Johan Corveleyn wrote: >> Hi all, >> >> Sorry it took a while to respond (been away for a while). I've been >> thinking a little about this, looking at the code ... >> >> I see 3 options: >

Re: misaligned blame output if repo has >1m revisions

2010-04-19 Thread Johan Corveleyn
2010/4/19 Julian Foad : > Johan Corveleyn wrote: >> On Sun, Apr 18, 2010 at 11:34 PM, Branko Čibej wrote: >> Instead why not do the following: >> > >> >    * Determining the max length for the revision number is a petty much >> >      constant-time op

Re: svn looses history when moving directories

2010-04-26 Thread Johan Corveleyn
On Mon, Apr 26, 2010 at 4:57 PM, Bert Huijben wrote: >> -Original Message- >> From: Mark Phippard [mailto:mphipp...@collab.net] >> Sent: maandag 26 april 2010 16:03 >> To: CollabNet Subversion Client >> Subject: Re: svn looses history when moving directories >> >> On 4/26/10 9:42 AM, "Piet

Re: Feature idea: user-configurable post-commit notifications

2010-04-29 Thread Johan Corveleyn
On Wed, Apr 28, 2010 at 11:58 PM, Neels J Hofmeyr wrote: [...] > We use that in a hook script that forbids > commits that replace nodes -- because some users often do that by accident, > fragmenting history -- Probably because of this bug? http://subversion.tigris.org/issues/show_bug.cgi?id=3429

Some failing tests

2010-05-01 Thread Johan Corveleyn
Hi devs, As I said in the mail thread about the misaligned blame output [1], I wanted to get the test suite running first. However, after spending some time with it, I still have 15 failing tests. I'd like that number to be 0 before I start hacking. Or is it known/expected that certain tests are c

Re: Some failing tests

2010-05-04 Thread Johan Corveleyn
- APR 1.3.8 - Neon 0.28.6 (I don't think that's relevant, since the tests are over ra_local) - Serf 0.3.0 (ditto) Cheers, Johan On Sun, May 2, 2010 at 12:06 AM, Johan Corveleyn wrote: > Hi devs, > > As I said in the mail thread about the misaligned blame output [1], I > want

<    1   2   3   4   5   6   7   8   9   10   >