Johan Corveleyn jcor...@gmail.com writes:
** Test 2 requires a lot of stack. PCRE can be configured to
** use heap for recursion. Otherwise, to pass Test 2
** you generally need to allocate 8 mb stack to PCRE.
** See the 'pcrestack' page for a discussion of PCRE's
** stack usage.
]]]
So
Philip Martin philip.mar...@wandisco.com writes:
Barry Scott ba...@barrys-emacs.org writes:
Index: /Users/barry/wc/svn/svn-1.8.x/subversion/libsvn_wc/tree_conflicts.c
===
--- /Users/barry/wc/svn/svn-1.8.x/subversion/libsvn_wc
Branko Čibej br...@apache.org writes:
On 03.06.2013 11:30, Bert Huijben wrote:
This function is also used from deprecated code in libsvn_cliënt and
some binding code, unlike most other deprecated code...
In some ways this code is 'a bit less deprecated' ;-)
And anyway, only public APIs can
Ben Reser b...@reser.org writes:
That's my fault, I fixed the anonymous locking segfault and chose a
401 to return but I forgot about the WWW-Authenticate header
requirement.
Not really your fault, even before your r1455352 mod_dav_svn returned
401. Without r1455352 append_locks calls
One of my colleagues at WANdisco asked some questions about using
freeze. The first thing he wanted to know is how to detect whether a
freeze is running. There are various approaches: look at running
processes, look at processes with the lock file open, implement some
external lock, etc. but
Daniel Shahaf danie...@apache.org writes:
On Fri, May 31, 2013 at 01:35:57PM +0100, Philip Martin wrote:
I think something like that would work but I'm unsure whether we should
provide it. I'm concerned that it would be making freeze special.
Would we need to provide similar queries
http://subversion.tigris.org/issues/show_bug.cgi?id=4369
If I have broken locks the commit fails:
svnadmin create repo
svn -mm import repo/format file://`pwd`/repo/A/f
svn co http://localhost/obj/repo wc
svn lock wc/A/f
echo xx wc/A/f
svn lock --force file://`pwd`/repo/A/f
svn -mm ci wc
With
Philip Martin philip.mar...@wandisco.com writes:
What sort of URI do we have to supply? Will a session relative f do?
Or a server relative /obj/repo/A/f? Or a full scheme/host/port/path?
RFC 2518 says:
9.4 If Header
If = If : ( 1*No-tag-list | 1*Tagged-list)
No-tag-list = List
Ben Reser b...@reser.org writes:
Has anyone considered backporting the Ruby 1.9 compatability to the 1.7.x
line?
We've got distros shipping with Ruby 1.9 now (e.g. OpenSUSE 12.2) and
not being able to build/use the Ruby bindings without upgrading to 1.8
seems like a pain.
I don't know
Daniel Shahaf danie...@elego.de writes:
Just got a report of a problem with 1.8.0-rc2:
svn: E120104: ra_serf: An error occurred during decompression
The error code is unrecognised; that's because it's not an SVN_ERR_* code:
% ./tools/dev/which-error.py E120104
00120104 ***
Stefan Sperling s...@elego.de writes:
The 1.7.10 release artifacts are now available for testing/signing.
Please get the tarballs from
https://dist.apache.org/repos/dist/dev/subversion
and add your signatures there. I plan to try and release on May
30th so please try and get your
Philip Martin philip.mar...@wandisco.com writes:
I see a intermittent failure in check-swig-rb that looks like an APR
hash ordering issue. The test appears to do some sort of sorting (I
don't know Ruby) but it doesn't always work:
Oops! Looking at the wrong source. On trunk the test sorts
Summary:
+1 to release
Platform:
Linux (Debian/wheezy)
Tested:
(local, svn, svn+sasl, serf, neon) x (fsfs, fsfs/pack/shard, bdb)
(serf/v1, neon/v1) x (fsfs, bdb)
swig-pl, swig-py, swig-rb, ctypes-python
javahl x (fsfs, bdb)
Results:
All tests PASS except for failure in swig-rb
Bert Huijben b...@qqmail.nl writes:
The diff command should never change the wc(no wclock, and no
db/pristine changes), so I really hope the problem that corrupts is
part of the merge on update, or we should check for another problem.
Bert From: s...@apache.org
Sent:
Ben Reser b...@reser.org writes:
The 1.6.22 release artifacts are now available for testing/signing.
Please get the tarballs from
https://dist.apache.org/repos/dist/dev/subversion
and add your signatures there. We plan to try and release on May 30th
so please try and get your
Summary:
+1 to release
Platform:
Linux (Debian/wheezy)
Tested:
(local, svn, svn+sasl, serf, neon) x (fsfs, fsfs/pack/shard, bdb)
swig-pl, swig-py, swig-rb, ctypes-python
javahl x (fsfs, bdb)
Results:
Testsuite fails for diff_tests.py 32, log_tests.py 30 and swig-ruby
Stefan Sperling s...@elego.de writes:
I'll investigate a bit further, but if my testing shows that this
change is reponsible I am going to revert it ASAP to prevent the
damage from spreading.
'svn diff' coredumps with:
(gdb)
#0 0x11bd8dc946bd in svn_eol__find_eol_start
[bringing in dev@s.a.o]
QXO qxodr...@gmail.com writes:
os: windows
encoding:GBK ( chcp 936 )
The svnadmin upgrade command output message first line encoding
issue(UTF-8 show in GBK),But the second line is right encoding!
宸插彇寰楃増鏈簱閿佸畾銆?璇风◢鍊欙紱鍗囩骇鐗堟湰搴撳彲鑳介渶瑕佷竴娈垫椂闂?..
完成升级。
if change
Philip Martin philip.mar...@wandisco.com writes:
So it appears the UTF8 to native conversion is missing from
repos_notify_handler. I think repos_notify_handler should be using
svn_stream_printf_from_utf8 rather than svn_stream_printf.
I've fixed trunk to use svn_cmdline_cstring_from_utf8
Dongsheng Song dongsheng.s...@gmail.com writes:
On Thu, May 23, 2013 at 9:28 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Dongsheng Song dongsheng.s...@gmail.com writes:
On Thu, May 23, 2013 at 9:11 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Philip Martin philip.mar
Dongsheng Song dongsheng.s...@gmail.com writes:
Even ALL the translations are UTF-8, GETTEXT(3) still return the
string encoded by the ***current locale's codeset***.
Here is sniped from the GETTEXT(3) man pages:
In both cases, the functions also use the LC_CTYPE locale facet in
order
Dongsheng Song dongsheng.s...@gmail.com writes:
We do call bind_textdomain_codeset if it is available so we should be
getting UTF8 translations.
For non-autotools system, e.g. Windows, user may not define
HAVE_BIND_TEXTDOMAIN_CODESET.
If you build the software with the wrong settings it
g...@apache.org writes:
Author: gbg
Date: Tue May 21 22:57:23 2013
New Revision: 1485007
URL: http://svn.apache.org/r1485007
Log:
On the invoke-diff-cmd branch: Repair erroneous initialization.
* subversion/svn/io.c
(svn_io_run_external_diff): Change pcalloc to palloc call.
Bert Huijben b...@qqmail.nl writes:
However this is an error path so I'd go for simplicity rather than
efficiency:
const char *failed_command = ;
for (i = 0; cmd[i]; ++i)
{
failed_command = apr_pstrcat(pool, failed_command, cmd[i]);
Philip Martin philip.mar...@wandisco.com writes:
My first loop results in a final trailing and my second loop results
in a leading . Perhaps:
const char *failed_command = cmd[0];
for (i = 1; cmd[i]; ++i)
failed_command = apr_psprintf(pool, %s %s, failed_command
Ivan Zhakov i...@visualsvn.com writes:
On Wed, Mar 27, 2013 at 10:39 PM, cmpil...@apache.org wrote:
Author: cmpilato
Date: Wed Mar 27 18:39:56 2013
New Revision: 1461775
URL: http://svn.apache.org/r1461775
Log:
* subversion/include/svn_error.h
(SVN_ERR_ASSERT): Make this just a
Gabriela Gibson gabriela.gib...@gmail.com writes:
if (config)
{
- svn_config_t *cfg = svn_hash_gets(config,
SVN_CONFIG_CATEGORY_CONFIG);
+ svn_config_t *cfg;
+
+ cfg = svn_hash_gets(config, SVN_CONFIG_CATEGORY_CONFIG);
Why? This doesn't seem to serve any useful
Branko Čibej br...@wandisco.com writes:
I always felt the strtol signature was massively broken because of
that.
Probably a legacy of KR C which didn't have function prototypes or
const. Very few people parse truly const memory so it is usually
legitimate to write to 'end'. In ISO C with
Branko Čibej br...@wandisco.com writes:
On 17.05.2013 15:32, i...@apache.org wrote:
--- subversion/branches/1.8.x/STATUS (original)
+++ subversion/branches/1.8.x/STATUS Fri May 17 13:32:56 2013
@@ -124,6 +124,14 @@ Candidate changes:
Votes:
+1: stefan2 (for 1.8.1)
+* r1483781
Paul Burba ptbu...@gmail.com writes:
sqlite3 wc/.svn/wc.db select op_depth, local_relpath, presence, repos_path,
revision from nodes order by op_depth, local_relpath
0||normal|B|6
0|P|normal|B/P|6
0|X|normal|B/X|6
2|P/Q|normal|T/P/Q|6
2|P/Q/R|normal|T/P/Q/R|6
3|P/Q/R|base-deleted||
The
Philip Martin philip.mar...@wandisco.com writes:
The build fails when configured with --enable-runtime-module-search due
to a new explict dependency of libsvn_fs on libsvn_delta (a dependency
that is satisfied by libsvn_fs_fs/libsvn_fs_base when built without
--enable-runtime-module-search
Paul Burba ptbu...@gmail.com writes:
Bob's script is a different beast, there is a real problem there. I
will rewrite the test to demonstrate his scenario.
It doesn't matter whether we use 1.7 or 1.8 for this:
rm -rf repo wc
svnadmin create repo --compatible-version 1.7
svn -mm mkdir
Ben Reser b...@reser.org writes:
Here it is: the second Release Candidate for Subversion 1.8.0.
The build fails when configured with --enable-runtime-module-search due
to a new explict dependency of libsvn_fs on libsvn_delta (a dependency
that is satisfied by libsvn_fs_fs/libsvn_fs_base when
Summary:
+1 to release
Platform:
Linux (Debian/wheezy) 64-bit
Tested:
(local, svn, svn/sasl, serf, serf/v1) x (fsfs, fsfs/pack/shard, bdb)
swig-pl, swig-py, swig-rb, ctypes-python
javahl x (fsfs, bdb)
Results:
All tests PASS
Local dependencies:
apache2-threaded-dev :
Branko Čibej br...@wandisco.com writes:
This discussion is out of date, I committed a different fix yesterday
that doesn't require premature initialization, yet avoids the
uninitialized-read problem.
There was no uninitialized read to avoid. My compiler now produces:
Branko Čibej br...@wandisco.com writes:
These warnings are maybe which means there will be false positives and
different compilers will have different results. I see a number of
false positives with gcc 4.7.2 and I don't think we should be adding
spurious initialisation to make them go away.
Ivan Zhakov i...@visualsvn.com writes:
Another way add some kind of svn__shared_pool_t with atomic reference
counter and destroying attached pool when counter reaches zero.
Something like this:
An implementation of your idea:
Index: subversion/svnserve/svnserve.c
The 1.7 files
subversion/svn/main.c
subversion/svnserve/main.c
were renamed in 1.8 to
subversion/svn/svn.c
subversion/svnserve/svnserve.c
and this causes conflicts when backporting changes from trunk. On the
branch 1.7.x-r1475724 this was resolved by doing a subtree merge and
thus
C. Michael Pilato cmpil...@collab.net writes:
I removed the system-installed APR and APR-Util. Still seeing the problem.
I'm a bit confused because the library appears (via ldd, at least) to be
linking against the correct apr-util (and was doing so before I removed the
system-install
C. Michael Pilato cmpil...@collab.net writes:
I removed the system-installed APR and APR-Util. Still seeing the problem.
I'm a bit confused because the library appears (via ldd, at least) to be
linking against the correct apr-util (and was doing so before I removed the
system-install
Ivan Zhakov i...@visualsvn.com writes:
On Wed, May 8, 2013 at 1:00 PM, Bert Huijben b...@qqmail.nl wrote:
The fix resolves the symptoms, but I would guess it might be better
to make the thread create (and destroy) its own pool, while using
some proper iterpool in the function that creates
Philip Martin philip.mar...@wandisco.com writes:
We could do this:
Index: subversion/svnserve/svnserve.c
===
--- subversion/svnserve/svnserve.c(revision 1480565)
+++ subversion/svnserve/svnserve.c(working copy
Philip Martin philip.mar...@wandisco.com writes:
It might be better to pass iterpool instead of connection_pool into
apr_thread_create. The problem with tattr also applies to memory
allocated by apr_thread_create such as *new. At present *new is not
accessed after the thread has started
Ivan Zhakov i...@visualsvn.com writes:
But currently APR doesn't access apr_threadattr_t from worker thread
and doesn't need access to apr_thread_t from main thread. So using
iterpool for apr_threadattr_t and connection_pool for apr_thread_t
fixes problem, but only with current APR
Philip Martin philip.mar...@wandisco.com writes:
I think we may be able to create non-detached threads and then
explicitly detach:
Oops! I forgot to pass iterpool to apr_thread_create. Doesn't seem to
work when I fix it.
--
Philip
Ivan Zhakov i...@visualsvn.com writes:
Another way add some kind of svn__shared_pool_t with atomic reference
counter and destroying attached pool when counter reaches zero.
Something like this:
[[[
svn__shared_pool_t * svn__shared_pool_attach(apr_pool_t *pool)
{
svn__shared_pool_t sp
Ben Reser b...@reser.org writes:
There are some changes in STATUS that we should finish voting for. Of
particular note is Branko's case-sensitivity change.
It doesn't seem to be attracting votes so postpone the change to 1.9 and
roll a tarball without it.
--
Certified Supported Apache
Philip Martin philip.mar...@wandisco.com writes:
br...@apache.org writes:
Author: brane
Date: Thu Apr 25 13:48:46 2013
New Revision: 1475772
URL: http://svn.apache.org/r1475772
Log:
Fix issue #4361 (user/group names in authz files are case-insensitive).
* subversion/include
Robert Wruck wr...@tweerlei.de writes:
I just came across this issue. Assume we have two branches:
branches/A where a particular subdir exists
branches/B where this subdir was replaced by an svn:externals entry
Is this a known issue?
http://subversion.tigris.org/issues/show_bug.cgi?id=4360
markp...@apache.org writes:
Author: markphip
Date: Fri Apr 26 19:48:34 2013
New Revision: 1476359
URL: http://svn.apache.org/r1476359
Log:
JavaHL: fix a thread safety bug that has been observed in Subclipse.
The Java SimpleDateFormat class is not thread safe. Solved by
synchronizing the
br...@apache.org writes:
Author: brane
Date: Thu Apr 25 13:48:46 2013
New Revision: 1475772
URL: http://svn.apache.org/r1475772
Log:
Fix issue #4361 (user/group names in authz files are case-insensitive).
* subversion/include/svn_config.h
(svn_config_create2): New, revised from
Mark Phippard markp...@gmail.com writes:
On Mon, Apr 29, 2013 at 7:47 AM, Philip Martin
philip.mar...@wandisco.com wrote:
markp...@apache.org writes:
Author: markphip
Date: Fri Apr 26 19:48:34 2013
New Revision: 1476359
URL: http://svn.apache.org/r1476359
Log:
JavaHL: fix a thread
Mark Phippard markp...@gmail.com writes:
I think Synchronized is a better solution, but will not object if you
want to make the change.
I'm a novice as far as Java is concerned, I don't know which style is
preferred.
--
Certified Supported Apache Subversion Downloads:
Bert Huijben b...@qqmail.nl writes:
However the fact that the missing empty cache is created and populated
is just a fortuitous side effect of how we handle externals[1].
There is nothing special about externals in the following code.
I've added a regression test for inherited properties to
Bert Huijben b...@qqmail.nl writes:
/subversion/trunk/subversion/libsvn_wc/wc-metadata.sql
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
We should probably also test this on an upgrade from entries as in that
case we don't get
Mark Phippard markp...@gmail.com writes:
That said, I did misunderstand the proposal. I thought it was
suggesting we should just make things case-INsensitive. I thought
that would be the wrong decision at this point.
The file has always been case sensitive. So if you are just fixing a
Daniel Shahaf danie...@elego.de writes:
Philip Martin wrote on Fri, Apr 26, 2013 at 15:07:01 +0100:
defines a single group (= mp) and single access rule (= rw). Now that
is still a contrived example but something like this is more likely:
[groups]
Read_Users = philip
Branko Čibej br...@wandisco.com writes:
I also propose, in advance, that we include this change in 1.8. It
should be relatively non-invasive as far as code is concerned, but of
course we'll have to yell loudly in the release notes about the changed
behaviour.
I've raised
Julian Foad julianf...@btopenworld.com writes:
So what exactly is broken, behaviour-wise? Is authorization done with
case-insensitive username checking in the server, and the svnauthz
tool is broken in that it fails to do case-insensitive matching of
usernames? Or something else?
The tool
Philip Martin philip.mar...@wandisco.com writes:
Julian Foad julianf...@btopenworld.com writes:
So what exactly is broken, behaviour-wise? Is authorization done with
case-insensitive username checking in the server, and the svnauthz
tool is broken in that it fails to do case-insensitive
Julian Foad julianf...@btopenworld.com writes:
I am only questioning the assignment of a 1.8.0 release blocker
milestone.
That was simply because Branko suggested he was targeting 1.8.0. We
have to decide now because I don't think we would put this into a minor
release (the last
Paul Burba ptbu...@gmail.com writes:
# We expect the repos root property to show up here!
1.9.0-dev@1475809svn pg svn:auto-props . --show-inherited-props
1.9.0-dev@1475809
Is that expected? The inherited property is not in the 1.7 working
copy. Do you expect upgrade to contact the
Blair Zajac bl...@orcaware.com writes:
It looks like the wrong revision number was given in STATUS, as it's a
tomcat commit:
http://svn.apache.org/viewvc?view=revisionrevision=r1471029
r1471028 is the revision that should have been proposed/voted/merged.
--
Certified Supported Apache
Bert Huijben b...@qqmail.nl writes:
Well, explicitly not initializing variables is another way of adding
undefined behavior.
You are suggesting that all heap variables be explicitly initialised to
zero before being initialised to the correct values. We don't do that
for stack variables, why
Consider an authz file:
[/]
pm = rw
PM = r
When we parse the key=value lines we handle the key case-insensitively
so only one value, the last, gets stored as the second value overrides
the first. However we also store the exact case of the first key and
that is what is checked when
Gabriela Gibson gabriela.gib...@gmail.com writes:
Index: subversion/libsvn_subr/config.c
===
--- subversion/libsvn_subr/config.c (revision 1465268)
+++ subversion/libsvn_subr/config.c (working copy)
@@ -464,7 +464,7 @@
Ivan Zhakov i...@visualsvn.com writes:
On Tue, Apr 23, 2013 at 5:04 PM, phi...@apache.org wrote:
Author: philip
Date: Tue Apr 23 13:04:42 2013
New Revision: 1470936
URL: http://svn.apache.org/r1470936
Log:
Significantly reduce the number of open files during a typical update
over
Stefan Fuhrmann stefan.fuhrm...@wandisco.com writes:
On Tue, Apr 23, 2013 at 6:54 PM, Philip Martin
philip.mar...@wandisco.comwrote:
At the start of the log
you say it is essential to use consistent configs. Does using NULL
result in consistent configs?
Consistent as in same as in all
C. Michael Pilato cmpil...@collab.net writes:
Strictly speaking, though, any of the 'read',
'mark', 'skip' or 'write' operations will trigger the
open-if-not-yet-opened() logic of the lazyopen stream.
As will 'skip' and 'seek', i.e. all public operations apart from
'close'. The new flag
Daniel Shahaf danie...@elego.de writes:
What would a better fix be?
It's hard to say which is probably why these warnings have not been
addressed so far. The warning is a 'maybe':
../src/subversion/libsvn_fs_fs/tree.c:929:27: warning: 'directory' may be used
uninitialized in this function
Julian Foad julianf...@btopenworld.com writes:
I don't think Daniel's assertion made things clearer. Here's my code
rearrangement suggestion, moving the 'directory' variable into a
smaller scope and avoiding it ever being uninitialized:
Second guessing the optimizer is hard:
Branko Čibej br...@wandisco.com writes:
On 18.04.2013 11:49, br...@apache.org wrote:
Author: brane
Date: Thu Apr 18 09:49:03 2013
New Revision: 1469248
URL: http://svn.apache.org/r1469248
Log:
Fixed issue #4338 (Install mod_dontdothat with install-tools)
It would be a great idea if
bl...@apache.org writes:
Author: blair
Date: Thu Apr 18 18:41:55 2013
New Revision: 1469520
URL: http://svn.apache.org/r1469520
Log:
open_path(): silence compiler warning.
subversion/libsvn_fs_fs/tree.c: In function 'open_path':
subversion/libsvn_fs_fs/tree.c:916: warning: 'directory'
[dev CC'd]
Nick nos...@codesniffer.com writes:
The 'patch' subcommand does not seem to support applying a changelist
description to the files that are part of the patch. Any plans to
support this?
(Should I be asking this on the dev list?)
That sounds like a useful feauture. The list of
We allow the user to update a target that is not present in the working
copy: it lets the user bring in a target that is present in a different
revision. We also allow the update of an existing target to a revision
in which the target does not exist: the target gets marked as
'not-present'. Both
Bert Huijben b...@qqmail.nl writes:
-Original Message-
From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
Philip Martin
Sent: woensdag 17 april 2013 12:54
To: dev@subversion.apache.org
Subject: Update targets that don't exist
We allow the user to update a target
C. Michael Pilato cmpil...@collab.net writes:
On 04/17/2013 07:34 AM, Bert Huijben wrote:
With 1.6 and 1.8 I get:
$ svn up wc/some-file-that-does-not-exist
At revision 3
With 1.7 I get:
$ svn up wc/some-file-that-does-not-exist
Updating 'wc/some-file-that-does-not-exist':
At
C. Michael Pilato cmpil...@collab.net writes:
On 04/17/2013 06:43 AM, Philip Martin wrote:
[dev CC'd]
Nick nos...@codesniffer.com writes:
The 'patch' subcommand does not seem to support applying a changelist
description to the files that are part of the patch. Any plans to
support
C. Michael Pilato cmpil...@collab.net writes:
On 04/17/2013 09:43 AM, Philip Martin wrote:
The behaviour looks simple to define for 'patch' and 'merge', I was
thinking about 'svn add --force' which marks all the unversioned files
for addition.
You mean, perhaps, 'svn add --force -R
Philip Martin philip.mar...@wandisco.com writes:
C. Michael Pilato cmpil...@collab.net writes:
'svn merge' comes to mind as one that, like patch, does not always have
explicitly named targets.
Yes, merge is another candidate for this behaviour.
I think it's a reasonable suggestion
Bert Huijben b...@qqmail.nl writes:
And both merge and patch allow adding directories with files inside...
You can certainly add any such files to the changelist but using the
changelist to commit is a problem since the commit doesn't include the
directory.
Changelist support for directories
Roderich Schupp roderich.sch...@gmail.com writes:
* subversion/bindings/swig/svn_client.i
Drop three typemaps. The first two are obviously bogus and
the third is redundant (it's also in svn_containers.swg).
Index: subversion/bindings/swig/svn_client.i
Daniel Shahaf danie...@elego.de writes:
Philip Martin wrote on Tue, Apr 16, 2013 at 12:40:06 +0100:
$ svn -mm mkdir http://localhost:/obj/repo/A
svn: E13: Can't move
'/home/pm/sw/subversion/obj/repo/db/txn-protorevs/2-b.rev' to
'/home/pm/sw/subversion/obj/repo/db/revs/0/3
C. Michael Pilato cmpil...@collab.net writes:
On 04/16/2013 07:40 AM, Philip Martin wrote:
Perhaps mod_dav_svn should only return a low level error is a very few
carefully controlled circumstances and shoul usually return the more
generic could not begin a transaction generated inside
Roderich Schupp roderich.sch...@gmail.com writes:
On Tue, Apr 16, 2013 at 11:35 AM, Philip Martin
philip.mar...@wandisco.com wrote:
Can you provide a bit more explanation for the removal of
revprop_table and changelists from MAY_BE_NULL
Can't pretend that I understand Swig very well either
Mattias Engdegård matti...@bredband.net writes:
Avoid a condition always true warning on platforms where char
is unsigned by default, such as PowerPC and ARM.
* subversion/libsvn_subr/utf_validate.c
(first_non_fsm_start_char, first_non_fsm_start_char_cstring):
Add explicit cast to
Mattias Engdegård matti...@bredband.net writes:
Here is a patch. (I didn't add a newline to the string directly since
it occurs in many places.)
The explaination should go in the code not the email otherwise somebody
else may change the code. I don't understand the explaination, is this
to
Ben Reser b...@reser.org writes:
On Mon, Apr 15, 2013 at 6:38 AM, Philip Martin
philip.mar...@wandisco.com wrote:
Mattias Engdegård matti...@bredband.net writes:
Here is a patch. (I didn't add a newline to the string directly since
it occurs in many places.)
The explaination should go
One absolute URL is enough, the other can be relative.
Ben Reser b...@reser.org writes:
I tend to think the absolute URL syntax is better for our
documentation since the only way the relative URL works is if you run
it while your CWD is in a working copy in that repo.
On Fri, Apr 12, 2013
C. Michael Pilato cmpil...@collab.net writes:
We know the branch isn't RC-ready, so if we cut a tarball, it would be
beta1.
What needs to happen to make it RC-ready?
--
Certified Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Philip Martin philip.mar...@wandisco.com writes:
C. Michael Pilato cmpil...@collab.net writes:
We know the branch isn't RC-ready, so if we cut a tarball, it would be
beta1.
What needs to happen to make it RC-ready?
CHANGES needs to be completed. Anything else?
--
Philip
julianf...@apache.org writes:
Author: julianfoad
Date: Tue Apr 2 19:53:43 2013
New Revision: 1463721
URL: http://svn.apache.org/r1463721
Log:
Fix some sleep-for-timestamps code: avoid missing some cases where we need
to sleep -- especially error cases -- and avoid sleeping in some cases
cmpil...@apache.org writes:
Author: cmpilato
Date: Wed Apr 10 14:38:17 2013
New Revision: 1466497
+svn_swig_py_config_auth_walk_func(svn_boolean_t *delete_cred,
+ void *walk_baton,
+ const char *cred_kind,
+
C. Michael Pilato cmpil...@collab.net writes:
Did you perhaps make a small mistake above? If py_hash == NULL, I don't
think we care need to DECREF if. But perhaps you meant to point out that
we'd be bypassing the DECREF of py_scratch_pool, instead?
Yes.
--
Certified Supported Apache
Mattias Engdegård matti...@bredband.net writes:
The conflict prompt is no longer localised, probably because of an
oversight.
Were they localised in the past?
Index: subversion/svn/conflict-callbacks.c
===
---
julianf...@apache.org writes:
Author: julianfoad
Date: Thu Apr 4 21:14:06 2013
New Revision: 1464769
URL: http://svn.apache.org/r1464769
Log:
Sleep for timestamps even if using commit times as timestamps.
Before r1463721, 'revert' did not sleep if using commit times, while
'checkout'
Bert Huijben b...@qqmail.nl writes:
And we use some of this time to see if you have a modern filesystem that
stores more timestamp details than just seconds (by looking at the existing
filesystem node passed to the function) and if you have such a filesystem we
don't sleep at all.
We still
Julian Foad julianf...@btopenworld.com writes:
* Near past: The recorded commit time, compared with the client-side
clock time, is within the timestamp granularity and in the past.
- We do need to sleep.
- My earlier commit eliminated the sleep, which broke this case.
-
svn_fs_base__rep_contents_checksums() which just does a
svn_checksum_dup on the checksum in the representation of the kind we
asked for. So ultimately, that kind test in the if statement ends up
testing that our functions are following their contract.
On Wed, Apr 3, 2013 at 2:04 PM, Philip Martin
Prompted by a question on users:
http://subversion.tigris.org/issues/show_bug.cgi?id=4345
- switch a file
- delete the switched file
- run status/info
- commit
The behaviour varies with client version:
1.6) status: D and S, info: switched URL, commit: switched URL.
1.7) status: D, info:
801 - 900 of 2536 matches
Mail list logo
