[PATCH] A test for "Can't get entries" error

reporter->finish_report(report_baton, pool)); + } + return SVN_NO_ERROR; +} + + /* The test table. */ static int max_threads = 4; @@ -1820,6 +1926,8 @@ static struct svn_test_descriptor_t test_funcs[] = "check how last change applies to empty commit"), SVN_TEST_OPTS_PASS(c

is it a valid set_path report?

ario, and it always does set_path "" 6 infinity set_path "directory/subdirectory" 5 infinity finish_report e.g. it reports a working copy in a more clever way. But I still want to understand whether the first report is valid. Thanks! -- Dmitry Pavlenko, TMate Software

[PATCH] Re: Directory becomes file when applying patch

/status of the test but from the first glance it looks ok. The test fails because it expects a directory with a property to be created but it is skipped. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge > Hello! > When I apply Git format patch that adds a dir

[PATCH] Re: "svn diff" doesn't work correctly if a file is replaced with a symlink locally

', '\ No newline at end of property\n', ] is the expected output but definitely the diff command shouldn't fail with exit code 1 as it does now. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge On среда, 11 июля 2018 г. 16:13:06 CEST Dmitry Pavlenko wrote: > He

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

Hello Julian, Here's a failing test for "no dot" case. After removing the code as I wrote before the test passes. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge > Dmitry Pavlenko wrote: > > > ... would you mind making a regression test? ... &

Directory becomes file when applying patch

is not file but $FILE_TYPE" echo "" fi if [ "$DIRECTORY_TYPE" != "directory" ] ; then echo "" echo "Dir is not directory but $DIRECTORY_TYPE" echo "" fi -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge

Re: "svn diff" doesn't work correctly if a file is replaced with a symlink locally

mparison #echo "link $NOWHERE" > $WC_PATH/trunk/file # 4. Create diff between repository HEAD and working copy: $SVN diff --git $REPOSITORY_URL $WC_PATH echo "" echo "" echo "-----" echo "If you see something like" echo "-content" echo "+link $NOWHERE" echo "And svn:special property set to '*'" echo "Then consider test passed" echo "-" -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

Hello Julian, OK, I could do that, but much later, in 2 weeks maybe. Now I'm busy testing patch functionality for other cases. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge > Dmitry, the other thing is, would you mind making a regression test for this >

[PATCH] can't "svn patch" working copy root if the patch is in --git format

rse_state *new_state, char *line, old_path_end = new_path_marker; new_path_start = new_path_marker + STRLEN_LITERAL(" b/"); - /* No path after the marker. */ - if (! *new_path_start) -break; - len_old = old_path_end - old_path_start; len_new = new_path_end - new_path_start; ]]] -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge

Re: [PATCH] Make constructors of JavaHL classes public

Yes, it would be enough, thanks! > On 08.03.2016 17:35, Dmitry Pavlenko wrote: > > Hello! > > I would ask you to make some JavaHL contructors public, so it would be > > possible to implement JavaHL more easily. Once you were so kind to do > > that > > >

[PATCH] Make constructors of JavaHL classes public

resultOfMerge, Map<String, byte[]> revisionProperties, Map<String, byte[]> propertiesDelta, ]]] Dmitry Pavlenko

rename ignoreLocal to onDisk

changelists, StatusCallback callback) ]]] -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge

Re: [PATCH] Make constructors of some JavaHL classes public

Dmitry Pavlenko pavle...@tmatesoft.com: Hello all! There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that have package local constructors that makes it difficult to construct them from SVNKit. I would ask you to make the constructors public. [[[ Make constructors

SVN 1.6.x: file copy source is lost when moving a containing directory

(move_added_directory_with_moved_file), ] if __name__ == '__main__': ]]] -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git-svn bridge

svn 1.6 merge fails with Target path '/branches/branch' does not exist

=FALSE. I have a similar issue in SVNKit http://issues.tmatesoft.com/issue/SVNKIT-305?projectKey=SVNKIT Sorry for bothering if 1.6 bugs are not interesting or if you already know about this bug. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git+svn on the server side SVN-fs-dump-format

Re: svn delete fails with 403 Forbidden if root is not readable

(ra_session, url, condensed_targets, revprop_table, commit_callback, commit_baton, ctx, pool)); } + svn_pool_destroy(iterpool); return SVN_NO_ERROR; } ]]] -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git+svn

Re: svn_ra_do_update2 sends copyfrom_path though start_empty=TRUE in report

Maybe I expressed my idea incorrectly. I just wanted to say that send_copyfrom_args works fine in all my personal experiments. -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git+svn on the server side On 08/02/2012 10:33 PM, Dmitry Pavlenko wrote: What about code stability: from my

Re: svn_ra_do_update2 sends copyfrom_path though start_empty=TRUE in report

in update works perfectly, I don't expect that it has many bugs. Thanks for the explanation! -- Dmitry Pavlenko, TMate Software, http://subgit.com/ - git+svn on the server side В сообщении от 3 August 2012 01:49:47 автор Philip Martin написал: Dmitry Pavlenko pavle...@tmatesoft.com writes

svnlook dirs-changed on empty repository fails with a strange error

Hello, If one runs svnlook dirs-changed on an empty repository, svn prints a strange error (reproducible for versions from 1.6 to trunk): $ svnadmin create svn.repo $ svnlook dirs-changed svn.repo/ svnlook: E160006: Transaction '(null)' is not based on a revision; how odd $ svnlook

[PATCH] Wrong condition is checked to understend whether to reset translated_size value in NODES table

I would also ask you to add the fix to 1.7.x [[[ Fix a typo that could lead to wrong translated_size value. if svn:eol-style is locally changed and svn:keywords is not, translated_size wasn't reset. * subversion/libsvn_wc/props.c (do_propset): SVN_PROP_EOL_STYLE value should be checked, not

Re: [PATCH] Wrong condition is checked to understend whether to reset translated_size value in NODES table

Not true. It was comparing old and new values of svn:keywords but should compare old and new values of svn:eol-style. Ok, I got the idea of high-level problem. On Mon, Jun 25, 2012 at 04:03:42PM +0200, Dmitry Pavlenko wrote: I would also ask you to add the fix to 1.7.x [[[ Fix a typo

Re: [PATCH] Wrong condition is checked to understend whether to reset translated_size value in NODES table

You're right, and I was wrong. Yes, I've noticed the bug after running $ svn propdel svn:eol-style file And translated_size was untouched. Dmitry Pavlenko pavle...@tmatesoft.com writes: I would also ask you to add the fix to 1.7.x [[[ Fix a typo that could lead to wrong

[PATCH]: credentials are not saved if username differs from cached version but password does not

simple_providers.c (svn_auth__simple_creds_cache_get): I propose to drop all assignments need_to_save = FALSE except the initial one; otherwise assignment to FALSE may override existing TRUE value. This may happen if default_username!=username and default_password==password: in this case

Re: svn delete fails with 403 Forbidden if root is not readable

Hello again, I've fixed the issue in SVNKit: http://svn.svnkit.com/repos/svnkit/trunk/ at r9286 The approach is to use common ancestor instead of repository root to run editor calls. For example, to remove paths: directory/subdirectory1/file1 directory/subdirectory1/file2

[PATCH]: Add 'replaced' value to ConflictDescriptor.Reason

Hi, enum svn_wc_conflict_reason_t has 10 possible values but ConflictDescriptor.Reason from javahl only 6; as I understand this is because some of svn_wc_conflict_reason_t values are experimental (for 1.8); but anyway at least 1 of those values is released (svn_wc_conflict_reason_replaced that

svn delete fails with 403 Forbidden if root is not readable

Hello, Suppose you have a repository with authz: [/] * = [/directory] * = rw And the repository (http://localhost:43714/repos) contains a directory (with rw access) and a file in it. File deletion fails with the following stacktrace (tried with SVN r1350986): $ svn rm

[PATCH] Regression test for r1348822 (svn status -u --depth empty problem)

[[[ Add a regression test for r1348822. * subversion/tests/cmdline/stat_tests.py (status_depth_update_local_modifications): Add a test for svn status -u call with different --depth values on a working copy with local modifications. ]]] Index: subversion/tests/cmdline/stat_tests.py

moved externals are not reported as externals by status

Hello all, Hello all. I save a directory with svn:externals set, external is checked out. svn status -v reports it as 'X' for both WC 1.6 and WC 1.7. When I move the directory with svn:externals property into another directory: for SVN 1.6 case external is still reported as 'X', but in the

Re: paths in diff output (possible bug)

to regular, but for deleted properties you do not (and the same is true for file properties diff). 2. In diff_repos_repos_added_or_deleted_dir in for cycle you use different pools (iterpool and scratch_pool). On Thu, May 03, 2012 at 10:05:26PM +0200, Dmitry Pavlenko wrote: Thanks, Stefan, I

Re: paths in diff output (possible bug)

at 07:16:44PM +0100, Dmitry Pavlenko wrote: I expected you'd get an /directory/subdirectory@1 doesn't exist error. I was the older (1.6) SVN behaviour Now do {} while() cycle in diff_prepare_repos_repos takes parent URL until URL exists in both start and end revisions. So maybe

Re: paths in diff output (possible bug)

Thanks, Stefan, I like the approach of a fake checkout. Actually this is what I meant by proposing to handle this case separatedly. On Thu, May 03, 2012 at 02:51:54PM +0200, Stefan Sperling wrote: I don't want a solution that requires a server upgrade. This is a user-interface problem. The

Re: update without changes: broken lock removed, no notifications generated

No, I'm not going to write a patch. Pointing to a certain line with a problem is the best I can do so far. Dmitry Pavlenko pavle...@tmatesoft.com writes: So I propose to add (lock_state != svn_wc_notify_lock_state_unchanged) condition somewhere to SVN 1.7 Sounds reasonable. Are you

svn_client_status5: ood_changed_rev is different for http and file protocols

Hello all! I have a question about internal SVN status API (trunk, r1302023). I have a repository with 2 reivsions: in r1 a file is added, in r2 it is deleted. I checkout revision 1 using * file protocol and * http protocol as a working copy and run svn_client_status5 on a file with the

Re: a potential bug in svn_wc__db_wcroot_parse_local_abspath

time? Originally I wanted to propose a simple patch but the things become to complex for me, so I think I won't propose you the patch. On Wed, Mar 14, 2012 at 09:53:02PM +0100, Dmitry Pavlenko wrote: Hello! I've found a potential bug in svn_wc__db_wcroot_parse_local_abspath function

Re: paths in diff output (possible bug)

I expected you'd get an /directory/subdirectory@1 doesn't exist error. I was the older (1.6) SVN behaviour Now do {} while() cycle in diff_prepare_repos_repos takes parent URL until URL exists in both start and end revisions. So maybe the cycle should be run only once not to let '/'. Or,

paths in diff output (possible bug)

Hello all. I'm trying to understand the principles how SVN calculates paths for diff. I've put repository attached under URL http://localhost/svn;. I'll put its history here: r4 | dmit10 | 2012-03-19 20:34:31 +0100 (Пнд, 19

Re: a potential bug in svn_wc__db_wcroot_parse_local_abspath

Would you like to submit a patch for this? Yes, I would like to try. If I meet difficulties, I'll write.

a potential bug in svn_wc__db_wcroot_parse_local_abspath

Hello! I've found a potential bug in svn_wc__db_wcroot_parse_local_abspath function. Suppose the following directories structure: working_copy_root | +nested_working_copy_root +not_versioned_symlink Suppose also that not_versioned_symlink points to nested_working_copy_root.