[PATCH v4] Reject checkouts to existing directory

2016-11-24 Thread Patrick Steinhardt
/checkout_tests.py: (checkout_with_obstructions): Replace old test and now assert that subversion refuses to checkout to non-empty dirs. ]]] Regards Patrick -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Patrick Steinhardt
s_data/; I believe the latter should be considered read-only. > > > > Oh yes! I forgot to call that out. I'll re-work it. > > OK, committed in http://svn.apache.org/r1771118 > using most of your log message Patrick. Thank you for flagging this issue. > > - Julian Thanks

Re: [PATCH] Recreate test data for Git mirrors

2016-11-21 Thread Patrick Steinhardt
On Wed, Nov 16, 2016 at 04:30:55PM +, Julian Foad wrote: > On 07/11/16, Patrick Steinhardt wrote: > > attached is a patch that fixes a test for Git mirrors. The error > > results from the fact that Git does not track empty directories, > > which one test relies upon. >

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-21 Thread Patrick Steinhardt
On Sat, Nov 19, 2016 at 05:53:26AM +, Daniel Shahaf wrote: > Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > > +++ b/subversion/svn/checkout-cmd.c > > @@ -61,6 +61,144 @@ > >Is this the same as CVS? Does it matter if it is not? > > */ &g

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-16 Thread Patrick Steinhardt
Hi, short ping. Anybody got time to review this? Regards Patrick On Wed, Nov 09, 2016 at 12:54:08PM +0100, Patrick Steinhardt wrote: > Hi, > > this is version three of my patch regarding checkouts to existing > directories. Thanks for the feedback on the previous two patches. >

Re: [PATCH] svn_client_list4: accept `NULL` patterns

2016-11-11 Thread Patrick Steinhardt
On Wed, Nov 09, 2016 at 02:05:38PM +0100, Stefan Sperling wrote: > On Wed, Nov 09, 2016 at 11:27:47AM +0100, Patrick Steinhardt wrote: > > Hi, > > > > while continuing my work on the obstructed checkout patch I just > > updated to the new `svn_client_list4` call,

Re: [PATCH v3] Reject checkouts to existing directory

2016-11-11 Thread Patrick Steinhardt
On Wed, Nov 09, 2016 at 05:09:17PM +, Daniel Shahaf wrote: > Patrick Steinhardt wrote on Wed, Nov 09, 2016 at 12:54:08 +0100: > > [[[ > > checkout_cmd: refuse obstructed checkouts > > The first paragraph of the log message should be a complete sentence. > (Capitali

[PATCH v3] Reject checkouts to existing directory

2016-11-09 Thread Patrick Steinhardt
that subversion refuses to checkout to non-empty dirs. ]]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany Sitz der Gesellschaft: Berlin, USt-IdNr

[PATCH] svn_client_list4: accept `NULL` patterns

2016-11-09 Thread Patrick Steinhardt
array. Improve usability by also allowing a caller to pass in a `NULL` pointer instead of an empty array. * subversion/libsvn_repos/list.c: (matches_any): Return `TRUE` if `patterns` is `NULL` ]]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12

[PATCH] Recreate test data for Git mirrors

2016-11-07 Thread Patrick Steinhardt
. * subversion/tests/cmdline/import_tests.py: (import_inherited_ignores): Create empty directories if they do not exist yet. ]]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin

Re: [PATCH] Uppercase client-specific resolve option labels

2016-10-31 Thread Patrick Steinhardt
On Fri, Oct 14, 2016 at 06:23:09PM +0200, Patrick Steinhardt wrote: > Hi, > > currently, call library-provided resolve option labels have a > leading uppercase character, but all client-specific options are > lowercase only. This patch improves upon this situation. > >

Re: [PATCH v2] Reject checkouts to existing directory

2016-10-28 Thread Patrick Steinhardt
On Fri, Oct 28, 2016 at 12:34:44AM +0200, Stefan wrote: > On 10/27/2016 21:45, Stefan Sperling wrote: > > On Tue, Oct 18, 2016 at 02:22:25PM +0200, Patrick Steinhardt wrote: > >> Hi, > >> > >> finally got around to update my patch regarding checkouts to >

Re: [PATCH] gpg-agent: search gpg-agent socket in $GNUPGHOME

2016-10-27 Thread Patrick Steinhardt
Hi Bert, On Thu, Oct 27, 2016 at 11:54:06AM +0200, Bert Huijben wrote: > > -Original Message- > > From: Patrick Steinhardt [mailto:p...@pks.im] > > Sent: donderdag 27 oktober 2016 11:15 > > To: Subversion <dev@subversion.apache.org> > > Subject: [PATCH

[PATCH] gpg-agent: search gpg-agent socket in $GNUPGHOME

2016-10-27 Thread Patrick Steinhardt
Hi, a recent thread on issues with gpg-agent lead me to take a look at how the gpg-agent socket is located in subversion. The current code was lacking support for $GNUPGHOME, which allows a user to relocate his gnupg configuration directory. As setting this environment variable would also cause

[PATCH v2] Reject checkouts to existing directory

2016-10-18 Thread Patrick Steinhardt
/tree_conflict_tests.py: (ensure_tree_conflict): use 'co --force'. ]]] Regards Patrick -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany Sitz der Gesellschaft: Berlin, USt-IdNr.: DE 163214194

[PATCH] Uppercase client-specific resolve option labels

2016-10-14 Thread Patrick Steinhardt
: (extra_resolver_options, extra_resolver_options_text, extra_resolver_options_prop, extra_resolver_options_tree): upper-case labels. ]] Regards Patrick -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany

[PATCH] Improve conformance to ISO C90

2016-10-14 Thread Patrick Steinhardt
): remove trailing comma * subversion/svnmover/linenoise/linenouse.c: (lndebug): replace variadic macro stub with an empty variadic function ]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany

[PATCH v3] Conflict option labels

2016-10-13 Thread Patrick Steinhardt
Hi, the third version re-adds the result pool to `svn_client_conflict_option_get_lazel`. [[ Move conflict resolution options' labels out of the client * subversion/include/svn_client.h: (svn_client_conflict_option_get_label): New function. * subversion/libsvn_client/conflicts.c:

Re: [PATCH v2] Conflict option labels

2016-10-13 Thread Patrick Steinhardt
On Thu, Oct 13, 2016 at 04:52:12PM +0200, Stefan Sperling wrote: > On Thu, Oct 13, 2016 at 04:46:55PM +0200, Patrick Steinhardt wrote: > > Is there by any chance a tool which helps generating this tedious > > list? > > There are some but I cannot tell which is best and how w

Re: [PATCH v2] Conflict option labels

2016-10-13 Thread Patrick Steinhardt
On Thu, Oct 13, 2016 at 04:40:59PM +0200, Stefan Sperling wrote: > On Thu, Oct 13, 2016 at 03:46:32PM +0200, Patrick Steinhardt wrote: > > * subversion/include/svn_client.h: > > - new function `svn_client_conflict_option_get_label` > > * subversion/libs

Re: [PATCH v2] Conflict option labels

2016-10-13 Thread Patrick Steinhardt
On Thu, Oct 13, 2016 at 03:46:32PM +0200, Patrick Steinhardt wrote: > Hi, > > here's the second version of the conflict option label patch. > Changes: > > - reworded some labels > - now using apr_array to pass around options > - renamed and simplified svn_clie

[PATCH v2] Conflict option labels

2016-10-13 Thread Patrick Steinhardt
, build_text_conflict_options, build_prop_conflict_options, build_prop_text_conflict_options, handle_one_prop_conflict. build_tree_conflict_options, handle_tree_conflict): accept options as apr_array_header_t ]] Regards -- Patrick Steinhardt, Entwickler elego Software

[PATCH] Improve error message on copying to unversioned dir

2016-10-13 Thread Patrick Steinhardt
or message - subversion/tests/cmdline/input_validation_tests.py: * (invalid_copy_target): adjust expected error message ]] Regards -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany Sitz der Gesellscha

Re: [PATCH] Reject checkouts to existing directory

2016-10-12 Thread Patrick Steinhardt
On Wed, Oct 12, 2016 at 04:49:55PM +0200, Bert Huijben wrote: > > > > -Original Message- > > From: Stefan Sperling [mailto:s...@elego.de] > > Sent: woensdag 12 oktober 2016 16:37 > > To: Patrick Steinhardt <patrick.steinha...@elegosoft.com> > >

Re: [PATCH] Conflict option labels

2016-10-12 Thread Patrick Steinhardt
On Wed, Oct 12, 2016 at 04:32:24PM +0200, Stefan Sperling wrote: > On Wed, Oct 12, 2016 at 03:38:02PM +0200, Patrick Steinhardt wrote: [snip] > > + svn_client_conflict_option_t *option, > > + apr_pool

Re: [PATCH] Conflict option labels

2016-10-12 Thread Patrick Steinhardt
On Wed, Oct 12, 2016 at 04:44:10PM +0200, Ivan Zhakov wrote: > On 12 October 2016 at 15:38, Patrick Steinhardt > <patrick.steinha...@elegosoft.com> wrote: > > Hi, > > > > please find attached a patch pulling out the short descriptions > > of conflict resolut

[PATCH] Reject checkouts to existing directory

2016-10-12 Thread Patrick Steinhardt
without --force ]] Regards -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany Sitz der Gesellschaft: Berlin, USt-IdNr.: DE 163214194 Handelsregister: Amtsgericht Charlottenburg HRB 77719

Re: [PATCH] Remove unused variables in conflict resolution code

2016-10-12 Thread Patrick Steinhardt
On Wed, Oct 12, 2016 at 03:46:38PM +0200, Ivan Zhakov wrote: > On 12 October 2016 at 15:05, Patrick Steinhardt > <patrick.steinha...@elegosoft.com> wrote: > > Hi, > > > > see the attached patch for fixes to some unused-variable > > warnings. > > >

[PATCH] Conflict option labels

2016-10-12 Thread Patrick Steinhardt
options ]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany Sitz der Gesellschaft: Berlin, USt-IdNr.: DE 163214194 Handelsregister: Amtsgericht Charlottenburg HRB 77719 Geschäftsführer: Olaf Wagner

[PATCH] Remove unused variables in conflict resolution code

2016-10-12 Thread Patrick Steinhardt
Hi, see the attached patch for fixes to some unused-variable warnings. [[ Remove variables which are written but not used in any way. * subversion/libsvn_client/conflicts.c: Remove unused variables ]] -- Patrick Steinhardt, Entwickler elego Software Solutions GmbH, http://www.elego.de