Re: [dev] [st] [patch] misplaced parenthesis in LEN macro

#define LEN(x) (sizeof (x) / sizeof *(x)) I am used to read the other form, but I thing it is only a question of personal taste, and since the other form was sent before your suggestion I'll apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] move MODBIT to Macros section

that alot mail client is not working anymore with st. I am pretty busy lately and I do not have time to fix it, so could be good if anyone help in this point. I have more information about this problem if it is required. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] Understading st behaviour

, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Don't make bold text bright with default color

making the bold text hard to read on a gray background ;-) standard? could you explain what standard are you talking?, because I think no iso, or ansi, or whenever you want made a standard about it. Regards, -- Roberto E. Vargas Caballero

[dev] [st][PATCH] Fix Backspace and Delete characters

Backspace key must generate the backspace character (\010) and Delete key must generate the delete character (\0177). In some systems the kernel configuration for erasing previous character is \0177, so some programs (for example cat, ed, mail, ...), can not understand the correct meaning of

Re: [dev] [st] [patch] redundant gettimeofday

Christoph, are you again to apply this patch now? Regards, -- Roberto E. Vargas Caballero

Re: [dev] Backspace (was: st stutter and freeze ...)

://www.ibb.net/~anne/keyboard.html [2] http://www.tldp.org/HOWTO/Keyboard-and-Console-HOWTO-5.html -- Roberto E. Vargas Caballero -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] fix cursor handling when alt screen is disabled

I don't like this alt screen thing, but when allowaltscreen == 0, the cursor is still saved and restored after calling 'less' (or 'man'). This patch makes allowaltscreen == 1 usable. Good catch, but I think it makes allowaltscreen == 0 usable, does it? Regards, -- Roberto E. Vargas

Re: [dev] [st] [patch] XSync consistency

Changes 0 to False. Forgot patch. This patch cleans up a style inconsistency. Thanks, I will apply it next week. -- Roberto E. Vargas Caballero

Re: [dev] Backspace (was: st stutter and freeze ...)

the terminfo definition). Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] Understading st behaviour

when asking if you want to continue building a package and you can't pass keys to stdin, they are printed on the screen. I'm sorry, but I cannot understand you here. Could you explain a bit more about this problem? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] typedefs instead of #defines

, -- Roberto E. Vargas Caballero

Re: [dev] st stutter and freeze during window resize via mouse drag

why it was in the definition. Regards, -- Roberto E. Vargas Caballero

[dev] Backspace (was: st stutter and freeze ...)

would like listen the opinion of st users about this topic before of doing this kind of modifications. Regards, [1] http://www.ibb.net/~anne/keyboard.html [2] http://www.tldp.org/HOWTO/Keyboard-and-Console-HOWTO-5.html -- Roberto E. Vargas Caballero

[dev] New version of st

the segmentation fault of 672e4e4 after creating the stable version. Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

Find Damian's slightly altered patch below. I hope he is okay with us applying this version of his patch. Just tell me if I should change something. For me is ok, and again, if nobody complaints about it I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st][patch] Fix segfault when pressing PrintScr without a selection

;; esac Of course, in the case of *.jpg it will work only if the selection is an absolute name, or the plumber and st are in the same directory. Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

send a fixed patch? Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

It is number of function calls, on cat dwm cat UTF-8-demo yields: utflen 113 utfencode 8152 utfdecode 198346 So I think only utfdecode need to be optimised if necessary. I also like the patch, so if nobody complaints about it then I will apply next week. Regards, -- Roberto E. Vargas

Re: [dev] [st] problems with terminfo entries and zsh

. They have a binary database built with Berkeley DB. You can find a solution to this issue in this thread: http://lists.suckless.org/dev/1309/17580.html. If you can find a better way could be good for st OpenBSD users. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] problems with terminfo entries and zsh

the same question all the times. Regards, [1] : http://st.suckless.org/ -- Roberto E. Vargas Caballero

Re: [dev] Reasonable Makefiles

echo '# Extra configuration for Darwin (from config.uname)' echo 'EXTRA_CPPFLAGS = -I/opt/local/include' ;; esac It is similar to the configure of utmp, and usually it is the only thing you need. Regards, -- Roberto E. Vargas Caballero

[dev] [st][PATCH 1/6] Add MC sequence

This sequence control when the printer is enabled or disabled. This sequence control the behaviour of the -o option. --- st.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/st.c b/st.c index cad61bf..314bf3f 100644 --- a/st.c +++ b/st.c @@ -134,6 +134,7 @@

[dev] [st][PATCH 2/6] Add MC for a single line

This sequence print the current line. It is different to the 'printer on' sequence, where all the characters that arrive to the terminal are printer. Here only the ascii characters are printed. --- st.c | 41 - 1 file changed, 32 insertions(+), 9

[dev] [st][PATCH 3/6] Add MC for the full screen

This sequence is very useful because allows comunicate the content of the terminal to another program. --- st.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/st.c b/st.c index e60643c..1711842 100644 --- a/st.c +++ b/st.c @@ -358,6 +358,7 @@ static void strreset(void); static

[dev] [st][PATCH 4/6] Add key definition for printer sequences

These new combinations generate the same behaviour (basically) of vt102. It is a good way of communicating st with other programs. [0] http://www.vt100.net/docs/vt102-ug/chapter2.html --- config.def.h | 2 ++ st.c | 12 2 files changed, 14 insertions(+) diff --git

[dev] [st][PATCH 5/6] Add sequence for printing the current selection

This is very usefull in order to can select what is sent to the plumber. --- config.def.h | 1 + st.c | 32 +--- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/config.def.h b/config.def.h index 47018a3..58b470e 100644 --- a/config.def.h +++

[dev] [st][PATCH 6/6] Add terminfo entries for printer

These capabilities inform to programs how print in local printer of the terminal. --- st.info | 3 +++ 1 file changed, 3 insertions(+) diff --git a/st.info b/st.info index 7526141..4e60a89 100644 --- a/st.info +++ b/st.info @@ -152,6 +152,9 @@ st| simpleterm, ncv#3, op=\E[39;49m,

Re: [dev] tmux/screen alternative

patch about pipes). I hope send it in the next days. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

, and instead processing such events themselves. This patch does just this. If nobody complaints about this patch I will apply it the next week. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

this feature? Regards, -- Roberto E. Vargas Caballero

Re: [dev] Reasonable Makefiles

dependences and other things). Regards, -- Roberto E. Vargas Caballero

Re: [dev] Reasonable Makefiles

Makefile). I usually don't like this way because the user should read the documentation and see the Makefile/makefile issue. Regards, -- Roberto E. Vargas Caballero

[dev] [st][PATCH] Add xstrdup function

Since we are using xmalloc, xrealloc ..., then it is not logical call directly to strdup. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- st.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/st.c b/st.c index 6e7077a..49dd889 100644 --- a/st.c

[dev] [st][PATCH 1/4] Make CONTROL + DELETE delete a line

If CONTROL + INSERT inserts a line then it seems natural CONTROL + DELETE removes a line. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- config.def.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index 4664416..d0fc186 100644

[dev] [st][PATCH 1/4] Make CONTROL + DELETE delete a line

If CONTROL + INSERT inserts a line then it seems natural CONTROL + DELETE removes a line. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- config.def.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index 4664416..d0fc186 100644

[dev] [st][PATCH 4/4] Remove non defined behaviour in selcopy

It is not defined when lateral effects of expressions are calculated, so an expression as: --last = gp !(selected(last - gp, y) is non portable. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- st.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[dev] [st][PATCH 3/4] Remove duplicated code in strhandle

The error condition was duplicated in two different switches. This new version centralized the error handling in only one place. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- st.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/st.c

[dev] [st][PATCH 3/4] Remove duplicated code in strhandle

The error condition was duplicated in two different switches. This new version centralized the error handling in only one place. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- st.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/st.c

[dev] [st][PATCH 2/4] Make Shift+Home equal to CLS in ascii mode

Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- config.def.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index d0fc186..b31d7d6 100644 --- a/config.def.h +++ b/config.def.h @@ -153,7 +153,8 @@ static uint ignoremod

[dev] [st][PATCH 4/4] Remove non defined behaviour in selcopy

It is not defined when lateral effects of expressions are calculated, so an expression as: --last = gp !(selected(last - gp, y) is non portable. Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com --- st.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[dev]

After writing this mail I discovered a bug in the Shift+Del definition.

Re: [dev] ncurses or ...

. You should avoid words as 'stupid', if you don't want to convert this in something personal. If you don't agree with an idea, please indicate the technical reasons, or in other case shut up. -- Roberto E. Vargas Caballero

Re: [dev] [sbase] [patch] Completely ignore character and block devices in tar(1)

. #ifdefs are dangerous, but I see nothing wrong with how you used them here. My position is similar. I am not sure about it, but I agree that the previous solution was enough good for me. Regards, PD: sin, your work with sbase is incredible -- Roberto E. Vargas Caballero

Re: [dev] ncurses or ...

for your TUI (split the program in two parts, one, the terminal which handles all the graphic issues, and other the editor which does the functional part). Regards, -- Roberto E. Vargas Caballero

Re: [dev] [sbase] move mknod(1) to ubase

The current implementation of mknod(1) uses makedev(3) which apparently is not POSIX and does not exist on some systems, such as Haiku. Is it possible use other function for it?. The problem is that makedev is also used in tar. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [sbase] move mknod(1) to ubase

to move mknod to ubase, and change the mknod system call of tar (and next archivers that could be implemented in sbase) to a system(mknod ...). Other point is to think what is the number of system where makedev is not supported, because maybe the list is really small. Regards, -- Roberto E

Re: [dev] [PATCH] Make w3mimgdisplay work with st

file), and it now renders fine for me as shown in the after-patch.png attachment. This patch makes sense for me, so I'll apply it. -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Make w3mimgdisplay work with st

this issue. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Make w3mimgdisplay work with st

I changed how height of region to update is being calculated, it should work properly now. I'll apply it. Thanks -- Roberto E. Vargas Caballero

Re: [dev] [PATCH][RFC] Add a basic version of tr

version of the code can be found below. I like more the version with the pointer function because you only have a copy of the loop and because the text segment of the executable will be smaller. -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Make w3mimgdisplay work with st

I like the idea of having this feature in st, and your patch is simple because you only move a function from one place to another, but could you explain a bit why moving the function from draw to xdraws makes w3mimgdisplay work? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Make w3mimgdisplay work with st

to XCopyArea with this patch, but I haven't noticed any side effects. I have noticed one. I get the large letters (g, j, y) cut in the botton part with with my font configuration ([0]). Regards, [0] Liberation Mono:pixelsize=14:antialias=false:autohint=false -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Fix truecolor escapes, when both bg and fg are set

, int charlen, int bytelen) { } if(IS_TRUECOL(base.bg)) { + colbg.alpha = 0x; colbg.green = TRUEGREEN(base.bg); colbg.red = TRUERED(base.bg); colbg.blue = TRUEBLUE(base.bg); -- 1.8.5.2 -- Roberto E. Vargas Caballero

Re: [dev] Optimizing C compiler c++ compiler/runtime

, -- Roberto E. Vargas Caballero

Re: [dev] [sbase] printf(1)

else? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [sbase] printf(1)

stores a char in an array and does a comparation (from kr): #define putc(x,p) (--(p)-cnt = 0 \ ? (unsigned char) * (p)-ptr++ = (x) : _fillbuf(p)) It is cheap and I think the code is far clear with that aproach. Regards, -- Roberto E. Vargas Caballero

Re: [dev] Slock segfaults if USER variable is empty

I do not know how you guys think about this, but I would do that in one line: if(!(user = getenv(USER))) I agree with you, although can be a discussion point if it is better or not something like: if ((user = getenv(USER)) != NULL) -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix F28 key definition.

help to understand it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] query pixel size from matched font

Hi, The patch sounds logical to me, so I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st][PATCH] Prevent resizing stdin

The problem was that ioctl was resizing cmdfd before it gets initialized in ttynew. Since cmdfd is a global variable, its initial value is 0, and consequently stdin was being resized. Good catch, I'll apply the patch. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Support for _NET_WM_PID

I've attached a version of the patch that uses a local variable instead. Ok, I'll apply the patch. -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Support for _NET_WM_PID

be better to use a local variable. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] Rendering Glitch

Apparently, it's not st's fault. After the misspelled word, xterm receives ^[[24m^[[49m (no underline, reset background), while st receives ^[[m^[[49m (reset all, reset background). I'm no expert in this, so I hope someone with better knowledge reviews this. So it means there is a problem in

Re: [dev][announce] slm - music curation

Has nobody linked [0] in this discussion yet? (I haven't read every mail because it is very boring.) An interface based on files is reasonable, but one based on symlinks? less so. Basically it is the reason why he added support for hardlinks in the tool. Regards, -- Roberto E. Vargas

Re: [dev][announce] slm - music curation

On Thu, Nov 28, 2013 at 10:26:50AM -0500, Bobby Powers wrote: Hello! Roberto E. Vargas Caballero k...@shike2.com wrote: why no a option for hardlinks? Initially because I didn't want to explain to people that the music directory and the farm/db directory had to be on the same partition

Re: [dev][announce] slm - music curation

option to select one or other. -- Roberto E. Vargas Caballero

Re: [dev][announce] slm - music curation

in the same machine with different opinions, no? -- Roberto E. Vargas Caballero

Re: [dev][announce] slm - music curation

execute things are not the best place for your music colection, but I think having a -h/-s is cheaper (only an if in the code) and makes sense for this possibility. Regards, -- Roberto E. Vargas Caballero

Re: [dev][announce] slm - music curation

symlinks being created: why no a option for hardlinks? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] add _NET_WM_NAME

On Fri, Nov 22, 2013 at 05:28:20PM -0500, Carlos Torres wrote: Here is a simpler patch that adds _NET_WM_NAME Atom to st. Ok, if it is ok for everyone I will apply this patch instead of the previous. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st][patch] use int instead of long for color

On Thu, Nov 14, 2013 at 04:09:08PM +0100, Johannes Hofmann wrote: Hi, here is a patch that replaces long with int. It saves some memory on 64bit systems. If you want 32 bits use uint32_t, in other case I will not apply the patch. -- Roberto E. Vargas Caballero

Re: [dev] [st] why is Glyph.fg, Glyph.bg long?

On Wed, Nov 13, 2013 at 01:03:47PM +, Thorsten Glaser wrote: Roberto E. Vargas Caballero dixit: long, because long is at least 32 bits for sure, but int can be only 16 On POSIX, int is a minimum 32 bit data type. I prefer follow the ISO rules about data sizes. Regards, -- Roberto E

Re: [dev] [st] why is Glyph.fg, Glyph.bg long?

in other machine with other architecture, and maybe we will begin to talk about this issue. using “int” here is probably the right thing to do. I am sorry, but I don't agree with you in this point. -- Roberto E. Vargas Caballero

Re: [dev] [st] why is Glyph.fg, Glyph.bg long?

, because long is at least 32 bits for sure, but int can be only 16 bits. Actually, doesn't matter if it is 32 or 64 bits, because we are interested only in the low 32 bits, but if you want to be sure that you are going to have only 32 bits, then use int32_t. Regards, -- Roberto E. Vargas

Re: [dev] Suckless remote shell?

for system programming and there is not any other language which can be used in this kind of applications. -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write

Re: [dev] Suckless remote shell?

don't know it, it is not a longjmp problem, is it a problem of the people. -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams

Re: [dev] IRC on Free node

... Regards, -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because that is a universal interface' (Doug McIlroy) In Other

Re: [dev] [st] [patch] Ignore numlock (Mod2Mask) for button events too.

On Sun, Oct 20, 2013 at 09:54:51AM +0200, Roberto E. Vargas Caballero wrote: A bug presents if you try to add a button shortcut to mshortcuts using a mask, for example: { Button3, ShiftMask, hi}, The above does not work if Numlock (Mod2Mask) is on, which is unexpected. I'll

Re: [dev] [st] [patch] Ignore numlock (Mod2Mask) for button events too.

I have applied it, but I have mistook and the patch is in the repository with me as author. Please, could you send the patches with git-send-mail?. It will help me to avoid thses kind of errors. git-format-patch is also good ;). -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] Cleanup config.def.h, eliminate mappedkeys, simplify matching.

it. Regards, -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because that is a universal interface' (Doug McIlroy

Re: [dev] [st] [patch] Cleanup config.def.h, eliminate mappedkeys, simplify matching.

or not with this new version. And thank you for your efforts :) -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because

Re: [dev] [st] [patch] Cleanup config.def.h, eliminate mappedkeys, simplify matching.

, but checking every keypress against key bindings seems unreasonable to me. I agree. I don't like the actual solution of this problem, but we need some way of avoiding check all the keys. -- Roberto E. Vargas Caballero ___ 'Write

Re: [dev] [st] [patch] Cleanup config.def.h, eliminate mappedkeys, simplify matching.

0)) continue; - } return kp-s; } -- I agree with Alexander here, and maybe the ?: version could be better. -- Roberto E. Vargas Caballero ___ 'Write programs that do

Re: [dev] [st] [patch] Ignore numlock (Mod2Mask) for button events too.

A bug presents if you try to add a button shortcut to mshortcuts using a mask, for example: { Button3, ShiftMask, hi}, The above does not work if Numlock (Mod2Mask) is on, which is unexpected. I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st][patch] scrollback buffer

, so I don't know what is the next step here. As far as I know there are these solutions: - Ignore the patch - create a wiki where publish these kind of patches - Create a new branc for it What should we do? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [sbase] Command list

find. Regards, -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because that is a universal interface' (Doug McIlroy

Re: [dev] [sbase] Command list

What about: od, logname, uuencode, uudecode, mktemp, passwd, su, sed, patch ed and awk are also missed (yeah, I know they are bigger and more difficult programs, but they are basic for a system). -- Roberto E. Vargas Caballero

Re: [dev] [st][patch] scrollback buffer

, and because they basically impletements a terminal over a terminal, that from my point of view is a non sense (although it's clear that they are useful when you connect to other system through a ssh connection). -- Roberto E. Vargas Caballero

Re: [dev] [sbase] [patch] Add primitive du(1)

is more clear with them. Best regards, -- Roberto E. Vargas Caballero ___ 'Write programs that do one thing and do it well. Write programs to work together. Write programs to handle text streams, because that is a universal

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

this error, it will cause a segmentation fault each time the key is pressed, so you only have to attach and debugger and look the stack trace. It will take only 2 minutes of your life fix the problem. Best regards, -- Roberto E. Vargas Caballero

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

It's runtime segfault (that may be rare and hard to catch) that is worth exactly one additional check. Ok, we don't agree about this topic, so I would like listen the opinion of other suckless developers in order to take a decision. -- Roberto E. Vargas Caballero

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

usually check all the parameters which come from the user, and trust parameters from the own code, because they are my responsability (or in this case, is responsability of the user who modified config.h). -- Roberto E. Vargas Caballero

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

Oops, I realized after a pull that I tried to break style (by declaring a local not at the top of a function). I've corrected that and also rebased these three on the current head. Ok, I will push these changes in the end of this week. Best regards, -- Roberto E. Vargas Caballero

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

! What do you think? -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

Re: [dev] [sbase] [PATCH] ls: add option to reverse the sort order

{ for (i = last-1; i = 0; i--) print line[i]; } -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

On Wed, Oct 02, 2013 at 09:36:27AM +0200, Mark Edgar wrote: On Tue, 1 Oct 2013 23:04:16 +0200, Roberto E. Vargas Caballero wrote: I agree here, good catch and good implementation. Could you send a mail with the patch and a proper commit message? No problem! I think we could avoid some

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

all the things we write to the tty with ttywrite. Let's me test it with some emulators and with my real terminal. I will send the results. Best regards, -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

Re: [dev][st][RFC] Removing the -o option

(the hack is so easy that I am pretty sure if we remove it, we will always can revert the commit easily). Best regards, -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2.com

Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

they should do it, because it must be transparent to the user if the new characters were typed in a keyborad or pasted. 3583: ttywrite(buf, len); It is the usual case when a user type something in the keyboard, so it must be echo'ed. -- Roberto E. Vargas Caballero

<    1   2   3   4   5   6   7   >